flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: Build failed in Jenkins: flex-sdk_mustella #470
Date Mon, 14 Oct 2013 23:35:55 GMT


On 10/14/13 4:06 PM, "Maurice Amsellem" <maurice.amsellem@systar.com>
wrote:
>-------
>Intuitively, I would say that both fixes are OK, but the latter one has
>side effects because of the deferred behavior.
>
>So should I commit the initial fix, although it's not optimal?

I guess it depends on how much time you have.  Obviously, if everyone
fixed bugs in a non-optimal way we'd eventually have performance issues
that would be hard to resolve, but sometimes a fix does require a
performance hit.

If you have time, figuring out if the tests just have a timing assumption
that needs fixing would be best, but I won't veto your original fix.

-Alex


Mime
View raw message