flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From OmPrakash Muppirala <bigosma...@gmail.com>
Subject Re: Build failed in Jenkins: flex-sdk_mustella #460
Date Thu, 10 Oct 2013 06:14:16 GMT
Here is the commit history to the file:

https://fisheye6.atlassian.com/browse/~br=develop/flex-sdk/frameworks/projects/spark/src/mx/core/FTETextField.as

I dont see Nick's revert.

Thanks,
Om


On Wed, Oct 9, 2013 at 11:07 PM, Justin Mclean <justin@classsoftware.com>wrote:

> Hi,
>
> > When I look at the diffs, I don't see the clearFlag line until Nick adds
> it.  The comment above the "if (!stylesheet)" makes me think the flag
> shouldn't be cleared, but I haven't really looked into it.
> If htmlText is set to null I think the HTML flag needs to be cleared, I
> think (but not 100% sure) the original existing code and tests are
> incorrect.
>
> If you set a text field to have html text and then the same (but ordinary
> text) I'd expect the width to change and not be the same each time as the
> styled text (with bold and italics) would be slightly wider than the same
> ordinary text.
>
> > I also took out the clearFlag call and the tests passed.
> If you look at the test they set both htmlText and text which I'm fairly
> sure would trigger the above issue.
>
> > Right now, I'm more puzzled why Nick's revert isn't showing up.
> That Im not sure about, but it could of been me when I accidentally merged
> 4.10 rather than 4.11 and reverted the changes. Hard to tell from the log.
>
> Thanks,
> Justin

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message