flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maurice Amsellem <maurice.amsel...@systar.com>
Subject RE: Build failed in Jenkins: flex-sdk_mustella #470
Date Tue, 15 Oct 2013 18:25:06 GMT
Thanks you for the explanation.


-----Message d'origine-----
De : Alex Harui [mailto:aharui@adobe.com] 
Envoyé : mardi 15 octobre 2013 19:10
À : dev@flex.apache.org
Objet : Re: Build failed in Jenkins: flex-sdk_mustella #470



On 10/15/13 9:52 AM, "Maurice Amsellem" <maurice.amsellem@systar.com>
wrote:

>>I will try to generate and check in png.xml files for the two failing 
>>tests
>
>Not sure to understand what png.xml files are ? the baseline pngs ?
A png.xml file is an XML description of the display list.  We use them when different player
versions or mac-vs-win give slightly different bitmaps.  There are only a few checked in right
now.  CompareBitmap first compares the .png file  and then if it fails it looks for the png.xml
and compares the display list.  The theory is that Flex code really only manipulates display
list properties so if a component is at x=4.5 we don't truly care what pixel colors the player
chooses for pixel 4 and 5, we just want our code to set that component at x=4.5.

Now if the test still fails you can compare the png.xml output and see where the proposed
code did change some display list property.  So far, that's found a few subtle bugs in our
code.

I'm still trying to get the repo back to where those tests pass so I can generate the right
png.xml files, so I'm not ready to check them in just yet.

-Alex


Mime
View raw message