flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Maurice Amsellem <maurice.amsel...@systar.com>
Subject RE: Issue with CallOut ASDOC
Date Sun, 06 Oct 2013 19:10:17 GMT
"arised" of course :-).

My English need some improvement

Maurice 

-----Message d'origine-----
De : Maurice Amsellem [mailto:maurice.amsellem@systar.com] 
Envoyé : dimanche 6 octobre 2013 21:03
À : dev@flex.apache.org
Objet : RE: Issue with CallOut ASDOC

>In fact, I like the mobile skin.  Perhaps we can use the same skin for desktop as well?
 We may want to lighten the default background color to match that of the default >Flex
spark skins, though.

Totally agree.  The desktop skin is very dull in comparison.  So a lighter mobile skin would
be perfect for Desktop.

So I will first try to merge the two host components in one, and then "PC-ize" the mobile
skin.

Do you know if any problems aroused when working on the experimental callout, so that I can
avoid them (ie, benefit from previous experience) ?

Regards,

Maurice 

-----Message d'origine-----
De : omuppi1@gmail.com [mailto:omuppi1@gmail.com] De la part de OmPrakash Muppirala Envoyé :
dimanche 6 octobre 2013 20:55 À : dev@flex.apache.org Objet : Re: Issue with CallOut ASDOC

On Sun, Oct 6, 2013 at 11:11 AM, Maurice Amsellem < maurice.amsellem@systar.com> wrote:

> Hi Team,
>
> Actually, after looking at the experimental CallOut code,  it's 95% 
> similar to the original Callout.
>
> I don't know the story from the beginning, but I think it has been 
> monkey-patched because the properties "actualHorizontalPosition" and 
> "actualVerticalPosition" were protected, to make them accessible 
> (mx_internal).
>
> So now that I know how to change and recompile the SDK :-),
>
> I just made that simple change (ie protected => mx_internal) in the 
> original Callout class, and I can know use it in desktop (ie the 
> callout pops up)
>
> Of course, I used a dumb Skin, to it does not look like a callout at 
> all, but it should be feasible to adapt the experimental CallOutSkin 
> to make it work on the original class.
> And it probably needs some more testing to make sure it works fine.
>
> So maybe we don't even need two classes, after all.
>
> After all, all other spark components (List, Panel, etc..) have the 
> same hostComponent , and only differ by their skin on mobile and 
> desktop platforms.
>
> What do you think?
>

I remember that there was a discussion about this a while ago.  Unsure as to why we decided
on a new component.
But I agree with you that we should merge these two components into one.

In fact, I like the mobile skin.  Perhaps we can use the same skin for desktop as well?  We
may want to lighten the default background color to match that of the default Flex spark skins,
though.

Thanks,
Om


>
> Maurice
>
> -----Message d'origine-----
> De : omuppi1@gmail.com [mailto:omuppi1@gmail.com] De la part de 
> OmPrakash Muppirala Envoyé : dimanche 6 octobre 2013 18:54 À :
> dev@flex.apache.org Objet : Re: Issue with CallOut ASDOC
>
> On Oct 6, 2013 9:13 AM, "Maurice Amsellem" 
> <maurice.amsellem@systar.com>
> wrote:
> >
> > Hi Team,
> >
> > I have noticed some classes asdoc link is broken on
> flex.apache.org/asdoc
> >
> > https://issues.apache.org/jira/browse/FLEX-33802
> >
> > I propose an explanation and two possible fixes , but not sure what 
> > to
> do, because I don't know how the release builds are done and deployed.
> >
> > Can you please confirm/contradict the proposed explanation and which 
> > fix
> should be implemented.
>
> +1 for renaming the fault class names.
>
> Thanks for catching this!
>
> Om
>
> >
> > Regards,
> >
> > Maurice Amsellem
> > SYSTAR R&D - BusinessBridgeFX
> >
>

Mime
View raw message