flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik de Bruin <e...@ixsoftware.nl>
Subject Re: [1/2] git commit: [flex-sdk] [refs/heads/develop] - FLEX-33740 made removedFromStageHandler protected so it could be overridden
Date Wed, 18 Sep 2013 16:50:38 GMT
I think we should leave this for Justin. You break it, you buy it.

It's 3 AM in Sydney, he should be up soon :-)

EdB



On Wed, Sep 18, 2013 at 6:42 PM, Alex Harui <aharui@adobe.com> wrote:
> I think it is nighttime for Justin.  Should we wait for him to revert?
> I'd do the revert myself, but I have other pushable commits pending and
> nervous about following the steps to try to push just a revert.
>
> -Alex
>
> On 9/18/13 8:49 AM, "Erik de Bruin" <erik@ixsoftware.nl> wrote:
>
>>Wow, that broke so hard, Google decided the notification were spam.
>>They got filtered out, so I didn't notice anything until Alex emailed.
>>Sorry about that.
>>
>>I have paused the builds until the commit is reverted.
>>
>>EdB
>>
>>
>>
>>On Wed, Sep 18, 2013 at 4:07 PM, Alex Harui <aharui@adobe.com> wrote:
>>> Justin, please revert. I think it broke the build.
>>>
>>>
>>>
>>>
>>> Sent via the PANTECH Discover, an AT&T 4G LTE smartphone.
>>>
>>> jmclean@apache.org wrote:
>>>
>>>
>>> Updated Branches:
>>>   refs/heads/develop d2768bef3 -> 18ce3aa9f
>>>
>>>
>>> FLEX-33740 made removedFromStageHandler protected so it could be
>>>overridden
>>>
>>>
>>> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>>> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/5d86438e
>>> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/5d86438e
>>> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/5d86438e
>>>
>>> Branch: refs/heads/develop
>>> Commit: 5d86438e5d5a879b0cc6eabe89bd071e0ca515f6
>>> Parents: d2768be
>>> Author: Justin Mclean <jmclean@apache.org>
>>> Authored: Wed Sep 18 18:28:57 2013 +1000
>>> Committer: Justin Mclean <jmclean@apache.org>
>>> Committed: Wed Sep 18 18:28:57 2013 +1000
>>>
>>> ----------------------------------------------------------------------
>>>  .../projects/framework/src/mx/core/UIComponent.as       | 12
>>>++++++++++--
>>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>> ----------------------------------------------------------------------
>>>
>>>
>>>
>>>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/5d86438e/frameworks/
>>>projects/framework/src/mx/core/UIComponent.as
>>> ----------------------------------------------------------------------
>>> diff --git a/frameworks/projects/framework/src/mx/core/UIComponent.as
>>>b/frameworks/projects/framework/src/mx/core/UIComponent.as
>>> index 822b49c..4634e80 100644
>>> --- a/frameworks/projects/framework/src/mx/core/UIComponent.as
>>> +++ b/frameworks/projects/framework/src/mx/core/UIComponent.as
>>> @@ -12665,9 +12665,17 @@ public class UIComponent extends FlexSprite
>>>      }
>>>
>>>      /**
>>> -     *  @private
>>> +     *
>>> +        * Called when a component is removed from the stage.
>>> +        *
>>> +     *  @param event The event object.
>>> +     *
>>> +     *  @langversion 3.0
>>> +     *  @playerversion Flash 9
>>> +     *  @playerversion AIR 1.1
>>> +     *  @productversion Flex 4.11
>>>       */
>>> -    private function removedFromStageHandler(event:Event):void
>>> +    protected function removedFromStageHandler(event:Event):void
>>>      {
>>>          _systemManagerDirty = true;
>>>      }
>>>
>>
>>
>>
>>--
>>Ix Multimedia Software
>>
>>Jan Luykenstraat 27
>>3521 VB Utrecht
>>
>>T. 06-51952295
>>I. www.ixsoftware.nl
>



-- 
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Mime
View raw message