flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: Mustella data grid test failing
Date Thu, 16 May 2013 06:42:54 GMT
OK, saw your changes.

Looks like you've found a way to detect that someone set sort=null without
calling refresh, which is good, but it seems like the ListCollectionView
is in an unsupported state at this point.

I'm just worried that there are other errors waiting to be found when in
this state.  ListCollectionView is used as both an Ilist and an
ICollectionView and there are cases where the underlying list/source
changes, etc.  Seems like the safer route would be to encourage the
developer to call refresh(). Did you consider throwing an error saying you
should call refresh() instead?


On 5/15/13 10:24 PM, "Justin Mclean" <justin@classsoftware.com> wrote:

>> So is your goal to restore Flex 2 behavior?
>No of course not.
>I was just pointing it out why some people did expect that sort = null
>should behave this way. It's not entirely unreasonable to expect that
>setting sort to null without a refresh would remove the sort but let keep
>it so a refresh is needed and see if we can stop the RTEs as well without
>any performance or other side effects. Almost have a solution that I
>believe works in all cases.
>> I'd rather just make sure that there is no undesirable behavior if you
>> call refresh() after setting sort=null.
>Yes I'm checking that as well.

View raw message