Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Received-SPF: pass (athena.apache.org: domain of aharui@adobe.com designates
 64.18.1.241 as permitted sender)
From: Alex Harui <aharui@adobe.com>
To: "dev@flex.apache.org" <dev@flex.apache.org>,
        "commits@flex.apache.org"
	<commits@flex.apache.org>
Date: Tue, 30 Apr 2013 09:20:57 -0700
Subject: Re: [2/2] git commit: [flex-sdk] - FLEX-24197 user name starting
 with a dot shoudl be invalid
Thread-Topic: [2/2] git commit: [flex-sdk] - FLEX-24197 user name starting
 with a dot shoudl be invalid
Thread-Index: Ac5FZAYBxsK5+kVzTQeuJTQIsfisAAAWqvV+
Message-ID: <CDA53D79.520A0%aharui@adobe.com>
In-Reply-To: <9192d12d1c704a94b07a89f2faaa4198@git.apache.org>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-Entourage/13.16.0.130206
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Is "." the only first character that is illegal?  What about other
punctuation and symbols?  Or is it not worth checking for?


On 4/29/13 10:31 PM, "jmclean@apache.org" <jmclean@apache.org> wrote:

> FLEX-24197 user name starting with a dot shoudl be invalid
>=20
>=20
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/18b0dc3a
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/18b0dc3a
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/18b0dc3a
>=20
> Branch: refs/heads/develop
> Commit: 18b0dc3ac77ef6b3fedbdcd25c78ed4abf0d9768
> Parents: bf540f6
> Author: Justin Mclean <jmclean@apache.org>
> Authored: Tue Apr 30 15:30:56 2013 +1000
> Committer: Justin Mclean <jmclean@apache.org>
> Committed: Tue Apr 30 15:30:56 2013 +1000
>=20
> ----------------------------------------------------------------------
>  .../framework/src/mx/validators/EmailValidator.as  |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> ----------------------------------------------------------------------
>=20
>=20
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/18b0dc3a/frameworks/=
proje
> cts/framework/src/mx/validators/EmailValidator.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/framework/src/mx/validators/EmailValidat=
or.as
> b/frameworks/projects/framework/src/mx/validators/EmailValidator.as
> index 9c864dd..f928371 100644
> --- a/frameworks/projects/framework/src/mx/validators/EmailValidator.as
> +++ b/frameworks/projects/framework/src/mx/validators/EmailValidator.as
> @@ -173,6 +173,15 @@ public class EmailValidator extends Validator
> }
> }
>=20
> +  // name can't start with a dot
> +  if (username.charAt(0) =3D=3D '.')
> +  {
> +   results.push(new ValidationResult(
> +    true, baseField, "invalidChar",
> +    validator.invalidCharError));
> +   return results;
> +  }
> + =20
> var domainLen:int =3D domain.length;
>=20
> // check for IP address
>=20

--=20
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui