Return-Path: X-Original-To: apmail-flex-dev-archive@www.apache.org Delivered-To: apmail-flex-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CBE1EF7A2 for ; Fri, 5 Apr 2013 06:47:22 +0000 (UTC) Received: (qmail 37307 invoked by uid 500); 5 Apr 2013 06:47:22 -0000 Delivered-To: apmail-flex-dev-archive@flex.apache.org Received: (qmail 36918 invoked by uid 500); 5 Apr 2013 06:47:21 -0000 Mailing-List: contact dev-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list dev@flex.apache.org Received: (qmail 36883 invoked by uid 99); 5 Apr 2013 06:47:20 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2013 06:47:20 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of harbs.lists@gmail.com designates 209.85.215.169 as permitted sender) Received: from [209.85.215.169] (HELO mail-ea0-f169.google.com) (209.85.215.169) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 05 Apr 2013 06:47:13 +0000 Received: by mail-ea0-f169.google.com with SMTP id n15so1212013ead.14 for ; Thu, 04 Apr 2013 23:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:content-type:content-transfer-encoding:subject:date :message-id:to:mime-version:x-mailer; bh=vbCNpQAimhiE/9sen4tLbmShYuiFD/hLRnYRgkNhPb0=; b=kS+pwwV55HNsW9VHzGAZSeTV0nvIKT22K9Iwev3kyUk+v71eZWpF3/CyuYiKNNwpfM 07jwfM1Hcw6+uZ5jtgcu1n5a/kssav978XaXPbT67wFJkZLamftTRKrL2Yxz9cfyHQAC uxVkBSBeTHkJBGelIaawIuRc2gCa5+gBGTdpRovPubHRfYaWpASvE0KOuAE6j/KQbwU3 JpyYEsyYLM7jrGvMJ4HPSUWvgJTEtaG+45E2SQsxcxu1ALs4Rp9RgKaO46WO2+hCe3Qb RuEy2oLfzMSfWA8NVKWpgzJRsghq6O+LbPKXEfOM0j5D/y1zSsc4EjisOO07av+uigDX UXJw== X-Received: by 10.15.43.132 with SMTP id x4mr16888235eev.31.1365144412872; Thu, 04 Apr 2013 23:46:52 -0700 (PDT) Received: from [192.168.0.2] (89-139-55-249.bb.netvision.net.il. [89.139.55.249]) by mx.google.com with ESMTPS id cd3sm3923569eeb.6.2013.04.04.23.46.51 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 04 Apr 2013 23:46:52 -0700 (PDT) From: Harbs Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: General Questions on committing code Date: Fri, 5 Apr 2013 09:46:49 +0300 Message-Id: <7D1B1466-00C7-492F-8EED-EB1D557A94A1@gmail.com> To: dev@flex.apache.org Mime-Version: 1.0 (Apple Message framework v1283) X-Mailer: Apple Mail (2.1283) X-Virus-Checked: Checked by ClamAV on apache.org I've done some work extending the experimental spark color picker. Besides adding dataProvider support to make it functionally equivalent = to the mx one, I added support for "no color" and proper handling of = null objects in the dataProvider (to indicate "no color"). Although it = seems to work correctly for my personal use, I have not done extensive = testing. Should I commit the code as-is, and hope it works/will be = better tested later? Wait? Something else? I'm just not sure on proper = procedure here=85 Also, is there a policy on code formatting? Do we care that all code = formatting styles match? (i.e. when to use and where to place braces, = line breaks, etc.) If yes, is there a document on this somewhere? Thanks! Harbs=