Return-Path: X-Original-To: apmail-flex-dev-archive@www.apache.org Delivered-To: apmail-flex-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F09D104EC for ; Wed, 24 Apr 2013 21:07:26 +0000 (UTC) Received: (qmail 88570 invoked by uid 500); 24 Apr 2013 21:07:25 -0000 Delivered-To: apmail-flex-dev-archive@flex.apache.org Received: (qmail 88544 invoked by uid 500); 24 Apr 2013 21:07:25 -0000 Mailing-List: contact dev-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list dev@flex.apache.org Received: (qmail 88536 invoked by uid 99); 24 Apr 2013 21:07:25 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Apr 2013 21:07:25 +0000 X-ASF-Spam-Status: No, hits=-1.3 required=5.0 tests=FRT_ADOBE2,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of gosmith@adobe.com designates 64.18.1.37 as permitted sender) Received: from [64.18.1.37] (HELO exprod6og116.obsmtp.com) (64.18.1.37) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Apr 2013 21:07:19 +0000 Received: from outbound-smtp-2.corp.adobe.com ([193.104.215.16]) by exprod6ob116.postini.com ([64.18.5.12]) with SMTP ID DSNKUXhJcoZOYDTUo+RbpD4By/vDszrLiGVb@postini.com; Wed, 24 Apr 2013 14:06:59 PDT Received: from inner-relay-1.corp.adobe.com (ms-exchange.macromedia.com [153.32.1.51]) by outbound-smtp-2.corp.adobe.com (8.12.10/8.12.10) with ESMTP id r3OL6u99019730 for ; Wed, 24 Apr 2013 14:06:57 -0700 (PDT) Received: from nahub01.corp.adobe.com (nahub01.corp.adobe.com [10.8.189.97]) by inner-relay-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id r3OL6lAm017977 for ; Wed, 24 Apr 2013 14:06:56 -0700 (PDT) Received: from nambx05.corp.adobe.com ([10.8.189.124]) by nahub01.corp.adobe.com ([10.8.189.97]) with mapi; Wed, 24 Apr 2013 14:06:38 -0700 From: Gordon Smith To: "dev@flex.apache.org" Date: Wed, 24 Apr 2013 14:06:36 -0700 Subject: RE: [FalconJX][FlexJS] committing? Thread-Topic: [FalconJX][FlexJS] committing? Thread-Index: Ac5BIvGsOomOGtz4RPiqxNT0VNEwuQAAmEuOAAKJ1BA= Message-ID: <149F8129B58B2D418508E63117D9C5419BDEBC3826@nambx05.corp.adobe.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org I think 'git branch -r' may list the remote branches even if you don't have= corresponding local branches. - Gordon -----Original Message----- From: Alex Harui [mailto:aharui@adobe.com]=20 Sent: Wednesday, April 24, 2013 12:53 PM To: dev@flex.apache.org Subject: Re: [FalconJX][FlexJS] committing? That's something I don't like about Git. I have to pull to see a listing of= new public branches. On 4/24/13 12:35 PM, "Erik de Bruin" wrote: > There is (in my GUI at least) now a remote branch 'goog.events'. >=20 > EdB >=20 >=20 >=20 > On Wed, Apr 24, 2013 at 9:20 PM, Alex Harui wrote: >> Also, I am not seeing a new public branch for these changes. Did you=20 >> just commit them instead? >>=20 >>=20 >> On 4/24/13 12:08 PM, "Alex Harui" wrote: >>=20 >>> I'm just starting to look at the diffs. But please, no variables=20 >>> named "assing" :-) >>>=20 >>> So do you really believe it will take more than 6K of minified code=20 >>> to fix any bugs related to events in the current implementation? >>>=20 >>> I'm wondering if the motivation behind goog.events is to get an=20 >>> event system to work across a lot of older browsers we don't care=20 >>> about these days like >>> IE6 and IE7. If that's the case, why take on all of that code? >>>=20 >>> I know when Adobe wrote the JS layer for BrowserManager it had a lot=20 >>> of code paths we can probably drop if we don't have to support older br= owsers. >>>=20 >>> I wouldn't want to take a 6K hit unless we really understand what=20 >>> we're getting for it. >>>=20 >>>=20 >>> On 4/24/13 11:45 AM, "Erik de Bruin" wrote: >>>=20 >>>> In short (I have the branch updated and ready to be published: yes=20 >>>> to all >>>> three: >>>>=20 >>>> 1) it adds about 6k to the file (26k -> 32k) >>>> 2) yes, without modification, so no more IE8Utils or whatever >>>> 3) yes >>>>=20 >>>> But I'll still publish a branch first, so you can see for yourself=20 >>>> (there are some other changes/fixes in there as well). >>>>=20 >>>> EdB >>>>=20 >>>>=20 >>>>=20 >>>> On Wed, Apr 24, 2013 at 8:39 PM, Alex Harui wrote: >>>>> I think I don't have any more commits planned on for flex-asjs=20 >>>>> unless there is a bug fix or two. I'm planning to work on a COMPC=20 >>>>> equivalent for FalconJX. >>>>>=20 >>>>> My only criteria for your proposed switch to goog.events are: >>>>> 1) is the minified js for the example as small as what we have now? >>>>> 2) does it work on IE8? >>>>> 3) when writing AS code, do we still get to use dispatchEvent(new=20 >>>>> Event())? >>>>>=20 >>>>> If the answer to all 3 is yes, then I don't have a problem moving=20 >>>>> over to goog.events. Otherwise, I would say the status quo is the be= tter choice. >>>>>=20 >>>>>=20 >>>>> On 4/24/13 11:21 AM, "Erik de Bruin" wrote: >>>>>=20 >>>>>> BTW: the re-write/refactoring was somewhat major, so I plan to=20 >>>>>> publish my branch first, so we can review and discuss. It will=20 >>>>>> still be nice to have it on par with the 'develop' branch initially,= though. >>>>>>=20 >>>>>> EdB >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>> On Wed, Apr 24, 2013 at 8:10 PM, Erik de Bruin=20 >>>>>> >>>>>> wrote: >>>>>>> Alex, >>>>>>>=20 >>>>>>> I see you're doing some committing. I have the 'goog.events'=20 >>>>>>> based framework done for a previous version of FlexJS and I'm=20 >>>>>>> not waiting to update it to the latest and greatest. >>>>>>>=20 >>>>>>> Do you have any more commits planned for 'today'? >>>>>>>=20 >>>>>>> EdB >>>>>>>=20 >>>>>>>=20 >>>>>>>=20 >>>>>>> -- >>>>>>> Ix Multimedia Software >>>>>>>=20 >>>>>>> Jan Luykenstraat 27 >>>>>>> 3521 VB Utrecht >>>>>>>=20 >>>>>>> T. 06-51952295 >>>>>>> I. www.ixsoftware.nl >>>>>>=20 >>>>>>=20 >>>>>=20 >>>>> -- >>>>> Alex Harui >>>>> Flex SDK Team >>>>> Adobe Systems, Inc. >>>>> http://blogs.adobe.com/aharui >>>>>=20 >>>>=20 >>>>=20 >>=20 >> -- >> Alex Harui >> Flex SDK Team >> Adobe Systems, Inc. >> http://blogs.adobe.com/aharui >>=20 >=20 >=20 -- Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui