flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [FalconJX][FlexJS] Dependency calculations
Date Tue, 09 Apr 2013 16:24:20 GMT
I don't have a test case I can make public.  It appears to be ClassA
requires ClassB requires ClassC requires ClassA.  Which is all valid because
the circularity doesn't involve prototype definitions.

When I was working with FalconJS, I tried the calcdeps.py and it kept
complaining about circular deps.  I may just end up copying my deps
calculator over to FalconJX. I think the key is that the google tools don't
really know the kind of dependency and must report circularities, but we can
trust that circularities are benign in our case because the AS compiler
would have caught it.

I've got a lot of changes locally right now trying to get my "customer" test
case to work.  Hopefully I'll get through it soon.

On 4/9/13 12:27 AM, "Erik de Bruin" <erik@ixsoftware.nl> wrote:

> Alex,
> The current 'publisher' part of FalconJx uses the vanilla
> 'DepsGenerator' functionality of the Closure Compiler. Do you have a
> minimal test case of the kind of circular dependency you are talking
> about? It seems like that should be something that Google should have
> encountered and be able to handle. I'm willing to look into it, but I
> haven't come across it myself, so a test case might come in handy.
> EdB
> On Tue, Apr 9, 2013 at 1:36 AM, Alex Harui <aharui@adobe.com> wrote:
>> Erik,
>> Have you noticed that the google tools seem to be too sensitive to circular
>> dependencies in the goog.requires?   Back when I was using FalconJS, I was
>> trying to use the google tools to compute the deps.js files and it kept
>> failing with circular dependencies.  I ended up writing my own deps
>> calculator that kept track of which classes had already been seen and things
>> seemed to work.
>> In my ³customer¹s² test case, FalconJX is now returning a circular dependency
>> error.  I haven¹t looked into the FalconJX deps logic, but are you also using
>> some google code for that?  Is there some other mechanism other than
>> goog.requires() for dependencies that aren¹t involved in the prototype
>> definition?
>> Thanks,
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui

Alex Harui
Flex SDK Team
Adobe Systems, Inc.

View raw message