flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: git commit: Changed setSelectedIndex from mxinternal to public.
Date Sat, 06 Apr 2013 14:53:49 GMT
Doesn't the ComboBox need its asdoc updated as well?


On 4/6/13 7:09 AM, "mkessler@apache.org" <mkessler@apache.org> wrote:

> Updated Branches:
>   refs/heads/develop 579e7c307 -> 192a5b2a7
> 
> 
> Changed setSelectedIndex from mxinternal to public.
> 
> 
> Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/192a5b2a
> Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/192a5b2a
> Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/192a5b2a
> 
> Branch: refs/heads/develop
> Commit: 192a5b2a70b4fc7326b7337080a1b12063cdd554
> Parents: 579e7c3
> Author: Mark Kessler <KesslerConsulting@gmail.com>
> Authored: Sat Apr 6 10:03:01 2013 -0400
> Committer: Mark Kessler <KesslerConsulting@gmail.com>
> Committed: Sat Apr 6 10:08:00 2013 -0400
> 
> ----------------------------------------------------------------------
>  .../spark/src/spark/components/ComboBox.as         |    2 +-
>  .../spark/components/supportClasses/ListBase.as    |   20 +++++++++-----
>  2 files changed, 14 insertions(+), 8 deletions(-)
> ----------------------------------------------------------------------
> 
> 
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/192a5b2a/frameworks/proje
> cts/spark/src/spark/components/ComboBox.as
> ----------------------------------------------------------------------
> diff --git a/frameworks/projects/spark/src/spark/components/ComboBox.as
> b/frameworks/projects/spark/src/spark/components/ComboBox.as
> index 46d4337..95616d0 100644
> --- a/frameworks/projects/spark/src/spark/components/ComboBox.as
> +++ b/frameworks/projects/spark/src/spark/components/ComboBox.as
> @@ -887,7 +887,7 @@ public class ComboBox extends DropDownListBase implements
> IIMESupport
>      /**
>       * @private
>       */
> -    override mx_internal function setSelectedIndex(value:int,
> dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
> +    override public function setSelectedIndex(value:int,
> dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
>      {
>          // It is possible that the label display changed but the selection
> didn't.  If this is
>          // the case, the label has to be updated since the setSelectedIndex
> code will short-circuit
> 
> http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/192a5b2a/frameworks/proje
> cts/spark/src/spark/components/supportClasses/ListBase.as
> ----------------------------------------------------------------------
> diff --git 
> a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
> b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
> index 3c367a3..20b9ad6 100644
> --- 
> a/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
> +++ 
> b/frameworks/projects/spark/src/spark/components/supportClasses/ListBase.as
> @@ -710,19 +710,25 @@ public class ListBase extends SkinnableDataContainer
>      }
>      
>      /**
> -     *  @private
> -     *  Used internally to specify whether the selectedIndex changed
> programmatically or due to
> -     *  user interaction.
> +     *  <p>The <code>rowIndex</code> is the index in the data provider
> +     *  of the item containing the selected cell.</p>
> +     *
> +     *  @param rowIndex The 0-based row index of the cell.
>       * 
>       *  @param dispatchChangeEvent if true, the component will dispatch a
> "change" event if the
> -     *  value has changed. Otherwise, it will dispatch a "valueCommit" event.
> +     *  rowIndex has changed. Otherwise, it will dispatch a "valueCommit"
> event. 
>       * 
>       *  @param changeCaret if true, the caret will be set to the
> selectedIndex as a side-effect of calling
>       *  this method.  If false, caretIndex won't change.
> +     *
> +     *  @langversion 3.0
> +     *  @playerversion Flash 10
> +     *  @playerversion AIR 1.5
> +     *  @productversion Flex 4
>       */
> -    mx_internal function setSelectedIndex(value:int,
> dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
> +    public function setSelectedIndex(rowIndex:int,
> dispatchChangeEvent:Boolean = false, changeCaret:Boolean = true):void
>      {
> -        if (value == selectedIndex)
> +        if (rowIndex == selectedIndex)
>          {
>              // this should short-circuit, but we should check to make sure
>              // that caret doesn't need to be changed either, as that's a side
> @@ -736,7 +742,7 @@ public class ListBase extends SkinnableDataContainer
>          if (dispatchChangeEvent)
>              dispatchChangeAfterSelection = (dispatchChangeAfterSelection ||
> dispatchChangeEvent);
>          changeCaretOnSelection = changeCaret;
> -        _proposedSelectedIndex = value;
> +        _proposedSelectedIndex = rowIndex;
>          invalidateProperties();
>      }
>  
> 

-- 
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui


Mime
View raw message