flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Mclean <jus...@classsoftware.com>
Subject Re: git commit: [flex-sdk] - FLEX-33526: Added the findRowIndices method to allow array values.
Date Sun, 28 Apr 2013 12:41:19 GMT
Hi,

> You were right.  I've updated it to test for them.  Seems to be good now.

Not a biggie but try be be consistent  with the null checks ie  dataProvider vs values !=
null.

Also nothing wrong with doing something like this at the top of the function.

if (dataProvider == null || values == null)
	return [];

Thanks,
Justin



Mime
View raw message