Mailing-List: contact dev-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Received-SPF: pass (athena.apache.org: local policy)
Message-ID: <20130306123301.89706incrzxu05hp@franklin.liquidweb.com>
Date: Wed, 06 Mar 2013 12:33:01 -0500
From: Michael Schmalle <apache@teotigraphix.com>
To: dev@flex.apache.org
Subject: Re: [FalconJx] binary operator parenthesis
References: <20130306102214.19999nmuuoslpc86@franklin.liquidweb.com>
 <CAJs+wW3w8uu7Hwc9ztcLejoTCY+97UYiu7TzTzUPMpm+E=hMzQ@mail.gmail.com>
 <20130306103719.14726k0b7d7grijz@franklin.liquidweb.com>
 <CAJs+wW3PDbhAr-kHzaW9yK-ED2T2cxaFVmHO1yW+urTYSKzx0A@mail.gmail.com>
 <20130306111138.46456rfzu56z1nzu@franklin.liquidweb.com>
 <CAJs+wW39quvpM_qmzbYHau90LdXE_uf1M2GDBegQbyqWTU0s_g@mail.gmail.com>
 <20130306112907.1473370lwdoqlmfn@franklin.liquidweb.com>
In-Reply-To: <20130306112907.1473370lwdoqlmfn@franklin.liquidweb.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=ISO-8859-1;
 DelSp="Yes";
 format="flowed"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.8)

I'm going to commit my changes;

I ignored 3 unit tests that I will get back to. I am not decided on  
how String literals are handled when a member field resolves to a  
String type. I have normal string concatenation not being parened IE  
"foo" + "bar" + "baz". I know how to fix it, just going to give my  
head time to think about it.

But right now "foo" + bar + "baz"

is getting ("foo" + bar) + "baz", I will fix this when I get the head.  
Other than that all tests pass.

Mike


Quoting Michael Schmalle <apache@teotigraphix.com>:

> Heh,
>
> I wouldn't say awesome but I'm beginning to like this visitor  
> framework more every day because this fix wasn't intrusive at all.
>
> This proves we have it working right; Here is a test that is just plain weird
>
> a = (a + b) - c + d * e;
>
> It now produces;
>
> a = (((a + b) - c) + (d * e))
>
> Notice how it automatically gets the multiply right and deals with  
> the addition paren first.
>
> I might try to work on that outer paren in an assignment expression  
> but we could just leave it as is and it would be fine, just adds a  
> bit more k to a generated file. :)
>
> THere might be some edge cases but I will worry about those later.
>
> Mike
>
>
>
> Quoting Erik de Bruin <erik@ixsoftware.nl>:
>
>>> You're not think 5th dimensionally here;
>>
>> I rarely venture in such an integer state of mind. I'm more of a
>> fractal kinda guy :-)
>>
>>> Currently without fixing this bug a use has the expression statement of;
>>>
>>> var a = ((a + b) - (c + d)) * e;
>>>
>>> They use the compiler, it checks out fine, FalconJx is currently rendering
>>> to JavaScript that will get executed;
>>>
>>> var a = a + b - c + d * e;
>>>
>>> See a problem here?
>>
>> Yes, that's why I wrote you that TODO in the test ;-)
>>
>>> I have tested a fix that produces;
>>>
>>> var a:* = ((a + b) - (c + d)) * e;
>>
>> You are awesome! I might have to come visit you in your universe
>> sometimes, I'm sure you over-hyper-cube-landers can teach me a trick
>> or two.
>>
>> Looking forward to you commit,
>>
>> Have fun!
>>
>> EdB
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
> -- 
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>
>

-- 
Michael Schmalle - Teoti Graphix, LLC
http://www.teotigraphix.com
http://blog.teotigraphix.com