flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erik de Bruin <e...@ixsoftware.nl>
Subject Re: [FalconJx] major commit ready to go...
Date Tue, 05 Mar 2013 06:47:48 GMT
LOL, you told me to discuss first, commit later... which is what I'm doing.

I'm writing a big reply to your comments, just had to get this out of
the way ;-)

EdB



On Mon, Mar 4, 2013 at 10:42 PM, Michael Schmalle
<apache@teotigraphix.com> wrote:
> I see your commit with MXML, where is this other changes?
>
>
> Mike
>
>
> Quoting Erik de Bruin <erik@ixsoftware.nl>:
>
>> Mike et al.,
>>
>> I have a reasonably big commit lined up. To make AS embedded in MXML
>> work without doing duplicate work, I figured I could best use the
>> existing ASEmitter and subclases. To make this work, I needed to add
>> an ASBlockWalker to the MXMLBlockWalker and make adjustments to some
>> existing code (refactoring of interfaces and method signatures,
>> mostly). I was able to keep most of this trickery limited to MXML
>> classes, but I needed to make some changes to these 'common' and AS
>> classes:
>>
>> - renamed IASNodeStrategy to INodeStrategy, as it is now 'common' and
>> used by both AS and MXML; this renaming touches 'a few' other classes,
>> like IJSEmitter and the classes in
>> 'org.apache.flex.compiler.internal.as.codegen'
>> - created IBlockVisitor and IBlockWalker as 'common' interfaces
>> - refactored IASBlockVisitor and IASBlockWalker to extend these new
>> interfaces
>>
>> All tests pass (I even managed to get a few more done for FlexJS) and
>> the road ahead seems clear...
>>
>> Let me know if any of this will break anything beyond repair - or at
>> least beyond a little time spend adjusting code to the new - if I
>> commit these changes,
>>
>> EdB
>>
>>
>>
>> --
>> Ix Multimedia Software
>>
>> Jan Luykenstraat 27
>> 3521 VB Utrecht
>>
>> T. 06-51952295
>> I. www.ixsoftware.nl
>>
>
> --
> Michael Schmalle - Teoti Graphix, LLC
> http://www.teotigraphix.com
> http://blog.teotigraphix.com
>



--
Ix Multimedia Software

Jan Luykenstraat 27
3521 VB Utrecht

T. 06-51952295
I. www.ixsoftware.nl

Mime
View raw message