Return-Path: X-Original-To: apmail-flex-dev-archive@www.apache.org Delivered-To: apmail-flex-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 48F7CDC4E for ; Tue, 8 Jan 2013 12:31:52 +0000 (UTC) Received: (qmail 12081 invoked by uid 500); 8 Jan 2013 12:31:51 -0000 Delivered-To: apmail-flex-dev-archive@flex.apache.org Received: (qmail 12045 invoked by uid 500); 8 Jan 2013 12:31:51 -0000 Mailing-List: contact dev-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list dev@flex.apache.org Received: (qmail 12034 invoked by uid 99); 8 Jan 2013 12:31:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2013 12:31:51 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [69.167.147.50] (HELO franklin.liquidweb.com) (69.167.147.50) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Jan 2013 12:31:45 +0000 Received: from localhost ([127.0.0.1]:58446) by franklin.liquidweb.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.80) (envelope-from ) id 1TsYKx-0005xZ-Il for dev@flex.apache.org; Tue, 08 Jan 2013 07:31:23 -0500 Received: from 70.20.58.119 ([70.20.58.119]) by franklin.liquidweb.com (Horde Framework) with HTTP; Tue, 08 Jan 2013 07:31:23 -0500 Message-ID: <20130108073123.17872r81ppovqm57@franklin.liquidweb.com> Date: Tue, 08 Jan 2013 07:31:23 -0500 From: Michael Schmalle To: dev@flex.apache.org Subject: Re: [FalconJx] AS test for -Infinity failing References: <20130108062852.20387aybi411pvxw@franklin.liquidweb.com> <20130108064223.60695apmanbmrodb@franklin.liquidweb.com> <20130108071409.179458m5a2xn7dzl@franklin.liquidweb.com> <20130108071854.80112isag2mnzage@franklin.liquidweb.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.8) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - franklin.liquidweb.com X-AntiAbuse: Original Domain - flex.apache.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - teotigraphix.com X-Get-Message-Sender-Via: franklin.liquidweb.com: authenticated_id: teotigra/from_h X-Source: X-Source-Args: X-Source-Dir: X-Virus-Checked: Checked by ClamAV on apache.org Quoting Erik de Bruin : > What worries me is not that the test fails (per se), but the way in > which it fails... It seems that '-Infinity' is completely left out of > the 'compiled' string. It vanishes. Is that a byproduct of using the > 'wrong' test (visitVariable) or something deeper? Can you paste your test method so I have some context? > EdB > > > > On Tue, Jan 8, 2013 at 1:18 PM, Michael Schmalle > wrote: >> Yup, >> >> And now looking at the AST, Inifinity is just an Identifier like very other >> IdentifierNode. This means it only has relevance when check the semantics of >> it's location which means, the parser doesn't care about it. >> >> So this is correct that - adds the IdentifierNode node in a >> UnaryOperatorMinusNode. >> >> To test it, you need to call visitUnaryOperator(node). >> >> Mike >> >> >> >> Quoting Michael Schmalle : >> >>> Well, that makes sense because unless -Infinity is a true constant, - is >>> the unary operator to the constant Infinity. Might want to look that up in >>> the definition. >>> >>> Looking through the code now, Infinity is not considered a Literal, so I >>> need to do some more research on that. >>> >>> Mike >>> >>> >>> Quoting Erik de Bruin : >>> >>>> The compiler seems to think that '-Infinity' is a unary operator... >>>> >>>> EdB >>>> >>>> >>>> >>>> On Tue, Jan 8, 2013 at 12:42 PM, Michael Schmalle >>>> wrote: >>>>> >>>>> Wow, your going to make me fire up Apache Eclipse heh? >>>>> >>>>> Should have put a do not disturb on the door knob! ;-) >>>>> >>>>> My guess is it has something to do with the emit Literal, I will check >>>>> on it >>>>> to see if I can come up with the answer. >>>>> >>>>> Let me know if you figure it out though. >>>>> >>>>> >>>>> Mike >>>>> >>>>> Quoting Erik de Bruin : >>>>> >>>>>> The test for Infinity takes 'var a:Number = Infinity;' which compiles >>>>>> (correctly) to 'var a:Number = Infinity' >>>>>> >>>>>> The test for Infinity takes 'var a:Number = -Infinity;' which compiles >>>>>> (wrongly) to 'var a:Number = ' >>>>>> >>>>>> No exceptions are thrown or anything. >>>>>> >>>>>> I'm keeping my commits as small as I can (one feature or fix each, >>>>>> mostly) and I'm testing before each one (most of the time, still >>>>>> sloppy when I get excited ;-)) >>>>>> >>>>>> EdB >>>>>> >>>>>> >>>>>> >>>>>> On Tue, Jan 8, 2013 at 12:28 PM, Michael Schmalle >>>>>> wrote: >>>>>>> >>>>>>> >>>>>>> Hey, >>>>>>> >>>>>>> Hmm... I wonder if it's a Falcon bug? Where is the test dying? >>>>>>> >>>>>>> FYI, I haven't touched any code for about a week or so, I'm working on >>>>>>> an >>>>>>> audio project at the moment(that I'm ridiculously involved in :) ) >>>>>>> >>>>>>> So you are safe with no merge conflicts for now. I will keep updating >>>>>>> to >>>>>>> see >>>>>>> if you have committed anything new. >>>>>>> >>>>>>> Just please... :) Commit small and make sure the whole suite passes. >>>>>>> So >>>>>>> when >>>>>>> I get back to this code I'm not lost. ;-) >>>>>>> >>>>>>> Mike >>>>>>> >>>>>>> >>>>>>> Quoting Erik de Bruin : >>>>>>> >>>>>>>> Mike, >>>>>>>> >>>>>>>> I am working on adding tests for all AS language features and one of >>>>>>>> the first on my list (Full Table the Wiki) is '-Infinity' in the >>>>>>>> Global Constants section. >>>>>>>> >>>>>>>> The AS test I wrote for 'Infinity' passes, but when I add the '-' in >>>>>>>> front of it for the test of negative infinity, the compiler gives up >>>>>>>> and the test fails. >>>>>>>> >>>>>>>> Any ideas? >>>>>>>> >>>>>>>> EdB >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Ix Multimedia Software >>>>>>>> >>>>>>>> Jan Luykenstraat 27 >>>>>>>> 3521 VB Utrecht >>>>>>>> >>>>>>>> T. 06-51952295 >>>>>>>> I. www.ixsoftware.nl >>>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Michael Schmalle - Teoti Graphix, LLC >>>>>>> http://www.teotigraphix.com >>>>>>> http://blog.teotigraphix.com >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Ix Multimedia Software >>>>>> >>>>>> Jan Luykenstraat 27 >>>>>> 3521 VB Utrecht >>>>>> >>>>>> T. 06-51952295 >>>>>> I. www.ixsoftware.nl >>>>>> >>>>> >>>>> -- >>>>> Michael Schmalle - Teoti Graphix, LLC >>>>> http://www.teotigraphix.com >>>>> http://blog.teotigraphix.com >>>>> >>>> >>>> >>>> >>>> -- >>>> Ix Multimedia Software >>>> >>>> Jan Luykenstraat 27 >>>> 3521 VB Utrecht >>>> >>>> T. 06-51952295 >>>> I. www.ixsoftware.nl >>>> >>> >>> -- >>> Michael Schmalle - Teoti Graphix, LLC >>> http://www.teotigraphix.com >>> http://blog.teotigraphix.com >>> >>> >> >> -- >> Michael Schmalle - Teoti Graphix, LLC >> http://www.teotigraphix.com >> http://blog.teotigraphix.com >> > > > > -- > Ix Multimedia Software > > Jan Luykenstraat 27 > 3521 VB Utrecht > > T. 06-51952295 > I. www.ixsoftware.nl > -- Michael Schmalle - Teoti Graphix, LLC http://www.teotigraphix.com http://blog.teotigraphix.com