flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Harui (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33354) [button] define the placement of icon (iconPlacement) in skin [ButtonSkin]
Date Thu, 17 Jan 2013 17:22:12 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556386#comment-13556386
] 

Alex Harui commented on FLEX-33354:
-----------------------------------

I haven't tried it, but try:
<s:SparkSkin>
[....]
<s:HGroup left="10" right="10" top="2" bottom="2">
<s:BitmapImage id="iconDisplay"/>

<s:Image id="myCustomImage"/>

<s:Label id="labelDisplay"/>

</s:HGroup>
[....]
</s:SparkSkin>

I don't think Button requires its skin to be a SparkButtonSkin and if it does, that's probably
a bug.  The SparkButtonSkin was written to support the iconPlacement style.  If you don't
need it, then you can go lower-level.

In theory, as long as you don't need to dictate visual aspects of the skin from the component's
properties and/or styles, you can start with Skin or SparkSkin, add the required SkinParts
and do anything you want in the skin.
                
> [button] define the placement of icon (iconPlacement) in skin [ButtonSkin]
> --------------------------------------------------------------------------
>
>                 Key: FLEX-33354
>                 URL: https://issues.apache.org/jira/browse/FLEX-33354
>             Project: Apache Flex
>          Issue Type: Brainstorming
>          Components: Spark: Button, Spark: ToggleButton
>    Affects Versions: Apache Flex 4.9.0
>            Reporter: Marcus Fritze
>            Priority: Minor
>
> I think it would be better to define the placement of the icon in the button via Skin.
Currently, we set iconPlacement (left, right, bottom, top). I realized that the iconDisplay
is a SkinPart since Flex 4.5, but I can't see it in the default ButtonSkin. And the layout
of the icon, label and custom skin-parts is wrong when I use the "icon" and a Custom Skin
for the Spark Button / ToggleButton.
> Why isn't the iconDisplay in the ButtonSkin?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message