Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B3818D876 for ; Mon, 10 Dec 2012 18:57:16 +0000 (UTC) Received: (qmail 46522 invoked by uid 500); 10 Dec 2012 18:57:15 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 46487 invoked by uid 500); 10 Dec 2012 18:57:15 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 46479 invoked by uid 99); 10 Dec 2012 18:57:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Dec 2012 18:57:15 +0000 X-ASF-Spam-Status: No, hits=-1.3 required=5.0 tests=FRT_ADOBE2,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of aharui@adobe.com designates 64.18.1.39 as permitted sender) Received: from [64.18.1.39] (HELO exprod6og117.obsmtp.com) (64.18.1.39) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Dec 2012 18:57:04 +0000 Received: from outbound-smtp-1.corp.adobe.com ([192.150.11.134]) by exprod6ob117.postini.com ([64.18.5.12]) with SMTP ID DSNKUMYwa6wuiVRK1wZmv5qxTlq/yCn0/mVo@postini.com; Mon, 10 Dec 2012 10:56:44 PST Received: from inner-relay-4.eur.adobe.com (inner-relay-4.adobe.com [193.104.215.14]) by outbound-smtp-1.corp.adobe.com (8.12.10/8.12.10) with ESMTP id qBAIrm1v022831 for ; Mon, 10 Dec 2012 10:53:48 -0800 (PST) Received: from nahub02.corp.adobe.com (nahub02.corp.adobe.com [10.8.189.98]) by inner-relay-4.eur.adobe.com (8.12.10/8.12.9) with ESMTP id qBAItuXY027035 for ; Mon, 10 Dec 2012 10:56:40 -0800 (PST) Received: from SJ1SWM219.corp.adobe.com (10.5.77.61) by nahub02.corp.adobe.com (10.8.189.98) with Microsoft SMTP Server (TLS) id 8.3.279.1; Mon, 10 Dec 2012 10:56:38 -0800 Received: from NAMBX02.corp.adobe.com ([10.8.127.96]) by SJ1SWM219.corp.adobe.com ([fe80::d55c:7209:7a34:fcf7%11]) with mapi; Mon, 10 Dec 2012 10:56:38 -0800 From: Alex Harui To: "flex-dev@incubator.apache.org" Date: Mon, 10 Dec 2012 10:56:27 -0800 Subject: Re: [Falcon] Unit tests failing Thread-Topic: [Falcon] Unit tests failing Thread-Index: Ac3U3K1hkPmOYBY2SY6HKpkK8f97EgAAhvBwAAiRN+IAgJRLoAABK+In Message-ID: In-Reply-To: <149F8129B58B2D418508E63117D9C5419B5B623D41@nambx05.corp.adobe.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Microsoft-Entourage/13.13.0.120411 acceptlanguage: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org OK. Are the feature tests in the ant build? I think they aren't so they didn't break so I didn't notice them. I've got to deal with some mustella issues, then I'll get to this unless yo= u are completely blocked. I think you aren't if you copy the sdk. On 12/10/12 10:27 AM, "Gordon Smith" wrote: > You only made the unit-tests work with a unittest.properties file. I thin= k the > feature-tests need a similar fix. I don't particularly want to have multi= ple > .properties file that have to be configured. Can you please make one, per= haps > at the level of the falcon directory, that can be used by both projects? >=20 > Also, can you please update the Falcon README to explain the .properties = file? >=20 > - Gordon >=20 > -----Original Message----- > From: Alex Harui [mailto:aharui@adobe.com] > Sent: Friday, December 07, 2012 9:01 PM > To: flex-dev@incubator.apache.org > Subject: Re: [Falcon] Unit tests failing >=20 >=20 >=20 >=20 > On 12/7/12 4:56 PM, "Gordon Smith" wrote: >=20 >> It is unacceptable to have to configure every debug config you create. >> I create dozens per day when I work on Falcon. > Agreed. >=20 > After reading up on it, it appears that there is no way to set new defaul= ts > for every individual junit test in Eclipse. So I implemented one > suggestion: instead of environment variables or system properties, the te= sts > will read a compiler.tests/unittest.properties file with FLEX_HOME and > PLAYERGLOBAL_HOME specified in it. If you don't have the file or don't > specify the variables, it will default to the compiler/generated/dist/sdk= that > copy.sdk would create. >=20 >>=20 >> - Gordon >>=20 >> -----Original Message----- >> From: omuppi1@gmail.com [mailto:omuppi1@gmail.com] On Behalf Of Om >> Sent: Friday, December 07, 2012 4:40 PM >> To: flex-dev@incubator.apache.org >> Subject: Re: [Falcon] Unit tests failing >>=20 >> In Eclipse: >>=20 >> Under 'Run' menu > Select "Debug Configurations..." >> On the left, right-click "JUnit" > Select "New" >> When the New Configuration is created, you can customize pretty much >> everything you want: >>=20 >> Try playing with the settings in one of these tabs: >> * Arguments >> * Environment >>=20 >> HTH >>=20 >> Thanks, >> Om >>=20 >> On Fri, Dec 7, 2012 at 4:00 PM, Gordon Smith wrote: >>=20 >>>> Can this really be possible that there is no place to configure >>>> Junit's >>> runtime environment from within Eclipse? >>>=20 >>> I looked in the workspace preferences dialog under Run/Debug > >>> Launching but didn't see a way to do anything useful. >>>=20 >>> - Gordon >>>=20 >>> -----Original Message----- >>> From: Alex Harui [mailto:aharui@adobe.com] >>> Sent: Friday, December 07, 2012 3:52 PM >>> To: flex-dev@incubator.apache.org >>> Subject: Re: [Falcon] Unit tests failing >>>=20 >>>=20 >>>=20 >>>=20 >>> On 12/7/12 3:48 PM, "Gordon Smith" wrote: >>>=20 >>>> And it should NOT require any voodoo to launch Eclipse, such as a >>>> launch script. >>> Agreed >>>>=20 >>>> I would be able to tolerate it requiring a one-time setup in the >>>> Eclipse workspace, but I can't find any place to configure >>>> environment variables there. >>> Can this really be possible that there is no place to configure >>> Junit's runtime environment from within Eclipse? >>>>=20 >>>> - Gordon >>>>=20 >>>>=20 >>>> -----Original Message----- >>>> From: Gordon Smith [mailto:gosmith@adobe.com] >>>> Sent: Friday, December 07, 2012 3:45 PM >>>> To: flex-dev@incubator.apache.org >>>> Subject: RE: [Falcon] Unit tests failing >>>>=20 >>>> All unit tests (at least for Falcon) should be zero-configuration. >>>> You open up a file like MXMLArrayTagTests.java. You double-click the >>>> name of an individual test you want to debug, such as the first one, >>>> MXMLArrayTag_empty(), to select it. Then you right-click on it and >>>> choose Debug As > JUnit Test from the context menu. It should just >>>> work. The default debug configuration that gets created for this >>>> test needs to be sufficient without any additional Program Arguments >>>> or VM >>> Arguments. >>>>=20 >>>> - Gordon >>>>=20 >>>> -----Original Message----- >>>> From: Alex Harui [mailto:aharui@adobe.com] >>>> Sent: Friday, December 07, 2012 3:36 PM >>>> To: flex-dev@incubator.apache.org >>>> Subject: Re: [Falcon] Unit tests failing >>>>=20 >>>> The copy.sdk target is still in there if you need it. >>>>=20 >>>> But first, wow do you use the unit tests from Eclipse? I've never >>>> tried it, I always use the command line. Do you set up a run config >>>> of some sort? If you set a FLEX_HOME in the config's environment >>>> does >>> that work? >>>>=20 >>>> Once I understand how you use Eclipse I will try to get it to work. >>>>=20 >>>>=20 >>>> On 12/7/12 3:27 PM, "Gordon Smith" wrote: >>>>=20 >>>>> After trying and failing to do any Falcon work today, I'll keep >>>>> complaining about this. The unit tests are no longer working in >>>>> Eclipse. I get >>>>>=20 >>>>> command line >>>>> Error: unable to open >>>>> 'D:\Apache\incubator\flex\falcon\trunk\compiler\generated\dist\sdk\ >>>>> fr >>>>> a >>>>> meworks\ >>>>> mxml-2009-manifest.xml'. >>>>>=20 >>>>> command line >>>>> Error: unable to open >>>>> 'D:\Apache\incubator\flex\falcon\trunk\compiler\generated\dist\sdk\ >>>>> fr >>>>> a >>>>> meworks\ >>>>> libs\player\11.1\playerglobal.swc'. >>>>>=20 >>>>> This is presumably because the SDK is no longer being copied into a >>>>> place that the unit tests can find them. The unit tests can't use >>>>> an environment variable to find them because it is infeasible to >>>>> specify that environment every time you want to make an Eclipse >>>>> debug config for a particular unit test. >>>>>=20 >>>>> Is there some way to make this work in Eclipse that I don't know >>>>> about, so that every JUnit test "just work" without having to >>>>> customize a run-config or debug-config for it? >>>>>=20 >>>>> If not, I will restore some ant targets to do the SDK copying. Alex >>>>> may not want to use them, but I need to. >>>>>=20 >>>>> - Gordon >>>>>=20 >>>>>=20 >>>>> -----Original Message----- >>>>> From: Gordon Smith >>>>> Sent: Thursday, December 06, 2012 2:58 PM >>>>> To: flex-dev@incubator.apache.org >>>>> Subject: RE: [Falcon] Unit tests failing >>>>>=20 >>>>> OK, then I'll stop complaining. >>>>>=20 >>>>> - Gordon >>>>>=20 >>>>> -----Original Message----- >>>>> From: Alex Harui [mailto:aharui@adobe.com] >>>>> Sent: Thursday, December 06, 2012 1:59 PM >>>>> To: flex-dev@incubator.apache.org >>>>> Subject: Re: [Falcon] Unit tests failing >>>>>=20 >>>>> The versions in compiler/commandline already looked for FLEX_HOME >>>>> environment variable. >>>>>=20 >>>>>=20 >>>>> On 12/6/12 1:56 PM, "Gordon Smith" wrote: >>>>>=20 >>>>>> I should have said Falcon's 'mxmlc' and 'compc' shell scripts. >>>>>>=20 >>>>>> - Gordon >>>>>>=20 >>>>>> -----Original Message----- >>>>>> From: Gordon Smith >>>>>> Sent: Thursday, December 06, 2012 1:55 PM >>>>>> To: flex-dev@incubator.apache.org >>>>>> Subject: RE: [Falcon] Unit tests failing >>>>>>=20 >>>>>> So, how does Falcon's 'asc' shell script do its job? Did you make >>>>>> it use an environment variable to find an SDK? >>>>>>=20 >>>>>> - Gordon >>>>>>=20 >>>>>> -----Original Message----- >>>>>> From: Alex Harui [mailto:aharui@adobe.com] >>>>>> Sent: Thursday, December 06, 2012 1:40 PM >>>>>> To: flex-dev@incubator.apache.org >>>>>> Subject: Re: [Falcon] Unit tests failing >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>>=20 >>>>>> On 12/6/12 12:57 PM, "Gordon Smith" wrote: >>>>>>=20 >>>>>>> But doesn't it make it impossible to use Falcon's shell scripts, >>>>>>> which expect to find other things in the SDK using relative paths >>>>>>> from those shell scripts??? >>>>>> You mean like the mxmlc and compc scripts? They take a FLEX_HOME >>>>>> environment variable and seem to be working. >>>>>>>=20 >>>>>>> Falcon isn't going to be independent of the SDK in the sense of >>>>>>> being external to it. The goal is for it to replace the old >>>>>>> compiler >>>>>>> *in* the SDK. I don't want to be polluting an SDK with Falcon >>>>>>> until it is ready, but it made sense to me to copy whatever SDK >>>>>>> you want test Falcon with into Falcon's directory, so that >>>>>>> everything is relative to each other as it will eventually be. >>>>>>>=20 >>>>>> I guess I haven't given up on the vision of Falcon being so >>>>>> independent that it doesn't have to be in every SDK release. For >>>>>> sure, I am currently working on a "new SDK" and I want Falcon and >>>>>> FalconJS to work with it. I want to finish the vision of not >>>>>> having to change Falcon for every version of the SDK. >>>>>> That would eventually allow the SDK folder to not contain any java >>>>>> code, and changing SDK versions becomes a matter of changing SWCs >>>>>> and not JARs. >>>>>>=20 >>>>>> And I don't want to eliminate the possibility that someone will >>>>>> take on the effort to integrate Falcon into an IDE. >>>>>>=20 >>>>>> -- >>>>>> Alex Harui >>>>>> Flex SDK Team >>>>>> Adobe Systems, Inc. >>>>>> http://blogs.adobe.com/aharui >>>>>>=20 >>>>>=20 >>>>> -- >>>>> Alex Harui >>>>> Flex SDK Team >>>>> Adobe Systems, Inc. >>>>> http://blogs.adobe.com/aharui >>>>>=20 >>>>=20 >>>> -- >>>> Alex Harui >>>> Flex SDK Team >>>> Adobe Systems, Inc. >>>> http://blogs.adobe.com/aharui >>>>=20 >>>=20 >>> -- >>> Alex Harui >>> Flex SDK Team >>> Adobe Systems, Inc. >>> http://blogs.adobe.com/aharui >>>=20 >>>=20 >=20 > -- > Alex Harui > Flex SDK Team > Adobe Systems, Inc. > http://blogs.adobe.com/aharui >=20 --=20 Alex Harui Flex SDK Team Adobe Systems, Inc. http://blogs.adobe.com/aharui