Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flex-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of gosmith@adobe.com designates
 64.18.1.37 as permitted sender)
From: Gordon Smith <gosmith@adobe.com>
To: "flex-dev@incubator.apache.org" <flex-dev@incubator.apache.org>
Date: Mon, 10 Dec 2012 10:27:21 -0800
Subject: RE: [Falcon] Unit tests failing
Thread-Topic: [Falcon] Unit tests failing
Thread-Index: Ac3U3K1hkPmOYBY2SY6HKpkK8f97EgAAhvBwAAiRN+IAgJRLoA==
Message-ID: 
 <149F8129B58B2D418508E63117D9C5419B5B623D41@nambx05.corp.adobe.com>
References: 
 <149F8129B58B2D418508E63117D9C5419B5B623C3F@nambx05.corp.adobe.com>
 <CCE8099D.49BDF%aharui@adobe.com>
In-Reply-To: <CCE8099D.49BDF%aharui@adobe.com>
Accept-Language: en-US
Content-Language: en-US
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

You only made the unit-tests work with a unittest.properties file. I think =
the feature-tests need a similar fix. I don't particularly want to have mul=
tiple .properties file that have to be configured. Can you please make one,=
 perhaps at the level of the falcon directory, that can be used by both pro=
jects?

Also, can you please update the Falcon README to explain the .properties fi=
le?

- Gordon

-----Original Message-----
From: Alex Harui [mailto:aharui@adobe.com]=20
Sent: Friday, December 07, 2012 9:01 PM
To: flex-dev@incubator.apache.org
Subject: Re: [Falcon] Unit tests failing


On 12/7/12 4:56 PM, "Gordon Smith" <gosmith@adobe.com> wrote:

> It is unacceptable to have to configure every debug config you create.=20
> I create dozens per day when I work on Falcon.
Agreed.

After reading up on it, it appears that there is no way to set new defaults=
 for every individual junit test in Eclipse.  So I implemented one
suggestion: instead of environment variables or system properties, the test=
s will read a compiler.tests/unittest.properties file with FLEX_HOME and PL=
AYERGLOBAL_HOME specified in it.  If you don't have the file or don't speci=
fy the variables, it will default to the compiler/generated/dist/sdk that c=
opy.sdk would create.

>=20
> - Gordon
>=20
> -----Original Message-----
> From: omuppi1@gmail.com [mailto:omuppi1@gmail.com] On Behalf Of Om
> Sent: Friday, December 07, 2012 4:40 PM
> To: flex-dev@incubator.apache.org
> Subject: Re: [Falcon] Unit tests failing
>=20
> In Eclipse:
>=20
> Under 'Run' menu > Select "Debug Configurations..."
> On the left, right-click "JUnit" > Select "New"
> When the New Configuration is created, you can customize pretty much=20
> everything you want:
>=20
> Try playing with the settings in one of these tabs:
> * Arguments
> * Environment
>=20
> HTH
>=20
> Thanks,
> Om
>=20
> On Fri, Dec 7, 2012 at 4:00 PM, Gordon Smith <gosmith@adobe.com> wrote:
>=20
>>> Can this really be possible that there is no place to configure=20
>>> Junit's
>> runtime environment from within Eclipse?
>>=20
>> I looked in the workspace preferences dialog under Run/Debug >=20
>> Launching but didn't see a way to do anything useful.
>>=20
>> - Gordon
>>=20
>> -----Original Message-----
>> From: Alex Harui [mailto:aharui@adobe.com]
>> Sent: Friday, December 07, 2012 3:52 PM
>> To: flex-dev@incubator.apache.org
>> Subject: Re: [Falcon] Unit tests failing
>>=20
>>=20
>>=20
>>=20
>> On 12/7/12 3:48 PM, "Gordon Smith" <gosmith@adobe.com> wrote:
>>=20
>>> And it should NOT require any voodoo to launch Eclipse, such as a=20
>>> launch script.
>> Agreed
>>>=20
>>> I would be able to tolerate it requiring a one-time setup in the=20
>>> Eclipse workspace, but I can't find any place to configure=20
>>> environment variables there.
>> Can this really be possible that there is no place to configure=20
>> Junit's runtime environment from within Eclipse?
>>>=20
>>> - Gordon
>>>=20
>>>=20
>>> -----Original Message-----
>>> From: Gordon Smith [mailto:gosmith@adobe.com]
>>> Sent: Friday, December 07, 2012 3:45 PM
>>> To: flex-dev@incubator.apache.org
>>> Subject: RE: [Falcon] Unit tests failing
>>>=20
>>> All unit tests (at least for Falcon) should be zero-configuration.
>>> You open up a file like MXMLArrayTagTests.java. You double-click the=20
>>> name of an individual test you want to debug, such as the first one,=20
>>> MXMLArrayTag_empty(), to select it. Then you right-click on it and=20
>>> choose Debug As > JUnit Test from the context menu. It should just=20
>>> work. The default debug configuration that gets created for this=20
>>> test needs to be sufficient without any additional Program Arguments=20
>>> or VM
>> Arguments.
>>>=20
>>> - Gordon
>>>=20
>>> -----Original Message-----
>>> From: Alex Harui [mailto:aharui@adobe.com]
>>> Sent: Friday, December 07, 2012 3:36 PM
>>> To: flex-dev@incubator.apache.org
>>> Subject: Re: [Falcon] Unit tests failing
>>>=20
>>> The copy.sdk target is still in there if you need it.
>>>=20
>>> But first, wow do you use the unit tests from Eclipse?  I've never=20
>>> tried it, I always use the command line.  Do you set up a run config=20
>>> of some sort?  If you set a FLEX_HOME in the config's environment=20
>>> does
>> that work?
>>>=20
>>> Once I understand how you use Eclipse I will try to get it to work.
>>>=20
>>>=20
>>> On 12/7/12 3:27 PM, "Gordon Smith" <gosmith@adobe.com> wrote:
>>>=20
>>>> After trying and failing to do any Falcon work today, I'll keep=20
>>>> complaining about this. The unit tests are no longer working in=20
>>>> Eclipse. I get
>>>>=20
>>>> command line
>>>> Error: unable to open
>>>> 'D:\Apache\incubator\flex\falcon\trunk\compiler\generated\dist\sdk\
>>>> fr
>>>> a
>>>> meworks\
>>>> mxml-2009-manifest.xml'.
>>>>=20
>>>> command line
>>>> Error: unable to open
>>>> 'D:\Apache\incubator\flex\falcon\trunk\compiler\generated\dist\sdk\
>>>> fr
>>>> a
>>>> meworks\
>>>> libs\player\11.1\playerglobal.swc'.
>>>>=20
>>>> This is presumably because the SDK is no longer being copied into a=20
>>>> place that the unit tests can find them. The unit tests can't use=20
>>>> an environment variable to find them because it is infeasible to=20
>>>> specify that environment every time you want to make an Eclipse=20
>>>> debug config for a particular unit test.
>>>>=20
>>>> Is there some way to make this work in Eclipse that I don't know=20
>>>> about, so that every JUnit test "just work" without having to=20
>>>> customize a run-config or debug-config for it?
>>>>=20
>>>> If not, I will restore some ant targets to do the SDK copying. Alex=20
>>>> may not want to use them, but I need to.
>>>>=20
>>>> - Gordon
>>>>=20
>>>>=20
>>>> -----Original Message-----
>>>> From: Gordon Smith
>>>> Sent: Thursday, December 06, 2012 2:58 PM
>>>> To: flex-dev@incubator.apache.org
>>>> Subject: RE: [Falcon] Unit tests failing
>>>>=20
>>>> OK, then I'll stop complaining.
>>>>=20
>>>> - Gordon
>>>>=20
>>>> -----Original Message-----
>>>> From: Alex Harui [mailto:aharui@adobe.com]
>>>> Sent: Thursday, December 06, 2012 1:59 PM
>>>> To: flex-dev@incubator.apache.org
>>>> Subject: Re: [Falcon] Unit tests failing
>>>>=20
>>>> The versions in compiler/commandline already looked for FLEX_HOME=20
>>>> environment variable.
>>>>=20
>>>>=20
>>>> On 12/6/12 1:56 PM, "Gordon Smith" <gosmith@adobe.com> wrote:
>>>>=20
>>>>> I should have said Falcon's 'mxmlc' and 'compc' shell scripts.
>>>>>=20
>>>>> - Gordon
>>>>>=20
>>>>> -----Original Message-----
>>>>> From: Gordon Smith
>>>>> Sent: Thursday, December 06, 2012 1:55 PM
>>>>> To: flex-dev@incubator.apache.org
>>>>> Subject: RE: [Falcon] Unit tests failing
>>>>>=20
>>>>> So, how does Falcon's 'asc' shell script do its job? Did you make=20
>>>>> it use an environment variable to find an SDK?
>>>>>=20
>>>>> - Gordon
>>>>>=20
>>>>> -----Original Message-----
>>>>> From: Alex Harui [mailto:aharui@adobe.com]
>>>>> Sent: Thursday, December 06, 2012 1:40 PM
>>>>> To: flex-dev@incubator.apache.org
>>>>> Subject: Re: [Falcon] Unit tests failing
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>=20
>>>>> On 12/6/12 12:57 PM, "Gordon Smith" <gosmith@adobe.com> wrote:
>>>>>=20
>>>>>> But doesn't it make it impossible to use Falcon's shell scripts,=20
>>>>>> which expect to find other things in the SDK using relative paths=20
>>>>>> from those shell scripts???
>>>>> You mean like the mxmlc and compc scripts?  They take a FLEX_HOME=20
>>>>> environment variable and seem to be working.
>>>>>>=20
>>>>>> Falcon isn't going to be independent of the SDK in the sense of=20
>>>>>> being external to it. The goal is for it to replace the old=20
>>>>>> compiler
>>>>>> *in* the SDK. I don't want to be polluting an SDK with Falcon=20
>>>>>> until it is ready, but it made sense to me to copy whatever SDK=20
>>>>>> you want test Falcon with into Falcon's directory, so that=20
>>>>>> everything is relative to each other as it will eventually be.
>>>>>>=20
>>>>> I guess I haven't given up on the vision of Falcon being so=20
>>>>> independent that it doesn't have to be in every SDK release.  For=20
>>>>> sure, I am currently working on a "new SDK" and I want Falcon and=20
>>>>> FalconJS to work with it.  I want to finish the vision of not=20
>>>>> having to change Falcon for every version of the SDK.
>>>>> That would eventually allow the SDK folder to not contain any java=20
>>>>> code, and changing SDK versions becomes a matter of changing SWCs=20
>>>>> and not JARs.
>>>>>=20
>>>>> And I don't want to eliminate the possibility that someone will=20
>>>>> take on the effort to integrate Falcon into an IDE.
>>>>>=20
>>>>> --
>>>>> Alex Harui
>>>>> Flex SDK Team
>>>>> Adobe Systems, Inc.
>>>>> http://blogs.adobe.com/aharui
>>>>>=20
>>>>=20
>>>> --
>>>> Alex Harui
>>>> Flex SDK Team
>>>> Adobe Systems, Inc.
>>>> http://blogs.adobe.com/aharui
>>>>=20
>>>=20
>>> --
>>> Alex Harui
>>> Flex SDK Team
>>> Adobe Systems, Inc.
>>> http://blogs.adobe.com/aharui
>>>=20
>>=20
>> --
>> Alex Harui
>> Flex SDK Team
>> Adobe Systems, Inc.
>> http://blogs.adobe.com/aharui
>>=20
>>=20

--
Alex Harui
Flex SDK Team
Adobe Systems, Inc.
http://blogs.adobe.com/aharui