Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flex-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of cyrill.zadra@gmail.com
 designates 209.85.220.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <149F8129B58B2D418508E63117D9C5419B5B35FEEE@nambx05.corp.adobe.com>
References: 
 <CAOHe5BFU2pwc-Md86vYVSdLV=WDAQNex2FDnkBRQJotwMzWa2Q@mail.gmail.com>
	<CCCB090D.4891C%aharui@adobe.com>
	<CAOHe5BE0h=f5Ps3cOt9dbVpF78BsQfUyU8qtWMBJv2cLFZt_Wg@mail.gmail.com>
	<CAOHe5BGCEjAtBv-7ExLr5Yu4kwKuBz3BL1nhq=cuk09h2mQ01A@mail.gmail.com>
	<149F8129B58B2D418508E63117D9C5419B5B35FEEE@nambx05.corp.adobe.com>
Date: Fri, 16 Nov 2012 18:37:53 -0800
Message-ID: 
 <CAOHe5BGk1dko7z9i-OboawzOANrJ0Z6Wp1C6iQi0ryMFhfoDKA@mail.gmail.com>
Subject: Re: [FALCON] Problem with \uFEFF chararcters in mustella files
From: Cyrill Zadra <cyrill.zadra@gmail.com>
To: "flex-dev@incubator.apache.org" <flex-dev@incubator.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

Hi Gordon

I think so too.. I'll try to create a list with all the affected files
and if there aren't too much I'll replace them manually .. otherwise
there is maybe a way to do it by script.

cyrill


Am 16.11.2012 um 11:15 schrieb Gordon Smith <gosmith@adobe.com>:

> I believe a BOM is only a BOM if it's at the beginning of the file. So I think Falcon is correct to complain and the files should be fixed.
>
> - Gordon
>
> -----Original Message-----
> From: Cyrill Zadra [mailto:cyrill.zadra@gmail.com]
> Sent: Friday, November 16, 2012 1:58 AM
> To: flex-dev@incubator.apache.org
> Subject: Re: [FALCON] Problem with \uFEFF chararcters in mustella files
>
> I may have found the problem. It looks like there are files where the BOM isn't at the beginning of a file and thats the case where falcon can run into problems.
>
> ActionScript Example
>
> ////////////////////////////////////////////////////////////////////////////////
> //
> //  Apache License Header
> //
> ////////////////////////////////////////////////////////////////////////////////
> BOMpackage ...
> {
>
> }
>
> cyrill
>
> On Thu, Nov 15, 2012 at 10:44 PM, Cyrill Zadra <cyrill.zadra@gmail.com> wrote:
>> Thanks Alex. Just looked into falcon code and found.a few places where
>> it already ignore the BOM. So it must be a rare exception. I'll take a
>> look into that and try to find out in which exception it fails.
>>
>> cyrill
>>
>> On Thu, Nov 15, 2012 at 9:03 PM, Alex Harui <aharui@adobe.com> wrote:
>>>
>>>
>>>
>>> On 11/15/12 8:22 PM, "Cyrill Zadra" <cyrill.zadra@gmail.com> wrote:
>>>
>>>> Hi
>>>>
>>>> In the mustella tests there are files that contains \uFEFF (just
>>>> before the package declaration) and in some cases falcon has problem
>>>> with this character and ends with the error:
>>>>
>>>> [java] Error: Unexpected character. '?' is not allowed here [java]
>>>> ?package assets.styleTest
>>>>
>>>> Following command searches for non-ascii chars and if executed in
>>>> mustella folder it returns quite a big result.
>>>>
>>>> grep --color='auto' -I -R -P -n "^[\x80-\xFF]" *
>>>>
>>>> Are those characters really supposed to be there?
>>>
>>> See [1].  Falcon will have to learn to ignore them.
>>>
>>> [1]
>>> http://www.rgagnon.com/javadetails/java-handle-utf8-file-with-bom.htm
>>> l
>>>
>>> --
>>> Alex Harui
>>> Flex SDK Team
>>> Adobe Systems, Inc.
>>> http://blogs.adobe.com/aharui
>>>