Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flex-dev@incubator.apache.org
Date: Thu, 18 Oct 2012 14:54:03 +0000 (UTC)
From: =?utf-8?Q?Fr=C3=A9d=C3=A9ric_THOMAS_=28JIRA=29?= <jira@apache.org>
To: flex-dev@incubator.apache.org
Message-ID: <1977784810.64177.1350572043852.JavaMail.jiratomcat@arcas>
In-Reply-To: <1319328667.44692.1350290283313.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (FLEX-33216) Chart initialization performance
 degradation between Flex 3 and Flex 4
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/FLEX-33216?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1347=
9051#comment-13479051 ]=20

Fr=C3=A9d=C3=A9ric THOMAS commented on FLEX-33216:
----------------------------------------

Just uploaded a patch.

The charts in flex 3 had statics initializer for the styles, it's not the c=
ase in flex 4, at each addChild the styles are re-computed, It should have =
one static initializer per moduleFactory.

Example on CartesianChart :

instead of :
private var _moduleFactoryInitialized:Boolean =3D false;

should be :
private static var _moduleFactoryInitialized:Dictionary=3D new Dictionary(t=
rue);


instead of :

override public function set moduleFactory(factory:IFlexModuleFactory):void
{
    super.moduleFactory =3D factory;

    if (_moduleFactoryInitialized)
        return;

    _moduleFactoryInitialized =3D true;


    // our style settings
    initStyles();
    styleManager.registerInheritingStyle("axisTitleStyleName");
}

should be :

override public function set moduleFactory(factory:IFlexModuleFactory):void
{
    super.moduleFactory =3D factory;

    if (_moduleFactoryInitialized[factory])
        return;

    _moduleFactoryInitialized[factory] =3D true;


    // our style settings
    initStyles();
    styleManager.registerInheritingStyle("axisTitleStyleName");
}

I did that in every charts when needed and tested it against our big compan=
y project, it does the job.

               =20
> Chart initialization performance degradation between Flex 3 and Flex 4
> ----------------------------------------------------------------------
>
>                 Key: FLEX-33216
>                 URL: https://issues.apache.org/jira/browse/FLEX-33216
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Charts
>    Affects Versions: Adobe Flex SDK 4.1 (Release), Adobe Flex SDK 4.5 (Re=
lease), Adobe Flex SDK 4.6 (Release)
>            Reporter: Maurice Amsellem
>              Labels: performance
>         Attachments: FLEX-33216.patch
>
>
> Chart initialization is around 35-40% slower in Flex4 than in Flex3.
> This is true for almost all chart types (Bar, Pie, Column, etc.)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrato=
rs
For more information on JIRA, see: http://www.atlassian.com/software/jira