flex-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carol Frampton (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-33156) focusInHandler() in spark Scroller doesn't null check focusManager property before using
Date Thu, 18 Oct 2012 18:50:05 GMT

    [ https://issues.apache.org/jira/browse/FLEX-33156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13479234#comment-13479234

Carol Frampton commented on FLEX-33156:

So why isn't the change?  Note the usage of fm in fm.getFocus() since you have it locally
you might as well use it.

        var fm:IFocusManager = focusManager;
        // When we gain focus, make sure the focused element is visible
        if (fm && viewport && ensureElementIsVisibleForSoftKeyboard)
            var elt:IVisualElement = fm.getFocus() as IVisualElement; 
            lastFocusedElement = elt;

> focusInHandler() in spark Scroller doesn't null check focusManager property before using
> ----------------------------------------------------------------------------------------
>                 Key: FLEX-33156
>                 URL: https://issues.apache.org/jira/browse/FLEX-33156
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Spark: Scroller
>    Affects Versions: Adobe Flex SDK 4.6 (Release)
>            Reporter: Roland Zwaga
>             Fix For: Adobe Flex SDK Next
>         Attachments: Scroller.as.patch
> the focusHandler() method wrongfully assumes that the focusManager is always a valid
instance. When checking the focusManager property in UIComponent it is clear that in certain
cases this property can return a null value.
> So in some cases this can lead to an RTE. I have encountered this once in my current
project but find it very hard to reproduce. Basically a Scroller instance that was displayed
in a popup window gave this RTE after the popup was removed.
> Reproducable or not, I believe the null check should be added seeing the fact that the
focusManager property explicitly returns null in some cases.
> I have attached a patch file which adds the null check.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message