Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: flex-dev@incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <CBDC1E3E.1520D%cframpto@adobe.com>
References: <CBDC1E3E.1520D%cframpto@adobe.com>
Date: Thu, 24 May 2012 13:53:03 +0200
Message-ID: 
 <CAEWfVJ=_rZv75sZSqqdr6xiOL4KyxkhO3h1d4B6NnziGCY+ieQ@mail.gmail.com>
Subject: Re: [Mentor] review NOTICE and LICENSE files
From: Bertrand Delacretaz <bdelacretaz@apache.org>
To: flex-dev@incubator.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, May 18, 2012 at 9:41 PM, Carol Frampton <cframpto@adobe.com> wrote:
> ...I did some work on the NOTICE and LICENSE files this afternoon. =C2=A0=
I'd appreciate it if you could take a
> quick look and provide feedback on what doesn't look right or is the wron=
g format, what's missing etc?...

LICENSE and NOTICE mostly look good to me, see comments below.

> ...The LICENSE.bin file gets concatenated to the LICENSE file for the bin=
ary distribution...

Apache projects release only source code - if a convenience binary
package is planned, let's discuss it separately.

Additional comments:

1) About http://svn.apache.org/repos/asf/incubator/flex/trunk/LICENSE :

Looks ok to me, but I don't know enough about the codebase to check if
everything that needs to be mentioned is in there.

It might be good to better separate the first main license from the
additional ones, similar to the "APACHE HTTP SERVER SUBCOMPONENTS"
intro paragraph at
http://svn.apache.org/repos/asf/httpd/httpd/trunk/LICENSE - that
explains why those additions are in there.

The note about "modules/asc" says "all rights reserved", that's not an
acceptable license IMO, this needs to be clarified. Either Adobe had
the right to donate that's code and it's now Apache licensed, or the
license must be clarified.

You can omit the notes about other Apache software, we don't usually
add those. But IIUC Flex now contains forks of other Apache projects
that will be released independently from those project's releases,
that's something that needs to be discussed. Maybe at least change
package names to avoid confusion, or better, contribute any patches to
those projects.

I don't understand why there's an "Adobe Flex" MPL license in there,
that code has been donated to Apache and will be released under the
Apache License.

2) About http://svn.apache.org/repos/asf/incubator/flex/trunk/NOTICE

Should say "Apache Flex", not "Adobe Flex" ;-)

"Mountain View Compiler Company" should probably be "Copyright
Mountain View Compiler Company"

"Copyright =C3=82=C2=A9 2001 Robert Penner" has invalid characters.

I'll answer your other questions in a separate message for clarity.

HTH,
-Bertrand