Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E2D729C9F for ; Thu, 1 Mar 2012 04:17:30 +0000 (UTC) Received: (qmail 3176 invoked by uid 500); 1 Mar 2012 04:17:30 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 3043 invoked by uid 500); 1 Mar 2012 04:17:30 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 3014 invoked by uid 99); 1 Mar 2012 04:17:29 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2012 04:17:29 +0000 X-ASF-Spam-Status: No, hits=3.2 required=5.0 tests=FRT_ADOBE2,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: 209.85.214.175 is neither permitted nor denied by domain of rsantos@spectacompany.com.br) Received: from [209.85.214.175] (HELO mail-tul01m020-f175.google.com) (209.85.214.175) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2012 04:17:24 +0000 Received: by obqv19 with SMTP id v19so256247obq.6 for ; Wed, 29 Feb 2012 20:17:04 -0800 (PST) Received-SPF: pass (google.com: domain of rsantos@spectacompany.com.br designates 10.182.182.101 as permitted sender) client-ip=10.182.182.101; Authentication-Results: mr.google.com; spf=pass (google.com: domain of rsantos@spectacompany.com.br designates 10.182.182.101 as permitted sender) smtp.mail=rsantos@spectacompany.com.br Received: from mr.google.com ([10.182.182.101]) by 10.182.182.101 with SMTP id ed5mr1232766obc.64.1330575424324 (num_hops = 1); Wed, 29 Feb 2012 20:17:04 -0800 (PST) Received: by 10.182.182.101 with SMTP id ed5mr1073323obc.64.1330575424199; Wed, 29 Feb 2012 20:17:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.182.216.68 with HTTP; Wed, 29 Feb 2012 20:16:44 -0800 (PST) In-Reply-To: <495b7c54$7c9fe67a$2c564539$@com> References: <495b7c54$7c9fe67a$2c564539$@com> From: Rafael Santos Date: Thu, 1 Mar 2012 01:16:44 -0300 Message-ID: Subject: Re: referencing JIRA issues in code To: flex-dev@incubator.apache.org, flex@rduartes.net Content-Type: multipart/alternative; boundary=14dae9399b19819ac204ba26bb94 X-Gm-Message-State: ALoCoQlhub2k78kdNTZPrqZuQZhEELL2HAC6gtZgm4vjOsG3PXVVYhiELbtsOB92sLHjd/PrNG7q X-Virus-Checked: Checked by ClamAV on apache.org --14dae9399b19819ac204ba26bb94 Content-Type: text/plain; charset=ISO-8859-1 Isnt it possible to relate SVN and JIRA in the commit comment? That is very usefull for backtracking.... Maybe use pre-commit scripts that forbid svn commits that don't refer to a JIRA issue... https://studio.plugins.atlassian.com/wiki/display/CMMT/JIRA+Commit+Acceptance Rafael Santos - Specta On Wed, Feb 29, 2012 at 11:11, Rui Silva wrote: > I agree with Carol. No bug numbers in code except where the solution is so > complex or so awkward that it requires some background (possibly > attachments and discussion thread from the JIRA issue. > > Rui > > -------- Original Message -------- > > From: "Carol Frampton" > > Sent: segunda-feira, 27 de Fevereiro de 2012 15:16 > > To: "flex-dev@incubator.apache.org" > > Subject: Re: referencing JIRA issues in code > > > > I really dislike bug numbers in the code. As other said the svn history > > is there. The only time where it might be ok is if it is a very complex > > issue which needs lots and lots of explanation and you don't want to > > clutter the code with a comment with that much detail. You should still > > put in a summary comment with the bug number, in this format: [FLEX-99]. > > > > Carol > > > > On 2/27/12 3 :03AM, "Alex Harui" wrote: > > > > > > > > > > > > > >On 2/26/12 2:32 PM, "Justin Mclean" wrote: > > > > > >> Hi, > > >> > > >> Just wondering what the policy should be on referencing JIRA issues > in > > >>code > > >> comments > > >> > > >> Do we: > > >> 1. Don't need to do it as it's contained in the SVN history > > >> > > >Adobe policy was not to put bug numbers in the code. I believe there > are > > >some exceptions though. > > > > > >-- > > >Alex Harui > > >Flex SDK Team > > >Adobe Systems, Inc. > > >http://blogs.adobe.com/aharui > > > > > > --14dae9399b19819ac204ba26bb94--