From flex-dev-return-6140-apmail-incubator-flex-dev-archive=incubator.apache.org@incubator.apache.org Thu Mar 8 00:22:38 2012 Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 488A19081 for ; Thu, 8 Mar 2012 00:22:38 +0000 (UTC) Received: (qmail 11131 invoked by uid 500); 8 Mar 2012 00:22:37 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 10990 invoked by uid 500); 8 Mar 2012 00:22:37 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 10969 invoked by uid 99); 8 Mar 2012 00:22:37 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Mar 2012 00:22:37 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL,TO_NO_BRKTS_PCNT X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.213.175] (HELO mail-yx0-f175.google.com) (209.85.213.175) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Mar 2012 00:22:29 +0000 Received: by yenm3 with SMTP id m3so3240224yen.6 for ; Wed, 07 Mar 2012 16:22:08 -0800 (PST) Received: by 10.236.175.162 with SMTP id z22mr8739449yhl.119.1331166128220; Wed, 07 Mar 2012 16:22:08 -0800 (PST) Received: from [192.168.0.4] (124-149-169-202.dyn.iinet.net.au. [124.149.169.202]) by mx.google.com with ESMTPS id b4sm39622734anb.22.2012.03.07.16.22.05 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 07 Mar 2012 16:22:07 -0800 (PST) Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Apple Message framework v1257) Subject: Re: [Proposal] New Component: Toast Notification From: Justin Mclean In-Reply-To: Date: Thu, 8 Mar 2012 11:22:01 +1100 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: flex-dev@incubator.apache.org X-Mailer: Apple Mail (2.1257) X-Gm-Message-State: ALoCoQkcBS0bVAeyH6e26h9rQ3S+sfXAyl7gqbn/HBTeENSqyF9w5J9xF135BKsDO31RXYQMm5tP X-Virus-Checked: Checked by ClamAV on apache.org Hi, > The code is available at: > = http://code.google.com/p/flex-spark-toast/source/browse/#svn%2Ftrunk%2Ffle= x-spark-toast Great contribution.=20 A couple of minor points.=20 1. Files need an apache header. 2. I think the logic in the show method regarding !showing and = popupTimer reset may not be correct. Not 100% sure.=20 3. A simple example showing how it should typically be used would help. I've not done a lot of mobile work so perhaps some of the people on the = list more experienced with writing mobile components can add more = feedback. The biggest issue I see to having this included in a future SDK is that = there are no tests. As we're waiting on Mustella to be donated it would = be good to see some FlexUnit tests giving the component a workout. Before this code was accepted as part of the Flex SDK you would most = likely need to sign and submit a CLA[1]. Thanks, Justin 1. http://www.apache.org/licenses/#clas