Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 212A69A3D for ; Fri, 24 Feb 2012 22:43:42 +0000 (UTC) Received: (qmail 65376 invoked by uid 500); 24 Feb 2012 22:43:41 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 65297 invoked by uid 500); 24 Feb 2012 22:43:41 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 65289 invoked by uid 99); 24 Feb 2012 22:43:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 22:43:41 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.210.47] (HELO mail-pz0-f47.google.com) (209.85.210.47) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 22:43:32 +0000 Received: by daln34 with SMTP id n34so2577885dal.6 for ; Fri, 24 Feb 2012 14:43:11 -0800 (PST) Received-SPF: pass (google.com: domain of justin@classsoftware.com designates 10.68.236.136 as permitted sender) client-ip=10.68.236.136; Authentication-Results: mr.google.com; spf=pass (google.com: domain of justin@classsoftware.com designates 10.68.236.136 as permitted sender) smtp.mail=justin@classsoftware.com Received: from mr.google.com ([10.68.236.136]) by 10.68.236.136 with SMTP id uu8mr13042583pbc.21.1330123391561 (num_hops = 1); Fri, 24 Feb 2012 14:43:11 -0800 (PST) Received: by 10.68.236.136 with SMTP id uu8mr10753468pbc.21.1330123391488; Fri, 24 Feb 2012 14:43:11 -0800 (PST) Received: from [192.168.0.4] (124-169-147-157.dyn.iinet.net.au. [124.169.147.157]) by mx.google.com with ESMTPS id s1sm5468713pbs.21.2012.02.24.14.43.09 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 24 Feb 2012 14:43:10 -0800 (PST) From: Justin Mclean Mime-Version: 1.0 (Apple Message framework v1257) Content-Type: multipart/alternative; boundary="Apple-Mail=_A072E4EA-2EAB-4101-AA4C-0ECC10AD7AF3" Subject: Re: [CODE] Short cleanup Date: Sat, 25 Feb 2012 09:43:04 +1100 In-Reply-To: <149F8129B58B2D418508E63117D9C5419B0DBE7CEF@nambx05.corp.adobe.com> To: flex-dev@incubator.apache.org References: <149F8129B58B2D418508E63117D9C5419B0DBE7CDA@nambx05.corp.adobe.com> <149F8129B58B2D418508E63117D9C5419B0DBE7CEF@nambx05.corp.adobe.com> Message-Id: <2CA7EAD6-C212-4412-9B8C-E739F5EFD641@classsoftware.com> X-Mailer: Apple Mail (2.1257) X-Gm-Message-State: ALoCoQnpTeEXPd9bhm+sftPz5s2c5PUo6Z+8FQDxIrH4BqGVPfrvja7WTN0LnvK/DQOGTtsh9IEr X-Virus-Checked: Checked by ClamAV on apache.org --Apple-Mail=_A072E4EA-2EAB-4101-AA4C-0ECC10AD7AF3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi, > I think it would be better to have the VERSION constant injected by = the compiler. That would be my preferred option but only if it's easily possible. I = assume it's a little harder to do than a a couple of files of ANT? I = assume we wouldn't want this added to all classes just the SDK one so = would have to be some condition based on a list of namespaces (which may = change?) Not having looked at the code I'm just guessing here and could = be way off the mark. And not sure it could deal with the constants in FlexVersion.as such as: public static const CURRENT_VERSION:uint =3D 0x04060000; public static const VERSION_4_6:uint =3D 0x04060000; Which an ANT script would be able to. This file could be hand edited = each time (as I assume has been done in the past) but would be nice if = the Flex SDK version was set somewhere just once and all changes follow = on from that. Thanks, Justin= --Apple-Mail=_A072E4EA-2EAB-4101-AA4C-0ECC10AD7AF3--