Return-Path: X-Original-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-flex-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A1579E28 for ; Sun, 15 Jan 2012 19:37:39 +0000 (UTC) Received: (qmail 74181 invoked by uid 500); 15 Jan 2012 19:37:39 -0000 Delivered-To: apmail-incubator-flex-dev-archive@incubator.apache.org Received: (qmail 74121 invoked by uid 500); 15 Jan 2012 19:37:38 -0000 Mailing-List: contact flex-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: flex-dev@incubator.apache.org Delivered-To: mailing list flex-dev@incubator.apache.org Received: (qmail 74113 invoked by uid 99); 15 Jan 2012 19:37:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Jan 2012 19:37:38 +0000 X-ASF-Spam-Status: No, hits=0.3 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_SOFTFAIL X-Spam-Check-By: apache.org Received-SPF: softfail (athena.apache.org: transitioning domain of david@davidarno.org does not designate 209.85.212.175 as permitted sender) Received: from [209.85.212.175] (HELO mail-wi0-f175.google.com) (209.85.212.175) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 15 Jan 2012 19:37:30 +0000 Received: by wibhn14 with SMTP id hn14so442247wib.6 for ; Sun, 15 Jan 2012 11:37:09 -0800 (PST) Received: by 10.180.19.42 with SMTP id b10mr9692506wie.13.1326656229317; Sun, 15 Jan 2012 11:37:09 -0800 (PST) Received: from kindred (188-220-92-24.zone11.bethere.co.uk. [188.220.92.24]) by mx.google.com with ESMTPS id fy5sm29470353wib.7.2012.01.15.11.37.05 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 15 Jan 2012 11:37:08 -0800 (PST) From: "David Arno" To: Subject: Overly large classes (was Flex incubation on Apache as Opensource) Date: Sun, 15 Jan 2012 19:37:09 -0000 Message-ID: <060d01ccd3bd$1414aa00$3c3dfe00$@davidarno.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AczTvNBzNXIVK/kDSQaRud4/U6Q6HA== Content-Language: en-gb > To: flex-dev@incubator.apache.org > Subject: Re: Flex incubation on Apache as Opensource > I think it should be clarified that a class or function with what we > would determine is a high number of lines of code does not mean > that its an indicator of crap code. I disagree. From experience there is a strong correlation between class size and the quality of the code. > With those taken into account the line count might be ~ 8000 (just guessing). I again agree with Omar. If your class goes over 500 lines, then serious alarm bells should be ringing. I work on the basis that any class over 200 lines (including braces and comments) needs serious justification as it's got too big. So whether it is 16,000 lines or 8,000 lines makes no difference: it's still between 40 and 80 times larger than a well designed class should be. David