Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D23E2200CEC for ; Tue, 1 Aug 2017 00:31:28 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D0DF716615F; Mon, 31 Jul 2017 22:31:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C5ECF16614F for ; Tue, 1 Aug 2017 00:31:27 +0200 (CEST) Received: (qmail 90582 invoked by uid 500); 31 Jul 2017 22:31:24 -0000 Mailing-List: contact commits-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list commits@flex.apache.org Received: (qmail 90465 invoked by uid 99); 31 Jul 2017 22:31:24 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Jul 2017 22:31:24 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 95076F3345; Mon, 31 Jul 2017 22:31:23 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: piotrz@apache.org To: commits@flex.apache.org Date: Mon, 31 Jul 2017 22:31:56 -0000 Message-Id: <1de0d837959f4280b9e809732659e670@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: =?utf-8?b?WzM1LzUwXSBbYWJicnZdIGZsZXgtYXNqcyBnaXQgY29tbWl0OiBJ4oCZ?= =?utf-8?q?m_not_positive=2C_but_without_this=2C_there_is_likely_going_to_be?= =?utf-8?q?_problems_with_variable_renaming_in_minified_code=2E?= archived-at: Mon, 31 Jul 2017 22:31:29 -0000 I’m not positive, but without this, there is likely going to be problems with variable renaming in minified code. Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c1661203 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c1661203 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c1661203 Branch: refs/heads/feature/amf Commit: c16612031792e5c8ace964bcabaf131c89ddfd9a Parents: 60f223a Author: Harbs Authored: Wed Jul 26 14:58:15 2017 +0300 Committer: Harbs Committed: Wed Jul 26 14:58:15 2017 +0300 ---------------------------------------------------------------------- .../src/main/flex/org/apache/flex/events/KeyboardEvent.as | 10 ++++++++-- .../src/main/flex/org/apache/flex/events/MouseEvent.as | 8 +++++++- 2 files changed, 15 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c1661203/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as index dda7e0a..71b4dd1 100644 --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as @@ -221,7 +221,13 @@ package org.apache.flex.events COMPILE::JS override public function preventDefault():void { - wrappedEvent ? wrappedEvent.preventDefault() : super.preventDefault(); + if(wrappedEvent) + wrappedEvent.preventDefault(); + else + { + super.preventDefault(); + _defaultPrevented = true; + } } COMPILE::JS @@ -245,7 +251,7 @@ package org.apache.flex.events { _defaultPrevented = value; } - + /** * Create a copy/clone of the KeyboardEvent object. * http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c1661203/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as index 1b6fe7e..14a3af7 100644 --- a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as +++ b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent.as @@ -449,7 +449,13 @@ package org.apache.flex.events */ override public function preventDefault():void { - wrappedEvent ? wrappedEvent.preventDefault() : super.preventDefault(); + if(wrappedEvent) + wrappedEvent.preventDefault(); + else + { + super.preventDefault(); + _defaultPrevented = true; + } } private var _defaultPrevented:Boolean;