flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: [8/8] flex-asjs git commit: stopPropogation on the goog BrowserEvent is needed. I don’t know if the stopImmediatePropagation on the real browser event actually does anything and I don’t know how to test.
Date Thu, 20 Jul 2017 08:01:33 GMT
To test, wouldn't you just add multiple listeners to the element and the
wrapper?

HTH,
-Alex

On 7/20/17, 12:05 AM, "harbs@apache.org" <harbs@apache.org> wrote:

>stopPropogation on the goog BrowserEvent is needed.
>I don???t know if the stopImmediatePropagation on the real browser event
>actually does anything and I don???t know how to test.
>
>
>Project: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Frepo&data=02%7C01%7C%7Cb5625927d26
>d4a41b6e008d4cf3daa2a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C6363613
>11137863712&sdata=TG42kPtUCn%2BTmLbJND9NCDvwlSgqtyXXNMImV4TIgEA%3D&reserve
>d=0
>Commit: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fcommit%2Fc14db8d7&data=02%7C01%7C%
>7Cb5625927d26d4a41b6e008d4cf3daa2a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%
>7C0%7C636361311137863712&sdata=16VrJeSKg2T8nRIFmiaTlm8ZwMAbIDXbJaImX%2BNVZ
>1I%3D&reserved=0
>Tree: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Ftree%2Fc14db8d7&data=02%7C01%7C%7C
>b5625927d26d4a41b6e008d4cf3daa2a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636361311137863712&sdata=aBvDjh18%2BgEfBBohL1MvqoibjQpEPDNaq%2Bu%2Bsdh
>HcwI%3D&reserved=0
>Diff: 
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc14db8d7&data=02%7C01%7C%7C
>b5625927d26d4a41b6e008d4cf3daa2a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C
>0%7C636361311137863712&sdata=A7OBs%2F1%2Fv%2B5AfVH7iPQmDt0%2FeNYHqeoVEtjN%
>2BYPv09c%3D&reserved=0
>
>Branch: refs/heads/browser-event
>Commit: c14db8d7c1aaa5507c197ca1e07e08f53cee628d
>Parents: 9d76666
>Author: Harbs <harbs@in-tools.com>
>Authored: Thu Jul 20 10:05:04 2017 +0300
>Committer: Harbs <harbs@in-tools.com>
>Committed: Thu Jul 20 10:05:04 2017 +0300
>
>----------------------------------------------------------------------
> .../Core/src/main/flex/org/apache/flex/events/BrowserEvent.as     | 2 +-
> .../Core/src/main/flex/org/apache/flex/events/KeyboardEvent.as    | 3 +++
> .../Core/src/main/flex/org/apache/flex/events/MouseEvent.as       | 3 +++
> 3 files changed, 7 insertions(+), 1 deletion(-)
>----------------------------------------------------------------------
>
>
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc14db8d7%2Fframeworks%2Fpro
>jects%2FCore%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fevents%2FBrowserE
>vent.as&data=02%7C01%7C%7Cb5625927d26d4a41b6e008d4cf3daa2a%7Cfa7b1b5a7b344
>38794aed2c178decee1%7C0%7C0%7C636361311138019965&sdata=37Y%2F%2F%2F380CsQh
>pw%2FZy%2FRizdsEuoe8fv46UlWogxTnbw%3D&reserved=0
>----------------------------------------------------------------------
>diff --git 
>a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEve
>nt.as 
>b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEve
>nt.as
>index d86fbd8..1c93b6b 100644
>--- 
>a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEve
>nt.as
>+++ 
>b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/BrowserEve
>nt.as
>@@ -440,7 +440,7 @@ package org.apache.flex.events
> 		public function stopImmediatePropagation():void
> 		{
> 			wrappedEvent.event_.stopImmediatePropagation(); // not in
>goog.events.BrowserEvent
>-			// wrappedEvent.stopPropagation();
>+			wrappedEvent.stopPropagation();
> 		}
> 
>         /**
>
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc14db8d7%2Fframeworks%2Fpro
>jects%2FCore%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fevents%2FKeyboard
>Event.as&data=02%7C01%7C%7Cb5625927d26d4a41b6e008d4cf3daa2a%7Cfa7b1b5a7b34
>438794aed2c178decee1%7C0%7C0%7C636361311138019965&sdata=qLmdd5v747jAm%2BJU
>e9P%2BDfk1jWQveKI1q1CSuI%2F5vpk%3D&reserved=0
>----------------------------------------------------------------------
>diff --git 
>a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEv
>ent.as 
>b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEv
>ent.as
>index b89dbff..d4f6e18 100644
>--- 
>a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEv
>ent.as
>+++ 
>b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/KeyboardEv
>ent.as
>@@ -150,7 +150,10 @@ package org.apache.flex.events
> 		override public function stopImmediatePropagation():void
> 		{
>             if(wrappedEvent)
>+            {
>+			    wrappedEvent.stopPropagation();
> 			    wrappedEvent["event_"].stopImmediatePropagation();
>+            }
> 		}
> 
>         /**
>
>https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit-wip-us
>.apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fblob%2Fc14db8d7%2Fframeworks%2Fpro
>jects%2FCore%2Fsrc%2Fmain%2Fflex%2Forg%2Fapache%2Fflex%2Fevents%2FMouseEve
>nt.as&data=02%7C01%7C%7Cb5625927d26d4a41b6e008d4cf3daa2a%7Cfa7b1b5a7b34438
>794aed2c178decee1%7C0%7C0%7C636361311138019965&sdata=vORM4I3Yco2kWjFKIPwvw
>Kk5BHyiHHwMcsAwMMUbrVE%3D&reserved=0
>----------------------------------------------------------------------
>diff --git 
>a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent
>.as 
>b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent
>.as
>index 8231e20..fbd445c 100644
>--- 
>a/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent
>.as
>+++ 
>b/frameworks/projects/Core/src/main/flex/org/apache/flex/events/MouseEvent
>.as
>@@ -501,7 +501,10 @@ package org.apache.flex.events
> 		override public function stopImmediatePropagation():void
> 		{
>             if(wrappedEvent)
>+            {
>+			    wrappedEvent.stopPropagation();
> 			    wrappedEvent["event_"].stopImmediatePropagation();
>+            }
> 		}
> 
>         /**
>

Mime
View raw message