Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 60014200CBA for ; Sun, 18 Jun 2017 14:36:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 5F11A160BFD; Sun, 18 Jun 2017 12:36:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 904F0160BF8 for ; Sun, 18 Jun 2017 14:36:16 +0200 (CEST) Received: (qmail 42818 invoked by uid 500); 18 Jun 2017 12:36:14 -0000 Mailing-List: contact commits-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list commits@flex.apache.org Received: (qmail 42174 invoked by uid 99); 18 Jun 2017 12:36:13 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jun 2017 12:36:13 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 46944F4A4B; Sun, 18 Jun 2017 12:36:12 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: piotrz@apache.org To: commits@flex.apache.org Date: Sun, 18 Jun 2017 12:36:37 -0000 Message-Id: In-Reply-To: <8640c0fdc8a9493b96830fe71c10bd3f@git.apache.org> References: <8640c0fdc8a9493b96830fe71c10bd3f@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [26/50] [abbrv] git commit: [flex-asjs] [refs/heads/tlf] - Improves for Wipe effect in js, to get tween replays working in FlexJSStore example archived-at: Sun, 18 Jun 2017 12:36:17 -0000 Improves for Wipe effect in js, to get tween replays working in FlexJSStore example Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/9e226721 Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/9e226721 Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/9e226721 Branch: refs/heads/tlf Commit: 9e2267216d160ed3b56f092f7f73e008b8312b9a Parents: 1af9cc8 Author: greg-dove Authored: Fri Jun 9 10:10:11 2017 +1200 Committer: greg-dove Committed: Fri Jun 9 10:18:54 2017 +1200 ---------------------------------------------------------------------- .../src/main/flex/org/apache/flex/effects/PlatformWiper.as | 2 +- .../Effects/src/main/flex/org/apache/flex/effects/Wipe.as | 9 +++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/9e226721/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/PlatformWiper.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/PlatformWiper.as b/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/PlatformWiper.as index 0e04f47..a9a1a3f 100644 --- a/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/PlatformWiper.as +++ b/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/PlatformWiper.as @@ -97,7 +97,7 @@ public class PlatformWiper } COMPILE::JS { - if (value == null) + if (_target && value != _target) { if (_overflow == null) delete _target.positioner.style["overflow"]; http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/9e226721/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/Wipe.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/Wipe.as b/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/Wipe.as index fe83935..bfd3f56 100644 --- a/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/Wipe.as +++ b/frameworks/projects/Effects/src/main/flex/org/apache/flex/effects/Wipe.as @@ -140,15 +140,20 @@ public class Wipe extends Tween implements IDocument public function onTweenUpdate(value:Number):void { - trace(actualTarget, value); wiper.visibleRect = new Rectangle(0, 0, actualTarget.width, value); } public function onTweenEnd(value:Number):void { // WipeUp makes something disappear - if (direction == "up") + if (direction == "up") { actualTarget.visible = false; + COMPILE::JS { + //reset height in js + actualTarget.positioner.style.height = this.startValue+"px"; + } + } + wiper.target = null; } }