flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshtynj...@apache.org
Subject git commit: [flex-sdk] [refs/heads/develop] - FLEX-35329: fixed issue where initializing member variable/constant that is [Deprecated] incorrectly throws extra warning
Date Thu, 22 Jun 2017 17:53:57 GMT
Repository: flex-sdk
Updated Branches:
  refs/heads/develop e66554e9b -> bb7447f5e


FLEX-35329: fixed issue where initializing member variable/constant that is [Deprecated] incorrectly
throws extra warning


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/bb7447f5
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/bb7447f5
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/bb7447f5

Branch: refs/heads/develop
Commit: bb7447f5ebe32ce58f85a9e9b2d2ffc48994cf42
Parents: e66554e
Author: Josh Tynjala <joshtynjala@apache.org>
Authored: Thu Jun 22 10:53:50 2017 -0700
Committer: Josh Tynjala <joshtynjala@apache.org>
Committed: Thu Jun 22 10:53:50 2017 -0700

----------------------------------------------------------------------
 RELEASE_NOTES                                   | 42 ++++++++++++++++++++
 .../macromedia/asc/embedding/LintEvaluator.java |  8 +++-
 2 files changed, 49 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/bb7447f5/RELEASE_NOTES
----------------------------------------------------------------------
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index 5aaadc3..b82ea1f 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -1,3 +1,45 @@
+Apache Flex 4.17.0
+==================
+
+
+New Features
+------------
+
+
+AIR and Flash Player Support
+----------------------------
+
+
+Bug Fixes
+---------
+FLEX-35329  Initializing member variable/constant that is [Deprecated]
+            incorrectly throws extra warning
+
+Known Issues
+------------
+
+Adobe Flash Builder Integration
+
+Adobe Flash Builder 4.7 and Adobe Flash Builder 4.6 both contain a bug where,
+when generating the .mxml file for a new project that uses Apache Flex SDK
+4.10.0 or later Spark Application, Flash Builder will incorrectly insert the
+attribute:
+
+    layout="absolute"
+
+This results in a compile error in the new project.  The remedy is to simply
+remove the errant attribute.
+
+The following wiki page has been set up to contain the latest news on Adobe's
+attempt to correct this problem:
+
+    https://cwiki.apache.org/confluence/display/FLEX/Adobe+Flash+Builder+'New+Project'+Bug
+
+Adobe has provided a patch for Flash Builder 4.7 that resolves this issue:
+
+    http://helpx.adobe.com/flash-builder/kb/flex-new-project-issue--.html
+
+
 Apache Flex 4.16.0
 ==================
 

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/bb7447f5/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java
----------------------------------------------------------------------
diff --git a/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java b/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java
index de2ea96..359af64 100644
--- a/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java
+++ b/modules/asc/src/java/macromedia/asc/embedding/LintEvaluator.java
@@ -749,8 +749,14 @@ public final class LintEvaluator extends Emitter implements Evaluator,
ErrorCons
 			boolean is_unbound_ref       = is_unbound_dotref || is_unbound_lexref || is_unbound_globalref;
 
 
-			if (slot != null )
+			if (slot != null && !(node.expr instanceof QualifiedIdentifierNode))
+			{
+				//if it's a qualified identifier node, then it's a member/static
+				//variable on a class that is being initialized, like this:
+				//public var memberVar:String = "hi";
+				//this case should not have a warning!
 				checkDeprecatedSlot(cx, node.expr, node.ref, slot);
+			}
 			
 			// special case to avoid warning on access to a Class's prototype property.  This
 			//  property can't be expressed in global.as because you can't both declare a class


Mime
View raw message