Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B50FB200CB5 for ; Tue, 23 May 2017 09:16:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id B3BA6160BD6; Tue, 23 May 2017 07:16:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 017E0160BDB for ; Tue, 23 May 2017 09:16:10 +0200 (CEST) Received: (qmail 39181 invoked by uid 500); 23 May 2017 07:16:10 -0000 Mailing-List: contact commits-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list commits@flex.apache.org Received: (qmail 38498 invoked by uid 99); 23 May 2017 07:16:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 23 May 2017 07:16:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4F273E3823; Tue, 23 May 2017 07:16:09 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: aharui@apache.org To: commits@flex.apache.org Date: Tue, 23 May 2017 07:16:17 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [09/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - get rid of background Sprite. Draw directly in the renderer sprite. Otherwise the sprite will be seen by layout and isn't an layout child archived-at: Tue, 23 May 2017 07:16:11 -0000 get rid of background Sprite. Draw directly in the renderer sprite. Otherwise the sprite will be seen by layout and isn't an layout child Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/198ab8ad Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/198ab8ad Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/198ab8ad Branch: refs/heads/release0.8.0 Commit: 198ab8ad994a57f9763f92c02fd225a347e3a240 Parents: 6832946 Author: Alex Harui Authored: Sun May 21 23:29:12 2017 -0700 Committer: Alex Harui Committed: Tue May 23 00:15:56 2017 -0700 ---------------------------------------------------------------------- .../html/supportClasses/DataItemRenderer.as | 22 ++++---------------- 1 file changed, 4 insertions(+), 18 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/198ab8ad/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/DataItemRenderer.as ---------------------------------------------------------------------- diff --git a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/DataItemRenderer.as b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/DataItemRenderer.as index 7154689..c1da93c 100644 --- a/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/DataItemRenderer.as +++ b/frameworks/projects/Basic/src/main/flex/org/apache/flex/html/supportClasses/DataItemRenderer.as @@ -111,23 +111,9 @@ package org.apache.flex.html.supportClasses _dataField = value; } - COMPILE::SWF - private var background:Sprite; - COMPILE::JS private var controller:ItemRendererMouseController; - /** - * @private - */ - COMPILE::SWF - override public function addedToParent():void - { - super.addedToParent(); - - background = new Sprite(); - addChild(background); - } /** * @private @@ -138,10 +124,10 @@ package org.apache.flex.html.supportClasses { super.updateRenderer(); - background.graphics.clear(); - background.graphics.beginFill(useColor, (down||selected||hovered)?1:0); - background.graphics.drawRect(0, 0, width, height); - background.graphics.endFill(); + graphics.clear(); + graphics.beginFill(useColor, (down||selected||hovered)?1:0); + graphics.drawRect(0, 0, width, height); + graphics.endFill(); } COMPILE::JS {