flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bigosma...@apache.org
Subject git commit: [flex-asjs] [refs/heads/feature/fontawesome] - Add some comments
Date Sun, 08 Jan 2017 07:20:26 GMT
Repository: flex-asjs
Updated Branches:
  refs/heads/feature/fontawesome 7c793d55b -> 4d34b4820


Add some comments


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/4d34b482
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/4d34b482
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/4d34b482

Branch: refs/heads/feature/fontawesome
Commit: 4d34b48204742acce678c602df764de73214d2a7
Parents: 7c793d5
Author: OmPrakash Muppirala <bigosmallm@gmail.com>
Authored: Sat Jan 7 23:20:13 2017 -0800
Committer: OmPrakash Muppirala <bigosmallm@gmail.com>
Committed: Sat Jan 7 23:20:13 2017 -0800

----------------------------------------------------------------------
 .../main/flex/itemRenderers/MemberItemRenderer.mxml    |  2 +-
 .../main/flex/org/apache/flex/fa/FontAwesomeIcon.as    | 13 +++++++++++--
 2 files changed, 12 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4d34b482/examples/flexjs/FlexTeamPage_MDL/src/main/flex/itemRenderers/MemberItemRenderer.mxml
----------------------------------------------------------------------
diff --git a/examples/flexjs/FlexTeamPage_MDL/src/main/flex/itemRenderers/MemberItemRenderer.mxml
b/examples/flexjs/FlexTeamPage_MDL/src/main/flex/itemRenderers/MemberItemRenderer.mxml
index 4456822..09484b2 100644
--- a/examples/flexjs/FlexTeamPage_MDL/src/main/flex/itemRenderers/MemberItemRenderer.mxml
+++ b/examples/flexjs/FlexTeamPage_MDL/src/main/flex/itemRenderers/MemberItemRenderer.mxml
@@ -74,7 +74,7 @@ limitations under the License.
             </mdl:Button>
             <mdl:Button colored="true" fab="true" ripple="true" raised="false">
                 <mdl:materialIcon>
-                    <fa:FontAwesomeIcon iconType="{FontAwesomeIconType.GITHUB}" />
+                    <fa:FontAwesomeIcon iconType="{FontAwesomeIconType.GITHUB}" fixedWidth="true"
/>
                 </mdl:materialIcon>
             </mdl:Button>
             <mdl:Button colored="true" fab="true" ripple="true" raised="false">

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/4d34b482/frameworks/projects/FontAwesome/src/main/flex/org/apache/flex/fa/FontAwesomeIcon.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/FontAwesome/src/main/flex/org/apache/flex/fa/FontAwesomeIcon.as
b/frameworks/projects/FontAwesome/src/main/flex/org/apache/flex/fa/FontAwesomeIcon.as
index b25cea2..62f3189 100644
--- a/frameworks/projects/FontAwesome/src/main/flex/org/apache/flex/fa/FontAwesomeIcon.as
+++ b/frameworks/projects/FontAwesome/src/main/flex/org/apache/flex/fa/FontAwesomeIcon.as
@@ -107,8 +107,12 @@ package org.apache.flex.fa
                 element.classList.add(_iconType);
             }
 		}
-		
-		
+
+        /**
+         * To increase icon sizes relative to their container,
+         * use the X1 (33% increase), X2, X3, X4, or X5.
+         *
+         */
         public function get size():String
         {
             return _size;
@@ -129,6 +133,11 @@ package org.apache.flex.fa
             }
         }
 
+        /**
+         * Set icons at a fixed width.
+         * Great to use when different icon widths throw off alignment.
+         * Especially useful in things like nav lists & list groups.
+         */
         public function get fixedWidth():Boolean
         {
             return _fixedWidth;


Mime
View raw message