flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bigosma...@apache.org
Subject [27/38] git commit: [flex-asjs] [refs/heads/feature/fontawesome] - Fix Slider change event causing stack overflow
Date Wed, 04 Jan 2017 02:19:09 GMT
Fix Slider change event causing stack overflow


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/57536525
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/57536525
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/57536525

Branch: refs/heads/feature/fontawesome
Commit: 575365258208238f4b73407ed5730aaca1450aad
Parents: 54cc4d5
Author: Carlos Rovira <carlosrovira@apache.org>
Authored: Tue Jan 3 12:29:00 2017 +0100
Committer: Carlos Rovira <carlosrovira@apache.org>
Committed: Tue Jan 3 12:29:00 2017 +0100

----------------------------------------------------------------------
 .../flex/mdl/beads/controllers/SliderMouseController.as       | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/57536525/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/controllers/SliderMouseController.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/controllers/SliderMouseController.as
b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/controllers/SliderMouseController.as
index a99f8f7..d001923 100644
--- a/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/controllers/SliderMouseController.as
+++ b/frameworks/projects/MaterialDesignLite/src/main/flex/org/apache/flex/mdl/beads/controllers/SliderMouseController.as
@@ -32,6 +32,7 @@ package org.apache.flex.mdl.beads.controllers
     COMPILE::JS
     {
 		import goog.events;
+        import goog.events.EventType;
         import org.apache.flex.events.BrowserEvent;
         import org.apache.flex.mdl.Slider;
     }
@@ -96,8 +97,8 @@ package org.apache.flex.mdl.beads.controllers
                 //goog.events.listen(track.element, goog.events.EventType.CLICK, handleTrackClick,
false, this);
                 //goog.events.listen(thumb.element, goog.events.EventType.MOUSEDOWN, handleThumbDown,
false, this);
 
-                goog.events.listen(UIBase(_strand).element, "change", handleChange, false,
this);
-                goog.events.listen(UIBase(_strand).element, "input", handleInput, false,
this);
+                goog.events.listen(UIBase(_strand).element, goog.events.EventType.CHANGE,
handleChange, false, this);
+                goog.events.listen(UIBase(_strand).element, goog.events.EventType.INPUT,
handleInput, false, this);
             }
 		}
 
@@ -110,7 +111,7 @@ package org.apache.flex.mdl.beads.controllers
 
             rangeModel.value = Number((UIBase(_strand).element as HTMLInputElement).value);
 
-            host.dispatchEvent(new org.apache.flex.events.Event('change'));
+            //host.dispatchEvent(new org.apache.flex.events.Event('change')); --- This is
not needed, the event is thrown in the main comp
         }
 
         /**


Mime
View raw message