Return-Path:
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
by cust-asf2.ponee.io (Postfix) with ESMTP id 3C5EE200BB7
for ; Wed, 9 Nov 2016 14:52:20 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
id 3B23B160AFD; Wed, 9 Nov 2016 13:52:20 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
by cust-asf.ponee.io (Postfix) with SMTP id 80B29160AEE
for ; Wed, 9 Nov 2016 14:52:19 +0100 (CET)
Received: (qmail 9115 invoked by uid 500); 9 Nov 2016 13:52:18 -0000
Mailing-List: contact commits-help@flex.apache.org; run by ezmlm
Precedence: bulk
List-Help:
List-Unsubscribe:
List-Post:
List-Id:
Reply-To: dev@flex.apache.org
Delivered-To: mailing list commits@flex.apache.org
Received: (qmail 9107 invoked by uid 99); 9 Nov 2016 13:52:18 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Nov 2016 13:52:18 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
id 99DC7E09D3; Wed, 9 Nov 2016 13:52:18 +0000 (UTC)
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: mihaic@apache.org
To: commits@flex.apache.org
Date: Wed, 09 Nov 2016 13:52:18 -0000
Message-Id:
X-Mailer: ASF-Git Admin Mailer
Subject: [1/2] git commit: [flex-sdk] [refs/heads/release4.16.0] - FLEX-34880
Added an asdoc recommendation that developers use Sort and SortField as
immutable objects, although the current API allows for mutability.
archived-at: Wed, 09 Nov 2016 13:52:20 -0000
Repository: flex-sdk
Updated Branches:
refs/heads/release4.16.0 13183954e -> 78431c690
FLEX-34880
Added an asdoc recommendation that developers use Sort and SortField as immutable objects, although the current API allows for mutability.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/4ead7712
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/4ead7712
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/4ead7712
Branch: refs/heads/release4.16.0
Commit: 4ead7712d68ef40449f58d031031b305f38b5739
Parents: 286a0ca
Author: Mihai Chira
Authored: Wed Nov 9 14:51:10 2016 +0100
Committer: Mihai Chira
Committed: Wed Nov 9 14:51:10 2016 +0100
----------------------------------------------------------------------
frameworks/projects/framework/src/mx/collections/Sort.as | 5 +++++
frameworks/projects/framework/src/mx/collections/SortField.as | 5 +++++
frameworks/projects/spark/src/spark/collections/Sort.as | 5 +++++
frameworks/projects/spark/src/spark/collections/SortField.as | 5 +++++
4 files changed, 20 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4ead7712/frameworks/projects/framework/src/mx/collections/Sort.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/Sort.as b/frameworks/projects/framework/src/mx/collections/Sort.as
index 7e2e82c..38acab8 100644
--- a/frameworks/projects/framework/src/mx/collections/Sort.as
+++ b/frameworks/projects/framework/src/mx/collections/Sort.as
@@ -95,6 +95,11 @@ package mx.collections
* sorting for strings. For this type of sorting please see the
* spark.collections.Sort
and
* spark.collections.SortField
classes.
+ *
+ * Note: to prevent problems like
+ * FLEX-34853
+ * it is recommended to use SortField
+ * instances as immutable objects (by not changing their state).
*
* @mxml
*
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4ead7712/frameworks/projects/framework/src/mx/collections/SortField.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/collections/SortField.as b/frameworks/projects/framework/src/mx/collections/SortField.as
index a465656..824d98d 100644
--- a/frameworks/projects/framework/src/mx/collections/SortField.as
+++ b/frameworks/projects/framework/src/mx/collections/SortField.as
@@ -72,6 +72,11 @@ package mx.collections
* spark.collections.Sort
and
* spark.collections.SortField
classes.
*
+ * Note: to prevent problems like
+ * FLEX-34853
+ * it is recommended to use SortField
+ * instances as immutable objects (by not changing their state).
+ *
* @mxml
*
* The <mx:SortField>
tag has the following attributes:
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4ead7712/frameworks/projects/spark/src/spark/collections/Sort.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/collections/Sort.as b/frameworks/projects/spark/src/spark/collections/Sort.as
index 0f31834..891da49 100644
--- a/frameworks/projects/spark/src/spark/collections/Sort.as
+++ b/frameworks/projects/spark/src/spark/collections/Sort.as
@@ -160,6 +160,11 @@ package spark.collections
* UIComponent's addStyleClient()
method.
*
*
+ *
+ * Note: to prevent problems like
+ * FLEX-34853
+ * it is recommended to use SortField
+ * instances as immutable objects (by not changing their state).
*
* @mxml
*
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4ead7712/frameworks/projects/spark/src/spark/collections/SortField.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/collections/SortField.as b/frameworks/projects/spark/src/spark/collections/SortField.as
index 760b725..5b730a2 100644
--- a/frameworks/projects/spark/src/spark/collections/SortField.as
+++ b/frameworks/projects/spark/src/spark/collections/SortField.as
@@ -129,6 +129,11 @@ package spark.collections
* UIComponent's addStyleClient()
method.
*
*
+ *
+ * Note: to prevent problems like
+ * FLEX-34853
+ * it is recommended to use SortField
+ * instances as immutable objects (by not changing their state).
*
* @mxml
*