flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cd...@apache.org
Subject git commit: [flex-falcon] [refs/heads/develop] - - Disabled assertions for integration-tests
Date Tue, 14 Jun 2016 08:47:29 GMT
Repository: flex-falcon
Updated Branches:
  refs/heads/develop 43a064f98 -> c48762004


- Disabled assertions for integration-tests


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/c4876200
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/c4876200
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/c4876200

Branch: refs/heads/develop
Commit: c48762004392bab438670526df4b13f1ded62e9c
Parents: 43a064f
Author: Christofer Dutz <christofer.dutz@codecentric.de>
Authored: Tue Jun 14 10:47:19 2016 +0200
Committer: Christofer Dutz <christofer.dutz@codecentric.de>
Committed: Tue Jun 14 10:47:19 2016 +0200

----------------------------------------------------------------------
 compiler/src/test/java/as/ASFeatureTestsBase.java | 8 +++++---
 pom.xml                                           | 8 ++++++++
 2 files changed, 13 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/c4876200/compiler/src/test/java/as/ASFeatureTestsBase.java
----------------------------------------------------------------------
diff --git a/compiler/src/test/java/as/ASFeatureTestsBase.java b/compiler/src/test/java/as/ASFeatureTestsBase.java
index 61ed64f..0ff167a 100644
--- a/compiler/src/test/java/as/ASFeatureTestsBase.java
+++ b/compiler/src/test/java/as/ASFeatureTestsBase.java
@@ -92,11 +92,13 @@ public class ASFeatureTestsBase
 			swcs.add(testAdapter.getFlexArtifact("spark").getPath());
 			swcs.add(testAdapter.getFlexArtifactResourceBundle("spark").getPath());
 		}
-		String libraryPath = "-library-path=" + StringUtils.join(swcs.toArray(new String[swcs.size()]),
",");
-		
+
 		List<String> args = new ArrayList<String>();
 		args.add("-external-library-path=" + testAdapter.getPlayerglobal().getPath());
-		args.add(libraryPath);
+		if(swcs.size() > 0) {
+			String libraryPath = "-library-path=" + StringUtils.join(swcs.toArray(new String[swcs.size()]),
",");
+			args.add(libraryPath);
+		}
 		args.add("-namespace=" + NAMESPACE_2009 + "," + testAdapter.getFlexManifestPath("mxml-2009"));
 		if (otherOptions != null)
 		{

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/c4876200/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index c52dae7..48317cc 100644
--- a/pom.xml
+++ b/pom.xml
@@ -349,6 +349,14 @@
                         <mavenLocalRepoDir>${settings.localRepository}</mavenLocalRepoDir>
                         <FLASHPLAYER_DEBUGGER>${env.FLASHPLAYER_DEBUGGER}</FLASHPLAYER_DEBUGGER>
                     </systemPropertyVariables>
+                    <!--
+                        Currently some tests need this to be disabled,
+                        but actually this is a bug. For now I'll disable
+                        them to avoid problems during the maven migration.
+                        After this is finished, we should defnitely fix
+                        the tests so assertions can be enabled.
+                    -->
+                    <enableAssertions>false</enableAssertions>
                 </configuration>
             </plugin>
 


Mime
View raw message