Return-Path: X-Original-To: apmail-flex-commits-archive@www.apache.org Delivered-To: apmail-flex-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0F0E318CC1 for ; Mon, 11 Jan 2016 18:04:45 +0000 (UTC) Received: (qmail 72017 invoked by uid 500); 11 Jan 2016 18:04:44 -0000 Delivered-To: apmail-flex-commits-archive@flex.apache.org Received: (qmail 71958 invoked by uid 500); 11 Jan 2016 18:04:44 -0000 Mailing-List: contact commits-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list commits@flex.apache.org Received: (qmail 71914 invoked by uid 99); 11 Jan 2016 18:04:44 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 18:04:44 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 70518E0AD2; Mon, 11 Jan 2016 18:04:44 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: aharui@apache.org To: commits@flex.apache.org Date: Mon, 11 Jan 2016 18:04:45 -0000 Message-Id: <2da369239ef94867b3f0404e722639ce@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [2/9] git commit: [flex-falcon] [refs/heads/develop] - suppress warnings when we don't emit a goog.requires for types only mentioned in JSDoc suppress warnings when we don't emit a goog.requires for types only mentioned in JSDoc Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/a61d9064 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/a61d9064 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/a61d9064 Branch: refs/heads/develop Commit: a61d9064561ad6299bc3a189b0180e1c545496fa Parents: 15b170f Author: Alex Harui Authored: Thu Jan 7 15:52:32 2016 -0800 Committer: Alex Harui Committed: Thu Jan 7 15:52:32 2016 -0800 ---------------------------------------------------------------------- .../google/javascript/jscomp/FlexJSDiagnosticGroups.java | 9 +++++++++ .../flex/compiler/utils/JSClosureCompilerWrapper.java | 1 + 2 files changed, 10 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/a61d9064/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java ---------------------------------------------------------------------- diff --git a/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java b/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java index e28cfe7..5b77b44 100644 --- a/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java +++ b/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java @@ -46,4 +46,13 @@ public class FlexJSDiagnosticGroups { DiagnosticGroups.registerGroup("flexjsReferenceBeforeDeclare", VariableReferenceCheck.UNDECLARED_REFERENCE); */ + + /** + * Flex code won't always generate a goog.requires for types only used + * in JSDoc annotations, but the compiler complains. + */ + public static final DiagnosticGroup FLEXJS_UNKNOWN_JSDOC_TYPE_NAME = + DiagnosticGroups.registerGroup("flexjsUnknownJSDocTypeName", + RhinoErrorReporter.TYPE_PARSE_ERROR); + } http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/a61d9064/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java ---------------------------------------------------------------------- diff --git a/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java b/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java index a9aa8bd..05e0328 100644 --- a/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java +++ b/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java @@ -277,6 +277,7 @@ public class JSClosureCompilerWrapper // still want warnings for others in the group. options_.setWarningLevel(FlexJSDiagnosticGroups.FLEXJS_NOT_A_CONSTRUCTOR, CheckLevel.OFF); options_.setWarningLevel(FlexJSDiagnosticGroups.FLEXJS_SUPER_CALL_TO_DIFFERENT_NAME, CheckLevel.OFF); + options_.setWarningLevel(FlexJSDiagnosticGroups.FLEXJS_UNKNOWN_JSDOC_TYPE_NAME, CheckLevel.OFF); // options_.setWarningLevel(FlexJSDiagnosticGroups.FLEXJS_REFERENCE_BEFORE_DECLARE, CheckLevel.OFF); }