flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aha...@apache.org
Subject [1/4] git commit: [flex-falcon] [refs/heads/develop] - suppress warning when we call super.getElementAt from . GCL currently thinks that is bad
Date Fri, 30 Oct 2015 06:53:04 GMT
Repository: flex-falcon
Updated Branches:
  refs/heads/develop 6c27fbe2b -> b288371af


suppress warning when we call super.getElementAt from .  GCL currently thinks that is bad


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/fdef1577
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/fdef1577
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/fdef1577

Branch: refs/heads/develop
Commit: fdef1577cf3b48312d0ea821864c0856dd637576
Parents: 6c27fbe
Author: Alex Harui <aharui@apache.org>
Authored: Thu Oct 29 23:24:14 2015 -0700
Committer: Alex Harui <aharui@apache.org>
Committed: Thu Oct 29 23:24:14 2015 -0700

----------------------------------------------------------------------
 .../com/google/javascript/jscomp/FlexJSDiagnosticGroups.java  | 7 +++++++
 .../apache/flex/compiler/utils/JSClosureCompilerWrapper.java  | 1 +
 2 files changed, 8 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/fdef1577/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java b/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java
index c08f865..e28cfe7 100644
--- a/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java
+++ b/compiler.jx/src/com/google/javascript/jscomp/FlexJSDiagnosticGroups.java
@@ -34,6 +34,13 @@ public class FlexJSDiagnosticGroups {
 		DiagnosticGroups.registerGroup("flexjsNotAConstructor",
                 TypeCheck.NOT_A_CONSTRUCTOR);
 
+	/**
+	 * Flex code calls super.methodName from functions other than
+	 * overrides of the methodName.
+	 */
+	public static final DiagnosticGroup FLEXJS_SUPER_CALL_TO_DIFFERENT_NAME =
+		DiagnosticGroups.registerGroup("flexjsSuperCallToDifferentName",
+                ProcessClosurePrimitives.BASE_CLASS_ERROR);
 	/*
 	public static final DiagnosticGroup FLEXJS_REFERENCE_BEFORE_DECLARE =
 		DiagnosticGroups.registerGroup("flexjsReferenceBeforeDeclare",

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/fdef1577/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java
b/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java
index 456c7f7..f2d0fae 100644
--- a/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java
+++ b/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java
@@ -279,6 +279,7 @@ public class JSClosureCompilerWrapper
             // create custom DiagnosticGroups to shut off some individual warnings when we
             // still want warnings for others in the group.
             options_.setWarningLevel(FlexJSDiagnosticGroups.FLEXJS_NOT_A_CONSTRUCTOR, CheckLevel.OFF);
+            options_.setWarningLevel(FlexJSDiagnosticGroups.FLEXJS_SUPER_CALL_TO_DIFFERENT_NAME,
CheckLevel.OFF);
 //            options_.setWarningLevel(FlexJSDiagnosticGroups.FLEXJS_REFERENCE_BEFORE_DECLARE,
CheckLevel.OFF);
         }
         


Mime
View raw message