flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aha...@apache.org
Subject [1/3] git commit: [flex-asjs] [refs/heads/develop] - quiet more warnings
Date Sat, 01 Aug 2015 07:11:04 GMT
Repository: flex-asjs
Updated Branches:
  refs/heads/develop 4f0890233 -> 8165b5c4d


quiet more warnings


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/c5fb1c50
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/c5fb1c50
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/c5fb1c50

Branch: refs/heads/develop
Commit: c5fb1c500c36d196d74c2f58d2a83b0ef8954122
Parents: 4b2f457
Author: Alex Harui <aharui@apache.org>
Authored: Fri Jul 31 16:49:50 2015 -0700
Committer: Alex Harui <aharui@apache.org>
Committed: Sat Aug 1 00:10:55 2015 -0700

----------------------------------------------------------------------
 .../Core/as/src/org/apache/flex/core/BeadViewBase.as    |  7 +++++++
 .../asjs/src/org/apache/flex/html/MXMLBeadViewBase.as   | 12 ------------
 .../projects/HTML/js/src/org/apache/flex/html/Panel.js  |  4 +---
 .../js/src/org/apache/flex/html/beads/ContainerView.js  |  9 ---------
 .../HTML/js/src/org/apache/flex/html/beads/PanelView.js |  5 ++++-
 5 files changed, 12 insertions(+), 25 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5fb1c50/frameworks/projects/Core/as/src/org/apache/flex/core/BeadViewBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/Core/as/src/org/apache/flex/core/BeadViewBase.as b/frameworks/projects/Core/as/src/org/apache/flex/core/BeadViewBase.as
index 6bb686a..c8cac48 100644
--- a/frameworks/projects/Core/as/src/org/apache/flex/core/BeadViewBase.as
+++ b/frameworks/projects/Core/as/src/org/apache/flex/core/BeadViewBase.as
@@ -48,6 +48,13 @@ package org.apache.flex.core
         /**
          *  The strand.  Do not modify except
          *  via the strand setter.  For reading only.
+         * 
+         *  Because Object.defineProperties in JS
+         *  doesn't allow you to just override the setter
+         *  (you have to override the getter as well even
+         *  if it just calls the super getter) it is
+         *  more efficient to expose this variable than
+         *  have all of the layers of simple overrides.
          *  
          *  @langversion 3.0
          *  @playerversion Flash 10.2

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5fb1c50/frameworks/projects/HTML/asjs/src/org/apache/flex/html/MXMLBeadViewBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/asjs/src/org/apache/flex/html/MXMLBeadViewBase.as b/frameworks/projects/HTML/asjs/src/org/apache/flex/html/MXMLBeadViewBase.as
index 0493f25..4d86573 100644
--- a/frameworks/projects/HTML/asjs/src/org/apache/flex/html/MXMLBeadViewBase.as
+++ b/frameworks/projects/HTML/asjs/src/org/apache/flex/html/MXMLBeadViewBase.as
@@ -59,8 +59,6 @@ package org.apache.flex.html
 			super();
 		}
 		
-		private var _strand:IStrand;
-		
         [Bindable("strandChanged")]
         /**
          *  An MXMLBeadViewBase doesn't create its children until it is added to
@@ -73,7 +71,6 @@ package org.apache.flex.html
          */
         override public function set strand(value:IStrand):void
         {
-			_strand = value;
             super.strand = value;
             // each MXML file can also have styles in fx:Style block
             ValuesManager.valuesImpl.init(this);
@@ -92,15 +89,6 @@ package org.apache.flex.html
             dispatchEvent(new Event("childrenAdded"));
         }
         
-        /**
-         *  @private
-         *  Needed for databinding expressions
-         */
-        public function get strand():IStrand
-        {
-            return _strand;
-        }
-        
         [Bindable("__NoChangeEvent__")]
         /**
          *  The model object.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5fb1c50/frameworks/projects/HTML/js/src/org/apache/flex/html/Panel.js
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/js/src/org/apache/flex/html/Panel.js b/frameworks/projects/HTML/js/src/org/apache/flex/html/Panel.js
index 15882c4..ba75810 100644
--- a/frameworks/projects/HTML/js/src/org/apache/flex/html/Panel.js
+++ b/frameworks/projects/HTML/js/src/org/apache/flex/html/Panel.js
@@ -15,8 +15,6 @@
 goog.provide('org.apache.flex.html.Panel');
 
 goog.require('org.apache.flex.html.Container');
-goog.require('org.apache.flex.html.ControlBar');
-goog.require('org.apache.flex.html.TitleBar');
 goog.require('org.apache.flex.html.beads.PanelView');
 goog.require('org.apache.flex.html.beads.models.PanelModel');
 
@@ -145,7 +143,7 @@ org.apache.flex.html.Panel.prototype.addedToParent =
  * @return {Array} the HTML DOM element children.
  */
 org.apache.flex.html.Panel.prototype.internalChildren =
-    function(c, index) {
+    function() {
   return this.contentArea.children;
 };
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5fb1c50/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/ContainerView.js
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/ContainerView.js b/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/ContainerView.js
index 06b4488..8f910d8 100644
--- a/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/ContainerView.js
+++ b/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/ContainerView.js
@@ -50,15 +50,6 @@ org.apache.flex.html.beads.ContainerView.prototype.FLEXJS_CLASS_INFO =
 
 
 /**
- * @type {Object}
- * This is also defined as protected on BeadViewBase, but GCC
- * doesn't seem to allow the Object.defineProperties to use it
- * without re-declaring it here.
- */
-org.apache.flex.html.beads.ContainerView.prototype._strand = null;
-
-
-/**
  * @private
  * @type {Object}
  */

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/c5fb1c50/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js
----------------------------------------------------------------------
diff --git a/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js b/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js
index 69db3e2..d0b27a2 100644
--- a/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js
+++ b/frameworks/projects/HTML/js/src/org/apache/flex/html/beads/PanelView.js
@@ -14,6 +14,8 @@
 
 goog.provide('org.apache.flex.html.beads.PanelView');
 
+goog.require('org.apache.flex.html.ControlBar');
+goog.require('org.apache.flex.html.TitleBar');
 goog.require('org.apache.flex.html.beads.ContainerView');
 goog.require('org.apache.flex.html.supportClasses.ContainerContentArea');
 
@@ -21,6 +23,7 @@ goog.require('org.apache.flex.html.supportClasses.ContainerContentArea');
 
 /**
  * @constructor
+ * @extends {org.apache.flex.html.beads.ContainerView}
  */
 org.apache.flex.html.beads.PanelView = function() {
   org.apache.flex.html.beads.PanelView.base(this, 'constructor');
@@ -101,7 +104,7 @@ Object.defineProperties(org.apache.flex.html.beads.PanelView.prototype,
{
 
 /**
  * @override
- * @param {Object} event The event that triggered this handler.
+ * @param {org.apache.flex.events.Event} event The event that triggered this handler.
  */
 org.apache.flex.html.beads.PanelView.prototype.changeHandler =
     function(event) {


Mime
View raw message