flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mih...@apache.org
Subject [1/3] git commit: [flex-sdk] [refs/heads/develop] - FLEX-34837 Minor changes: asdocs, making some private functions static where applicable, removing unused namespaces.
Date Sat, 25 Jul 2015 13:50:09 GMT
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 0cb12ee3f -> 07e7bcf74


FLEX-34837
Minor changes: asdocs, making some private functions static where applicable, removing unused
namespaces.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/462a85b9
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/462a85b9
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/462a85b9

Branch: refs/heads/develop
Commit: 462a85b9bc675ebf88175c63c948bf9e752f36e8
Parents: 0cb12ee
Author: Mihai Chira <mihaic@apache.org>
Authored: Sat Jul 25 15:32:22 2015 +0200
Committer: Mihai Chira <mihaic@apache.org>
Committed: Sat Jul 25 15:34:25 2015 +0200

----------------------------------------------------------------------
 .../gridClasses/DefaultGridItemEditor.mxml      |  5 +--
 .../components/gridClasses/GridItemEditor.as    | 43 +++++++++-----------
 2 files changed, 21 insertions(+), 27 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/462a85b9/frameworks/projects/spark/src/spark/components/gridClasses/DefaultGridItemEditor.mxml
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/DefaultGridItemEditor.mxml
b/frameworks/projects/spark/src/spark/components/gridClasses/DefaultGridItemEditor.mxml
index 5b7dea0..d8cfd33 100644
--- a/frameworks/projects/spark/src/spark/components/gridClasses/DefaultGridItemEditor.mxml
+++ b/frameworks/projects/spark/src/spark/components/gridClasses/DefaultGridItemEditor.mxml
@@ -42,8 +42,7 @@
 -->
 <s:GridItemEditor xmlns:fx="http://ns.adobe.com/mxml/2009" 
                                   xmlns:s="library://ns.adobe.com/flex/spark" 
-                                  xmlns:mx="library://ns.adobe.com/flex/mx" 
-                                  xmlns:gridEditorClasses="spark.components.gridEditorClasses.*">
+                                  xmlns:mx="library://ns.adobe.com/flex/mx">
     
     <fx:Script>
         <![CDATA[
@@ -65,7 +64,7 @@
              */ 
             override public function get value():Object
             {
-                return textArea.text;            
+                return textArea.text;
             }
             
             /**

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/462a85b9/frameworks/projects/spark/src/spark/components/gridClasses/GridItemEditor.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/spark/src/spark/components/gridClasses/GridItemEditor.as
b/frameworks/projects/spark/src/spark/components/gridClasses/GridItemEditor.as
index bc851ea..32bd73f 100644
--- a/frameworks/projects/spark/src/spark/components/gridClasses/GridItemEditor.as
+++ b/frameworks/projects/spark/src/spark/components/gridClasses/GridItemEditor.as
@@ -19,26 +19,21 @@
 
 package spark.components.gridClasses
 {
-import flash.events.Event;
-import flash.events.MouseEvent;
-import flash.geom.Point;
-import flash.utils.describeType;
+    import flash.events.Event;
+    import flash.events.MouseEvent;
+    import flash.geom.Point;
+    import flash.utils.describeType;
 
-import mx.collections.ICollectionView;
-import mx.collections.ISort;
-import mx.core.IIMESupport;
-import mx.core.IInvalidating;
-import mx.core.IVisualElement;
-import mx.core.IVisualElementContainer;
-import mx.core.mx_internal;
-import mx.validators.IValidatorListener;
+    import mx.core.IIMESupport;
+    import mx.core.IInvalidating;
+    import mx.core.IVisualElement;
+    import mx.core.IVisualElementContainer;
+    import mx.validators.IValidatorListener;
+    import mx.core.mx_internal;
+    import spark.components.DataGrid;
+    import spark.components.Group;
 
-import spark.components.DataGrid;
-import spark.components.Group;
-import spark.components.gridClasses.GridColumn;
-
-
-use namespace mx_internal;
+    use namespace mx_internal;
 
 /**
  *  The GridItemEditor class defines the base class for custom item editors
@@ -149,7 +144,7 @@ public class GridItemEditor extends Group implements IGridItemEditor
      */
     public function get columnIndex():int
     {
-        return column.columnIndex;;
+        return column.columnIndex;
     }
 
     //----------------------------------
@@ -562,7 +557,7 @@ public class GridItemEditor extends Group implements IGridItemEditor
      *  @param container container to verify, may not be null.
      *  @return true if the container and its children are valid, false otherwise. 
      */
-    private function validateContainer(container:IVisualElementContainer):Boolean
+    private static function validateContainer(container:IVisualElementContainer):Boolean
     {
         if (container is IValidatorListener && IValidatorListener(container).errorString)
             return false;
@@ -596,14 +591,14 @@ public class GridItemEditor extends Group implements IGridItemEditor
      * 
      *  @param container container to verify, may not be null.
      */
-    private function clearErrorStringFromContainer(container:IVisualElementContainer):void
+    private static function clearErrorStringFromContainer(container:IVisualElementContainer):void
     {
         if (container is IValidatorListener && IValidatorListener(container).errorString)
         {
             clearErrorString(IValidatorListener(container));
         }
         
-        // loop thru the children, looking for errors to clear.
+        // loop through the children, looking for errors to clear.
         var n:int = container.numElements;
         for (var i:int = 0; i < n; i++)
         {
@@ -635,7 +630,7 @@ public class GridItemEditor extends Group implements IGridItemEditor
      * 
      *  @param validatorListener listener to clear error message in.
      */
-    private function clearErrorString(validatorListener:IValidatorListener):void
+    private static function clearErrorString(validatorListener:IValidatorListener):void
     {
         validatorListener.errorString = "";
         if (validatorListener is IInvalidating)
@@ -648,7 +643,7 @@ public class GridItemEditor extends Group implements IGridItemEditor
      *   @private
      *   Stop the item renderer from getting the click.
      */ 
-    private function mouseUpDownMoveHandler(event:MouseEvent):void
+    private static function mouseUpDownMoveHandler(event:MouseEvent):void
     {
         if (event.cancelable)
             event.preventDefault();


Mime
View raw message