flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mih...@apache.org
Subject git commit: [flex-sdk] [refs/heads/develop] - FLEX-34852, FLEX-34853 The one failing unit test was because of another bug, FLEX-34853. This will be fixed only in two or three future releases, so the unit test caters for it. Please remove the commented li
Date Tue, 09 Jun 2015 07:31:59 GMT
Repository: flex-sdk
Updated Branches:
  refs/heads/develop 4ed0ee64c -> 97e625a80


FLEX-34852, FLEX-34853
The one failing unit test was because of another bug, FLEX-34853. This will be fixed only
in two or three future releases, so the unit test caters for it. Please remove the commented
line once FLEX-34853 is fixed.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/97e625a8
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/97e625a8
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/97e625a8

Branch: refs/heads/develop
Commit: 97e625a801eb63931229d88c4f73403e3ae596f4
Parents: 4ed0ee6
Author: Mihai Chira <mihaic@apache.org>
Authored: Tue Jun 9 09:27:38 2015 +0200
Committer: Mihai Chira <mihaic@apache.org>
Committed: Tue Jun 9 09:27:38 2015 +0200

----------------------------------------------------------------------
 .../projects/framework/tests/ListCollectionView_Sort_Tests.as    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/97e625a8/frameworks/projects/framework/tests/ListCollectionView_Sort_Tests.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/tests/ListCollectionView_Sort_Tests.as b/frameworks/projects/framework/tests/ListCollectionView_Sort_Tests.as
index 0a4b6f6..7024626 100644
--- a/frameworks/projects/framework/tests/ListCollectionView_Sort_Tests.as
+++ b/frameworks/projects/framework/tests/ListCollectionView_Sort_Tests.as
@@ -345,7 +345,8 @@ package {
             _sut.addAll(from4To0); //values["name"]: Object4, Object3, Object2, Object1,
Object0
 
             const sortByIndexAscending:Sort = new Sort();
-            sortByIndexAscending.fields = [new SortField("index", false, false, true)];
+            var originalSortField:SortField = new SortField("index", false, false, true);
+            sortByIndexAscending.fields = [originalSortField];
             _sut.sort = sortByIndexAscending;
             _sut.refresh(); //should be: Object0, Object1, Object2, Object3, Object4
 
@@ -354,6 +355,7 @@ package {
 
             //then
             assertIndexesAre([0, 1, 2, 3, 4]);
+            sortByIndexAscending.fields = [originalSortField]; //TODO remove once FLEX-34853
is fixed
             assertGetItemIndex(from4To0);
             assertRemoveAll();
         }


Mime
View raw message