flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erikdebr...@apache.org
Subject [11/11] git commit: [flex-falcon] [refs/heads/develop] - Add null check
Date Tue, 16 Sep 2014 14:02:03 GMT
Add null check

Prevents exception from being thrown when running full SDK through FalconJX. Check with compiler/SDK
guru's about root cause for exception.

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/35e648c8
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/35e648c8
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/35e648c8

Branch: refs/heads/develop
Commit: 35e648c825daa2b49289f1b872b7ff8d9cdfab7e
Parents: 7e83145
Author: Erik de Bruin <erik@ixsoftware.nl>
Authored: Tue Sep 16 14:50:40 2014 +0200
Committer: Erik de Bruin <erik@ixsoftware.nl>
Committed: Tue Sep 16 14:50:40 2014 +0200

----------------------------------------------------------------------
 .../internal/codegen/js/flexjs/JSFlexJSDocEmitter.java       | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/35e648c8/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
index 235deb1..8571846 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
@@ -106,7 +106,13 @@ public class JSFlexJSDocEmitter extends JSGoogDocEmitter
                 }
 
                 IExpressionNode enode = pnode.getNameExpressionNode();
-                emitParam(pnode, enode.resolveType(project).getPackageName());
+
+                // ToDo (erikdebruin): add VF2JS conditional -> only use check during
full SDK compilation
+                ITypeDefinition tdef = enode.resolveType(project);
+                if (tdef == null)
+                    continue;
+                
+                emitParam(pnode, tdef.getPackageName());
             }
 
             if (!node.isConstructor())


Mime
View raw message