Return-Path: X-Original-To: apmail-flex-commits-archive@www.apache.org Delivered-To: apmail-flex-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CD9A510766 for ; Wed, 25 Jun 2014 15:38:43 +0000 (UTC) Received: (qmail 3798 invoked by uid 500); 25 Jun 2014 15:38:43 -0000 Delivered-To: apmail-flex-commits-archive@flex.apache.org Received: (qmail 3753 invoked by uid 500); 25 Jun 2014 15:38:43 -0000 Mailing-List: contact commits-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list commits@flex.apache.org Received: (qmail 3745 invoked by uid 99); 25 Jun 2014 15:38:43 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jun 2014 15:38:43 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 5B0B993AB6A; Wed, 25 Jun 2014 15:38:43 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: erikdebruin@apache.org To: commits@flex.apache.org Date: Wed, 25 Jun 2014 15:38:43 -0000 Message-Id: <7e353b7b117546008780ec1e8b83a01a@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/3] git commit: [flex-falcon] [refs/heads/develop] - Enable more warnings, to give us clues where the framework and project code might be improved. Repository: flex-falcon Updated Branches: refs/heads/develop fc8df1ba4 -> 3438a56ec Enable more warnings, to give us clues where the framework and project code might be improved. Signed-off-by: Erik de Bruin Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/013211f8 Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/013211f8 Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/013211f8 Branch: refs/heads/develop Commit: 013211f891e039861a833e3a294ff07b776e06fe Parents: fc8df1b Author: Erik de Bruin Authored: Wed Jun 25 17:30:08 2014 +0200 Committer: Erik de Bruin Committed: Wed Jun 25 17:30:08 2014 +0200 ---------------------------------------------------------------------- .../flex/compiler/utils/JSClosureCompilerWrapper.java | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/013211f8/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java ---------------------------------------------------------------------- diff --git a/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java b/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java index a940aa6..ade255f 100644 --- a/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java +++ b/compiler.jx/src/org/apache/flex/compiler/utils/JSClosureCompilerWrapper.java @@ -183,9 +183,8 @@ public class JSClosureCompilerWrapper options_.setWarningLevel(DiagnosticGroups.CONSTANT_PROPERTY, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.STRICT_MODULE_DEP_CHECK, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.VISIBILITY, CheckLevel.WARNING); - options_.setWarningLevel(DiagnosticGroups.DEPRECATED, CheckLevel.OFF); + options_.setWarningLevel(DiagnosticGroups.DEPRECATED, CheckLevel.OFF); // OFF - /* // the 'full' set of warnings options_.setWarningLevel(DiagnosticGroups.AMBIGUOUS_FUNCTION_DECL, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.CHECK_EVENTFUL_OBJECT_DISPOSAL, CheckLevel.WARNING); @@ -205,25 +204,24 @@ public class JSClosureCompilerWrapper options_.setWarningLevel(DiagnosticGroups.FILEOVERVIEW_JSDOC, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.INTERNET_EXPLORER_CHECKS, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.INVALID_CASTS, CheckLevel.WARNING); - options_.setWarningLevel(DiagnosticGroups.LINT_CHECKS, CheckLevel.WARNING); + options_.setWarningLevel(DiagnosticGroups.LINT_CHECKS, CheckLevel.OFF); // OFF options_.setWarningLevel(DiagnosticGroups.MISPLACED_TYPE_ANNOTATION, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.MISSING_PROPERTIES, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.MISSING_PROVIDE, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.MISSING_REQUIRE, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.MISSING_RETURN, CheckLevel.WARNING); - options_.setWarningLevel(DiagnosticGroups.NEW_CHECK_TYPES, CheckLevel.OFF); + options_.setWarningLevel(DiagnosticGroups.NEW_CHECK_TYPES, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.NON_STANDARD_JSDOC, CheckLevel.WARNING); - options_.setWarningLevel(DiagnosticGroups.REPORT_UNKNOWN_TYPES, CheckLevel.OFF); + options_.setWarningLevel(DiagnosticGroups.REPORT_UNKNOWN_TYPES, CheckLevel.OFF); // OFF options_.setWarningLevel(DiagnosticGroups.SUSPICIOUS_CODE, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.TWEAKS, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.TYPE_INVALIDATION, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.UNDEFINED_NAMES, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.UNDEFINED_VARIABLES, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.UNKNOWN_DEFINES, CheckLevel.WARNING); - options_.setWarningLevel(DiagnosticGroups.UNNECESSARY_CASTS, CheckLevel.OFF); - options_.setWarningLevel(DiagnosticGroups.USE_OF_GOOG_BASE, CheckLevel.OFF); + options_.setWarningLevel(DiagnosticGroups.UNNECESSARY_CASTS, CheckLevel.OFF); // OFF + options_.setWarningLevel(DiagnosticGroups.USE_OF_GOOG_BASE, CheckLevel.WARNING); options_.setWarningLevel(DiagnosticGroups.VIOLATED_MODULE_DEP, CheckLevel.WARNING); - //*/ } options_.sourceMapFormat = SourceMap.Format.V3;