flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alex Harui <aha...@adobe.com>
Subject Re: git commit: [flex-sdk] [refs/heads/develop] - FLEX-34078 fix callouts closing when selecting dates in DateFields
Date Tue, 10 Jun 2014 17:05:04 GMT
-1 for reasons stated below.

Justin, you never responded so I'm thinking my attempts to ask you about
this have been missed in all the other noise.

-Alex

On 5/26/14 10:12 PM, "Alex Harui" <aharui@adobe.com> wrote:

>This change broke Falcon, although Falcon is not reporting the failure
>correctly.   And I'm sort of surprised it didn't break the SDK build
>because it introduces a dependency from spark.swc to mx.swc and mx.swc is
>not listed in the set of libraries used to build experimental.swc.
>
>It is also not a good idea to start dragging mx stuff into spark-only
>apps.  Might affect mobile app sizes and might affect those with
>spark-only build setups.
>
>I'm not familiar with Callout, but in other components with drop downs,
>the drop down's owner property is set to the base component, then you
>check to see if the component "owns" the clicked item.  Can similar logic
>be used here and eliminate the mx.swc dependency?
>
>Thanks,
>-Alex
>
>On 5/18/14 12:30 PM, "jmclean@apache.org" <jmclean@apache.org> wrote:
>
>>Repository: flex-sdk
>>Updated Branches:
>>  refs/heads/develop 3a087a60e -> 080f5e64d
>>
>>
>>FLEX-34078 fix callouts closing when selecting dates in DateFields
>>
>>
>>Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
>>Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/080f5e64
>>Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/080f5e64
>>Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/080f5e64
>>
>>Branch: refs/heads/develop
>>Commit: 080f5e64d5718d76c51ecf6b07552b8bfc1b112e
>>Parents: 3a087a6
>>Author: Justin Mclean <jmclean@apache.org>
>>Authored: Sun May 18 12:30:41 2014 -0700
>>Committer: Justin Mclean <jmclean@apache.org>
>>Committed: Sun May 18 12:30:41 2014 -0700
>>
>>----------------------------------------------------------------------
>> .../src/spark/components/supportClasses/DropDownController.as     | 3
>>+++
>> 1 file changed, 3 insertions(+)
>>----------------------------------------------------------------------
>>
>>
>>http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/080f5e64/frameworks/
>>p
>>rojects/spark/src/spark/components/supportClasses/DropDownController.as
>>----------------------------------------------------------------------
>>diff --git 
>>a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
>>o
>>ntroller.as 
>>b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
>>o
>>ntroller.as
>>index e1ff2fd..3641111 100644
>>--- 
>>a/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
>>o
>>ntroller.as
>>+++ 
>>b/frameworks/projects/spark/src/spark/components/supportClasses/DropDownC
>>o
>>ntroller.as
>>@@ -38,6 +38,7 @@ import mx.managers.ISystemManager;
>> 
>> import spark.components.DropDownList;
>> import spark.events.DropDownEvent;
>>+import mx.controls.CalendarLayout;
>> 
>> use namespace mx_internal;
>> 
>>@@ -613,6 +614,8 @@ public class DropDownController extends
>>EventDispatcher
>>                 var document:Object = (target as IUIComponent).document;
>>                 if (("hostComponent" in document) &&
>>document.hostComponent is DropDownList)
>> 			        return;
>>+				 if (target.parent is CalendarLayout)
>>+			        return;
>>             }
>> 
>>             if (hitAreaAdditions != null)
>>
>


Mime
View raw message