flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bigosma...@apache.org
Subject [3/3] git commit: [flex-sdk] [refs/heads/new_android_skins] - Remove unused variables and clean up comments
Date Tue, 15 Apr 2014 01:16:17 GMT
Remove unused variables and clean up comments


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/323b044e
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/323b044e
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/323b044e

Branch: refs/heads/new_android_skins
Commit: 323b044e1dd07c154372ff3c468f7c6f1555c803
Parents: fb29d57
Author: Om <bigosmallm@gmail.com>
Authored: Mon Apr 14 18:07:08 2014 -0700
Committer: Om <bigosmallm@gmail.com>
Committed: Mon Apr 14 18:07:08 2014 -0700

----------------------------------------------------------------------
 .../src/spark/skins/android4/HSliderSkin.as     |  2 +-
 .../spark/skins/android4/HSliderThumbSkin.as    | 69 +-------------------
 2 files changed, 2 insertions(+), 69 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/323b044e/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderSkin.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderSkin.as b/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderSkin.as
index c07aef6..7dd8c74 100644
--- a/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderSkin.as
+++ b/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderSkin.as
@@ -30,7 +30,7 @@ import spark.skins.mobile.supportClasses.HSliderDataTip;
 import spark.skins.mobile.supportClasses.MobileSkin;
 
 /**
- *  ActionScript-based skin for HSlider controls in mobile applications.
+ *  Android 4.x specific ActionScript-based skin for HSlider controls in mobile applications.
  * 
  *  <p>The base Flex implementation creates an HSlider with fixed height
  *  and variable width with a fixed-size thumb. As the height of the

http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/323b044e/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderThumbSkin.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderThumbSkin.as
b/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderThumbSkin.as
index ae5309b..517ff93 100644
--- a/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderThumbSkin.as
+++ b/frameworks/projects/mobiletheme/src/spark/skins/android4/HSliderThumbSkin.as
@@ -28,7 +28,7 @@ import spark.skins.android4.assets.HSliderThumb_normal;
 import spark.skins.mobile.supportClasses.MobileSkin;
 
 /**
- *  ActionScript-based skin for the HSlider thumb skin part in mobile applications.
+ *  Android 4.x specific ActionScript-based skin for the HSlider thumb skin part in mobile
applications.
  *
  *  <p>Note that this particular implementation defines a hit zone which is larger
than
  *  the visible thumb for better usability on mobile screens.</p>
@@ -73,11 +73,6 @@ public class HSliderThumbSkin extends MobileSkin
 				hitZoneOffset = 20;
 				hitZoneSideLength = 160;
 				
-				// chromeColor ellipse goes up to the thumb border
-				chromeColorEllipseWidth = chromeColorEllipseHeight = 112;
-				chromeColorEllipseX = 1;
-				chromeColorEllipseY = 1;
-				
 				break;              
 			}
 			case DPIClassification.DPI_480:
@@ -89,10 +84,6 @@ public class HSliderThumbSkin extends MobileSkin
 				hitZoneOffset = 20;
 				hitZoneSideLength = 130;
 				
-				// chromeColor ellipse goes up to the thumb border
-				chromeColorEllipseWidth = chromeColorEllipseHeight = 84; 
-				chromeColorEllipseX = chromeColorEllipseY = 1;
-				
 				break;
 			}
             case DPIClassification.DPI_320:
@@ -103,11 +94,6 @@ public class HSliderThumbSkin extends MobileSkin
                 hitZoneOffset = 10;
                 hitZoneSideLength = 80;
                 
-                // chromeColor ellipse goes up to the thumb border
-                chromeColorEllipseWidth = chromeColorEllipseHeight = 56;
-                chromeColorEllipseX = 1;
-                chromeColorEllipseY = 1;
-                
                 break;              
             }
 			case DPIClassification.DPI_240:
@@ -118,10 +104,6 @@ public class HSliderThumbSkin extends MobileSkin
 				hitZoneOffset = 10;
 				hitZoneSideLength = 65;
 				
-				// chromeColor ellipse goes up to the thumb border
-				chromeColorEllipseWidth = chromeColorEllipseHeight = 42; 
-				chromeColorEllipseX = chromeColorEllipseY = 1;
-				
 				break;
 			}
 			case DPIClassification.DPI_120:
@@ -132,10 +114,6 @@ public class HSliderThumbSkin extends MobileSkin
 				hitZoneOffset = 5;
 				hitZoneSideLength = 33;
 				
-				// chromeColor ellipse goes up to the thumb border
-				chromeColorEllipseWidth = chromeColorEllipseHeight = 21; 
-				chromeColorEllipseX = chromeColorEllipseY = 1;
-				
 				break;
 			}
             default:
@@ -147,10 +125,6 @@ public class HSliderThumbSkin extends MobileSkin
                 hitZoneOffset = 5;
                 hitZoneSideLength = 40;
                 
-                // chromeColor ellipse goes up to the thumb border
-                chromeColorEllipseWidth = chromeColorEllipseHeight = 29;
-                chromeColorEllipseX = chromeColorEllipseY = 0;
-                
                 break;
             }
                 
@@ -246,47 +220,6 @@ public class HSliderThumbSkin extends MobileSkin
     protected var thumbImageHeight:int;
     
     /**
-     *  Width of the chromeColor ellipse
-     *
-     *  @langversion 3.0
-     *  @playerversion Flash 10
-     *  @playerversion AIR 2.5
-     *  @productversion Flex 4.5
-     */    
-    protected var chromeColorEllipseWidth:int;
-    
-    /**
-     *  Height of the chromeColor ellipse
-     *
-     *  @langversion 3.0
-     *  @playerversion Flash 10
-     *  @playerversion AIR 2.5
-     *  @productversion Flex 4.5
-     */    
-    protected var chromeColorEllipseHeight:int;
-    
-    
-    /**
-     *  X position of the chromeColor ellipse
-     *
-     *  @langversion 3.0
-     *  @playerversion Flash 10
-     *  @playerversion AIR 2.5
-     *  @productversion Flex 4.5
-     */    
-    protected var chromeColorEllipseX:int;
-    
-    /**
-     *  Y position of the chromeColor ellipse
-     *
-     *  @langversion 3.0
-     *  @playerversion Flash 10
-     *  @playerversion AIR 2.5
-     *  @productversion Flex 4.5
-     */    
-    protected var chromeColorEllipseY:int;
-    
-    /**
      *  Length of the sizes of the hitzone (assumed to be square)
      *
      *  @langversion 3.0


Mime
View raw message