flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aha...@apache.org
Subject [4/9] git commit: [flex-asjs] [refs/heads/develop] - lots of mostly JSDoc changes in order to jshint and compile cleanly. createjs and jquery folders still generate warnings and the compiler still spits a warning for Timer.
Date Tue, 28 Jan 2014 23:16:19 GMT
lots of mostly JSDoc changes in order to jshint and compile cleanly.  createjs and jquery folders still generate warnings and the compiler still spits a warning for Timer.


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/375b544e
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/375b544e
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/375b544e

Branch: refs/heads/develop
Commit: 375b544e00d9e34eaf4ff6d68a5774cd61b533b4
Parents: a6398f9
Author: Alex Harui <aharui@apache.org>
Authored: Tue Jan 28 12:24:26 2014 -0800
Committer: Alex Harui <aharui@apache.org>
Committed: Tue Jan 28 14:54:04 2014 -0800

----------------------------------------------------------------------
 .../js/FlexJS/src/mx/core/ClassFactory.js       |  6 ++-
 .../src/org/apache/flex/binding/BindingBase.js  |  2 +-
 .../org/apache/flex/binding/GenericBinding.js   |  3 +-
 .../org/apache/flex/binding/PropertyWatcher.js  |  8 +--
 .../src/org/apache/flex/binding/WatcherBase.js  | 14 ++---
 .../src/org/apache/flex/core/Application.js     |  2 +-
 .../core/IDataProviderItemRendererMapper.js     |  5 +-
 .../flex/core/ItemRendererClassFactory.js       | 12 +++--
 .../org/apache/flex/core/SimpleCSSValuesImpl.js | 54 ++++++++++++--------
 .../org/apache/flex/core/SimpleStatesImpl.js    | 15 ++++--
 .../FlexJS/src/org/apache/flex/core/UIBase.js   | 32 +++++++-----
 .../src/org/apache/flex/core/ValuesManager.js   | 10 ++--
 .../FlexJS/src/org/apache/flex/core/ViewBase.js |  7 ++-
 .../org/apache/flex/core/ViewBaseDataBinding.js | 14 ++---
 .../apache/flex/html/staticControls/Alert.js    | 10 ++--
 .../apache/flex/html/staticControls/ComboBox.js | 18 ++++---
 .../flex/html/staticControls/ControlBar.js      |  4 +-
 .../org/apache/flex/html/staticControls/List.js | 14 +++--
 .../flex/html/staticControls/NumericStepper.js  |  2 +
 .../apache/flex/html/staticControls/Panel.js    |  4 +-
 .../apache/flex/html/staticControls/Slider.js   | 16 +++---
 .../apache/flex/html/staticControls/Spinner.js  |  2 +
 .../apache/flex/html/staticControls/TitleBar.js |  2 +
 .../accessories/NumericOnlyTextInputBead.js     |  4 +-
 .../accessories/PasswordInputBead.js            |  4 +-
 .../accessories/TextPromptBead.js               |  4 +-
 .../DataItemRendererFactoryForArrayData.js      |  8 ++-
 .../flex/html/staticControls/beads/ListView.js  |  3 +-
 .../TextItemRendererFactoryForArrayData.js      |  2 +-
 .../beads/controllers/SliderMouseController.js  |  2 +-
 .../beads/controllers/SpinnerMouseController.js |  2 +-
 .../staticControls/beads/models/PanelModel.js   | 26 +++++++---
 .../staticControls/beads/models/RangeModel.js   | 24 ++++-----
 .../beads/models/TitleBarModel.js               | 26 +++++++---
 .../ButtonBarButtonItemRenderer.js              |  4 +-
 .../supportClasses/DataGridColumn.js            |  2 +-
 .../supportClasses/NonVirtualDataGroup.js       |  2 +-
 .../flex/html5/staticControls/CheckBox.js       |  6 ++-
 .../flex/html5/staticControls/ComboBox.js       | 20 +++++---
 .../apache/flex/html5/staticControls/Label.js   |  2 +
 .../apache/flex/html5/staticControls/List.js    |  4 +-
 .../flex/html5/staticControls/RadioButton.js    |  6 ++-
 .../flex/html5/staticControls/TextArea.js       |  2 +
 .../flex/html5/staticControls/TextButton.js     |  2 +
 .../flex/html5/staticControls/TextInput.js      |  2 +
 .../flex/jquery/staticControls/RadioButton.js   |  2 +-
 .../src/org/apache/flex/net/BinaryUploader.js   | 16 +++---
 .../src/org/apache/flex/net/HTTPHeader.js       |  8 +--
 .../src/org/apache/flex/net/HTTPService.js      | 34 ++++++------
 .../src/org/apache/flex/utils/Language.js       |  2 +-
 .../FlexJS/src/org/apache/flex/utils/Timer.js   | 10 ++--
 51 files changed, 300 insertions(+), 185 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/mx/core/ClassFactory.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/mx/core/ClassFactory.js b/frameworks/js/FlexJS/src/mx/core/ClassFactory.js
index 0e0f68f..25755bd 100644
--- a/frameworks/js/FlexJS/src/mx/core/ClassFactory.js
+++ b/frameworks/js/FlexJS/src/mx/core/ClassFactory.js
@@ -21,9 +21,13 @@ goog.require('mx.core.IFactory');
 /**
  * @constructor
  * @implements {mx.core.IFactory}
- * @param {Object} generator The class definition to use for newInstance.
+ * @param {Function} generator The class definition to use for newInstance.
  */
 mx.core.ClassFactory = function(generator) {
+  /**
+   * @private
+   * @type {Function}
+   */
   this.generator_ = generator;
   this.properties_ = null;
 };

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/binding/BindingBase.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/binding/BindingBase.js b/frameworks/js/FlexJS/src/org/apache/flex/binding/BindingBase.js
index b655c55..6e5a5cb 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/binding/BindingBase.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/binding/BindingBase.js
@@ -72,7 +72,7 @@ org.apache.flex.binding.BindingBase.prototype.sourcePropertyName = '';
  * @expose
  * @type {string}
  */
-org.apache.flex.binding.BindingBase.prototype.sourceID;
+org.apache.flex.binding.BindingBase.prototype.sourceID = '';
 
 
 /**

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/binding/GenericBinding.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/binding/GenericBinding.js b/frameworks/js/FlexJS/src/org/apache/flex/binding/GenericBinding.js
index 3db4add..ad470cd 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/binding/GenericBinding.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/binding/GenericBinding.js
@@ -72,12 +72,13 @@ org.apache.flex.binding.GenericBinding.prototype.set_strand =
  */
 org.apache.flex.binding.GenericBinding.prototype.getValueFromSource =
     function() {
+  var obj;
   if (typeof(this.source) == 'object' &&
       typeof(this.source.slice) == 'function')
   {
     var arr = this.source;
     var n = arr.length;
-    var obj = this.document['get_' + arr[0]]();
+    obj = this.document['get_' + arr[0]]();
     if (obj == null)
       return null;
     for (var i = 1; i < n; i++)

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/binding/PropertyWatcher.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/binding/PropertyWatcher.js b/frameworks/js/FlexJS/src/org/apache/flex/binding/PropertyWatcher.js
index 31491c4..49350ce 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/binding/PropertyWatcher.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/binding/PropertyWatcher.js
@@ -52,19 +52,19 @@ org.apache.flex.binding.PropertyWatcher.prototype.FLEXJS_CLASS_INFO =
 /**
  * @type {Object}
  */
-org.apache.flex.binding.PropertyWatcher.prototype.source;
+org.apache.flex.binding.PropertyWatcher.prototype.source = null;
 
 
 /**
- * @type {string}
+ * @type {?string}
  */
-org.apache.flex.binding.PropertyWatcher.prototype.propertyName;
+org.apache.flex.binding.PropertyWatcher.prototype.propertyName = null;
 
 
 /**
  * @type {Object}
  */
-org.apache.flex.binding.PropertyWatcher.prototype.eventNames;
+org.apache.flex.binding.PropertyWatcher.prototype.eventNames = null;
 
 
 /**

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/binding/WatcherBase.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/binding/WatcherBase.js b/frameworks/js/FlexJS/src/org/apache/flex/binding/WatcherBase.js
index a19b766..8d3ce4e 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/binding/WatcherBase.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/binding/WatcherBase.js
@@ -25,14 +25,15 @@ org.apache.flex.binding.WatcherBase = function() {
      * @protected
      * @type {Object}
      */
-  this.listeners;
+  this.listeners = null;
 
   /**
      * @protected
      * @type {Object}
      * Children of this watcher are watching sub values.
      */
-  this.children;
+  this.children = null;
+
 };
 
 
@@ -48,9 +49,10 @@ org.apache.flex.binding.WatcherBase.prototype.FLEXJS_CLASS_INFO =
 
 /**
  *  @expose
+ *  @type {Object|number|string|boolean}
  *  The value itself.
  */
-org.apache.flex.binding.WatcherBase.prototype.value;
+org.apache.flex.binding.WatcherBase.prototype.value = null;
 
 
 /**
@@ -139,7 +141,7 @@ org.apache.flex.binding.WatcherBase.prototype.valueChanged =
 
   if (valType == 'string')
   {
-    if (oldValue == null && this.value == '')
+    if (oldValue == null && this.value === '')
       return false;
     else
       return oldValue != this.value;
@@ -147,7 +149,7 @@ org.apache.flex.binding.WatcherBase.prototype.valueChanged =
 
   if (valType == 'number')
   {
-    if (oldValue == null && this.value == 0)
+    if (oldValue == null && this.value === 0)
       return false;
     else
       return oldValue != this.value;
@@ -155,7 +157,7 @@ org.apache.flex.binding.WatcherBase.prototype.valueChanged =
 
   if (valType == 'boolean')
   {
-    if (oldValue == null && this.value == false)
+    if (oldValue == null && this.value === false)
       return false;
     else
       return oldValue != this.value;

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/Application.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/Application.js b/frameworks/js/FlexJS/src/org/apache/flex/core/Application.js
index 34fcb17..33a14ee 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/Application.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/Application.js
@@ -51,7 +51,7 @@ org.apache.flex.core.Application.prototype.controller = null;
 
 /**
  * @expose
- * @type {org.apache.flex.core.ViewBase}
+ * @type {Object}
  */
 org.apache.flex.core.Application.prototype.initialView = null;
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/IDataProviderItemRendererMapper.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/IDataProviderItemRendererMapper.js b/frameworks/js/FlexJS/src/org/apache/flex/core/IDataProviderItemRendererMapper.js
index a4524a3..82f3730 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/IDataProviderItemRendererMapper.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/IDataProviderItemRendererMapper.js
@@ -47,6 +47,7 @@ org.apache.flex.core.IDataProviderItemRendererMapper.prototype.itemRendererFacto
  * @type {Object.<string, Array.<Object>>}
  */
 org.apache.flex.core.IDataProviderItemRendererMapper.prototype.FLEXJS_CLASS_INFO = {
-   names: [{ name: 'IDataProviderItemRendererMapper',
+  names: [{ name: 'IDataProviderItemRendererMapper',
              qName: 'org.apache.flex.core.IDataProviderItemRendererMapper'}],
-  interfaces: [org.apache.flex.core.IBead] };
+  interfaces: [org.apache.flex.core.IBead]
+};

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/ItemRendererClassFactory.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/ItemRendererClassFactory.js b/frameworks/js/FlexJS/src/org/apache/flex/core/ItemRendererClassFactory.js
index d8ac005..cf34ab7 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/ItemRendererClassFactory.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/ItemRendererClassFactory.js
@@ -25,6 +25,9 @@ goog.require('org.apache.flex.core.ValuesManager');
  * @implements {org.apache.flex.core.IItemRendererClassFactory}
  */
 org.apache.flex.core.ItemRendererClassFactory = function() {
+  /**
+   * @type {Function}
+   */
   this.itemRendererClass = null;
 };
 
@@ -54,14 +57,15 @@ org.apache.flex.core.ItemRendererClassFactory.
   if (this.strand_.get_itemRenderer) {
     this.itemRendererClassFactory = this.strand_.get_itemRenderer();
     if (this.itemRendererClassFactory) {
-        this.createFunction = this.createFromClass;
-        return;
+      this.createFunction = this.createFromClass;
+      return;
     }
   }
 
   if (org.apache.flex.core.ValuesManager.valuesImpl.getValue) {
-    this.itemRendererClass = org.apache.flex.core.ValuesManager.valuesImpl.
-        getValue(this.strand_, 'iItemRenderer');
+    this.itemRendererClass =
+            /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.
+        getValue(this.strand_, 'iItemRenderer'));
     if (this.itemRendererClass) {
       this.itemRendererClassFactory = new mx.core.ClassFactory(this.itemRendererClass);
       this.createFunction = this.createFromClass;

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleCSSValuesImpl.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleCSSValuesImpl.js b/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleCSSValuesImpl.js
index cb6d734..a420c6f 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleCSSValuesImpl.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleCSSValuesImpl.js
@@ -14,35 +14,45 @@
 
 goog.provide('org.apache.flex.core.SimpleCSSValuesImpl');
 
+goog.require('org.apache.flex.core.IValuesImpl');
+
 
 
 /**
  * @constructor
+ * @implements {org.apache.flex.core.IValuesImpl};
  */
 org.apache.flex.core.SimpleCSSValuesImpl = function() {
 };
 
 
 /**
+ * @type {string}
+ */
+org.apache.flex.core.SimpleCSSValuesImpl.GLOBAL_SELECTOR = 'global';
+
+
+/**
  * Metadata
  *
  * @type {Object.<string, Array.<Object>>}
  */
 org.apache.flex.core.SimpleCSSValuesImpl.prototype.FLEXJS_CLASS_INFO =
     { names: [{ name: 'SimpleCSSValuesImpl',
-                qName: 'org.apache.flex.core.SimpleCSSValuesImpl'}] };
+               qName: 'org.apache.flex.core.SimpleCSSValuesImpl'}],
+    interfaces: [org.apache.flex.core.IValuesImpl]};
 
 
 /**
  * @param {Object} thisObject The object to fetch a value for.
  * @param {string} valueName The name of the value to fetch.
- * @param {string} state The psuedo-state if any for.
- * @param {Object} attrs The object with name value pairs that
+ * @param {string=} opt_state The psuedo-state if any for.
+ * @param {Object=} opt_attrs The object with name value pairs that
  *                       might make a difference.
  * @return {Object} The value.
  */
 org.apache.flex.core.SimpleCSSValuesImpl.prototype.getValue =
-    function(thisObject, valueName, state, attrs) {
+    function(thisObject, valueName, opt_state, opt_attrs) {
   var c = valueName.indexOf('-');
   while (c != -1)
   {
@@ -61,31 +71,31 @@ org.apache.flex.core.SimpleCSSValuesImpl.prototype.getValue =
   if ('className' in thisObject)
   {
     cName = thisObject.className;
-    if (state)
+    if (opt_state)
     {
-        selectorName = cName + ':' + state;
-        o = values['.' + selectorName];
-        if (o)
-        {
-            value = o[valueName];
-            if (value !== undefined)
-                return value;
-        }
+      selectorName = cName + ':' + opt_state;
+      o = values['.' + selectorName];
+      if (o)
+      {
+        value = o[valueName];
+        if (value !== undefined)
+          return value;
+      }
     }
 
     o = values['.' + cName];
     if (o)
     {
-        value = o[valueName];
-        if (value !== undefined)
-          return value;
+      value = o[valueName];
+      if (value !== undefined)
+        return value;
     }
   }
 
   cName = thisObject.FLEXJS_CLASS_INFO.names[0].qName;
-  if (state)
+  if (opt_state)
   {
-    selectorName = cName + ':' + state;
+    selectorName = cName + ':' + opt_state;
     o = values['.' + selectorName];
     if (o)
     {
@@ -105,9 +115,9 @@ org.apache.flex.core.SimpleCSSValuesImpl.prototype.getValue =
 
   while (cName != 'Object')
   {
-    if (state)
+    if (opt_state)
     {
-      selectorName = cName + ':' + state;
+      selectorName = cName + ':' + opt_state;
       o = values[selectorName];
       if (o)
       {
@@ -130,8 +140,8 @@ org.apache.flex.core.SimpleCSSValuesImpl.prototype.getValue =
 
     cName = thisObject.FLEXJS_CLASS_INFO.names[0].qName;
   }
-  o = values['global'];
-  if (o != undefined)
+  o = values[org.apache.flex.core.SimpleCSSValuesImpl.GLOBAL_SELECTOR];
+  if (o !== undefined)
   {
     value = o[valueName];
     if (value !== undefined)

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleStatesImpl.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleStatesImpl.js b/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleStatesImpl.js
index 0295149..318f65a 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleStatesImpl.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/SimpleStatesImpl.js
@@ -20,6 +20,7 @@ goog.require('mx.states.State');
 goog.require('org.apache.flex.core.IBead');
 goog.require('org.apache.flex.core.IStatesImpl');
 goog.require('org.apache.flex.core.IStrand');
+goog.require('org.apache.flex.core.UIBase');
 goog.require('org.apache.flex.events.EventDispatcher');
 
 
@@ -104,8 +105,11 @@ org.apache.flex.core.SimpleStatesImpl.prototype.stateChangeHandler_ =
  * @param {mx.states.State} s The State to revert.
  */
 org.apache.flex.core.SimpleStatesImpl.prototype.revert_ = function(s) {
-  var arr, item, o, p, parent, q, target;
-
+  var arr, item, o, p, q, target;
+  /**
+   * @type {org.apache.flex.core.UIBase}
+   */
+  var parent;
   arr = s.overrides;
   for (p in arr) {
     o = arr[p];
@@ -145,8 +149,11 @@ org.apache.flex.core.SimpleStatesImpl.prototype.revert_ = function(s) {
  * @param {mx.states.State} s The State to apply.
  */
 org.apache.flex.core.SimpleStatesImpl.prototype.apply_ = function(s) {
-  var arr, child, index, item, o, p, parent, q, target;
-
+  var arr, child, index, item, o, p, q, target;
+  /**
+   * type {org.apache.flex.core.UIBase}
+   */
+  var parent;
   arr = s.overrides;
   for (p in arr) {
     o = arr[p];

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/UIBase.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/UIBase.js b/frameworks/js/FlexJS/src/org/apache/flex/core/UIBase.js
index 0841873..d8043f0 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/UIBase.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/UIBase.js
@@ -136,12 +136,15 @@ org.apache.flex.core.UIBase.prototype.removeElement = function(c) {
  */
 org.apache.flex.core.UIBase.prototype.addedToParent = function() {
 
+  /**
+   * @type {Function}
+   */
   var c;
   if (this.getBeadByType(org.apache.flex.core.IBeadModel) == null)
   {
     if (org.apache.flex.core.ValuesManager.valuesImpl.getValue) {
-      c = org.apache.flex.core.ValuesManager.valuesImpl.
-          getValue(this, 'iBeadModel');
+      c = /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.
+          getValue(this, 'iBeadModel'));
       if (c)
       {
         var model = new c();
@@ -153,8 +156,8 @@ org.apache.flex.core.UIBase.prototype.addedToParent = function() {
   if (this.getBeadByType(org.apache.flex.core.IBeadView) == null)
   {
     if (org.apache.flex.core.ValuesManager.valuesImpl.getValue) {
-      c = org.apache.flex.core.ValuesManager.valuesImpl.
-          getValue(this, 'iBeadView');
+      c = /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.
+          getValue(this, 'iBeadView'));
       if (c)
       {
         var view = new c();
@@ -166,8 +169,8 @@ org.apache.flex.core.UIBase.prototype.addedToParent = function() {
   if (this.getBeadByType(org.apache.flex.core.IBeadLayout) == null)
   {
     if (org.apache.flex.core.ValuesManager.valuesImpl.getValue) {
-      c = org.apache.flex.core.ValuesManager.valuesImpl.
-          getValue(this, 'iBeadLayout');
+      c = /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.
+          getValue(this, 'iBeadLayout'));
       if (c)
       {
         var layout = new c();
@@ -179,8 +182,8 @@ org.apache.flex.core.UIBase.prototype.addedToParent = function() {
   if (this.getBeadByType(org.apache.flex.core.IBeadController) == null)
   {
     if (org.apache.flex.core.ValuesManager.valuesImpl.getValue) {
-      c = org.apache.flex.core.ValuesManager.valuesImpl.
-          getValue(this, 'iBeadController');
+      c = /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.
+          getValue(this, 'iBeadController'));
       if (c)
       {
         var controller = new c();
@@ -197,7 +200,7 @@ org.apache.flex.core.UIBase.prototype.addedToParent = function() {
  */
 org.apache.flex.core.UIBase.prototype.addBead = function(bead) {
   if (!this.beads_) {
-    this.beads_ = new Array();
+    this.beads_ = [];
   }
   this.beads_.push(bead);
 
@@ -219,7 +222,7 @@ org.apache.flex.core.UIBase.prototype.addBead = function(bead) {
 org.apache.flex.core.UIBase.prototype.getBeadByType =
     function(classOrInterface) {
   if (!this.beads_) {
-    this.beads_ = new Array();
+    this.beads_ = [];
   }
   for (var i = 0; i < this.beads_.length; i++) {
     var bead = this.beads_[i];
@@ -408,9 +411,12 @@ org.apache.flex.core.UIBase.prototype.get_model = function() {
   {
     // addbead will set _model
     if (org.apache.flex.core.ValuesManager.valuesImpl.getValue) {
-      var m = org.apache.flex.core.ValuesManager.valuesImpl.
-          getValue(this, 'iBeadModel');
-      var b = new m;
+      /**
+       * @type {Function}
+       */
+      var m = /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.
+          getValue(this, 'iBeadModel'));
+      var b = new m();
       this.addBead(b);
     }
   }

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/ValuesManager.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/ValuesManager.js b/frameworks/js/FlexJS/src/org/apache/flex/core/ValuesManager.js
index 8f08975..02cbf8d 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/ValuesManager.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/ValuesManager.js
@@ -14,6 +14,8 @@
 
 goog.provide('org.apache.flex.core.ValuesManager');
 
+goog.require('org.apache.flex.core.IValuesImpl');
+
 
 
 /**
@@ -35,15 +37,15 @@ org.apache.flex.core.ValuesManager.prototype.FLEXJS_CLASS_INFO =
 
 /**
  * @expose
- * @return {org.apache.flex.core.ValuesManager}
+ * @type {org.apache.flex.core.IValuesImpl}
  */
-org.apache.flex.core.ValuesManager.prototype.valuesImpl;
+org.apache.flex.core.ValuesManager.prototype.valuesImpl = null;
 
 
 /**
  * @expose
  * @this {org.apache.flex.core.ValuesManager}
- * @return {Object} The value.
+ * @return {org.apache.flex.core.IValuesImpl} The value.
  */
 org.apache.flex.core.ValuesManager.get_valuesImpl = function() {
   return org.apache.flex.core.ValuesManager.valuesImpl;
@@ -53,7 +55,7 @@ org.apache.flex.core.ValuesManager.get_valuesImpl = function() {
 /**
  * @expose
  * @this {org.apache.flex.core.ValuesManager}
- * @param {Object} value being set.
+ * @param {org.apache.flex.core.IValuesImpl} value being set.
  */
 org.apache.flex.core.ValuesManager.set_valuesImpl = function(value) {
   org.apache.flex.core.ValuesManager.valuesImpl = value;

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js b/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js
index 4f62918..f1ac3b0 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js
@@ -128,8 +128,11 @@ org.apache.flex.core.ViewBase.prototype.set_states = function(value) {
   this.states_ = value;
 
   if (org.apache.flex.core.ValuesManager.valuesImpl.getValue) {
-    var impl = org.apache.flex.core.ValuesManager.valuesImpl.
-        getValue(this, 'iStatesImpl');
+    /**
+     * @type {Function}
+     */
+    var impl = /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.
+        getValue(this, 'iStatesImpl'));
     // TODO: (aharui) check if bead already exists
     this.addBead(new impl());
   }

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBaseDataBinding.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBaseDataBinding.js b/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBaseDataBinding.js
index 656f1be..52bc5b8 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBaseDataBinding.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBaseDataBinding.js
@@ -76,14 +76,16 @@ org.apache.flex.core.ViewBaseDataBinding.prototype.initCompleteHandler =
   var prop;
   var fieldWatcher;
   var sb;
-  var bindingData = this.strand_['_bindings'];
+  var bindingData = this.strand_._bindings;
   var n = bindingData[0];
   var bindings = [];
   var i;
+  var binding;
+  var destination;
   var index = 1;
   for (i = 0; i < n; i++)
   {
-    var binding = {};
+    binding = {};
     binding.source = bindingData[index++];
     binding.destFunc = bindingData[index++];
     binding.destination = bindingData[index++];
@@ -102,10 +104,9 @@ org.apache.flex.core.ViewBaseDataBinding.prototype.initCompleteHandler =
         if (binding.source.length == 2 &&
             binding.destination.length == 2)
         {
-          var destination;
           // can be simplebinding or constantbinding
           var modelWatcher =
-              watchers.watcherMap['applicationModel'];
+              watchers.watcherMap.applicationModel;
           var childMap = modelWatcher.children.watcherMap;
           fieldWatcher = childMap[binding.source[1]];
           if (typeof(fieldWatcher.eventNames) == 'string')
@@ -345,17 +346,18 @@ org.apache.flex.core.ViewBaseDataBinding.prototype.decodeWatcher =
 org.apache.flex.core.ViewBaseDataBinding.prototype.deferredBindingsHandler =
     function(event) {
   var p;
+  var destination;
   for (p in this.deferredBindings)
   {
     if (typeof(this.strand_['get_' + p]) == 'function')
     {
-      var destination = this.strand_['get_' + p]();
+      destination = this.strand_['get_' + p]();
       destination.addBead(this.deferredBindings[p]);
       delete this.deferredBindings[p];
     }
     else if (this.strand_[p] != null)
     {
-      var destination = this.strand_[p];
+      destination = this.strand_[p];
       destination.addBead(this.deferredBindings[p]);
       delete this.deferredBindings[p];
     }

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Alert.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Alert.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Alert.js
index 57854b5..8f27c76 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Alert.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Alert.js
@@ -89,6 +89,8 @@ org.apache.flex.html.staticControls.Alert.prototype.createElement =
   this.buttonArea = new org.apache.flex.html.staticControls.Container();
   this.addElement(this.buttonArea);
   this.buttonArea.element.id = 'buttonArea';
+
+  return this.element;
 };
 
 
@@ -174,28 +176,28 @@ org.apache.flex.html.staticControls.Alert.prototype.set_flags =
     var ok = new org.apache.flex.html.staticControls.TextButton();
     this.buttonArea.addElement(ok);
     ok.set_text('OK');
-    goog.events.listen(ok.element, 'click',
+    goog.events.listen(/** @type {EventTarget} */ (ok.element), 'click',
         goog.bind(this.dismissAlert, this));
   }
   if (this.flags & org.apache.flex.html.staticControls.Alert.CANCEL) {
     var cancel = new org.apache.flex.html.staticControls.TextButton();
     this.buttonArea.addElement(cancel);
     cancel.set_text('Cancel');
-    goog.events.listen(cancel.element, 'click',
+    goog.events.listen(/** @type {EventTarget} */ (cancel.element), 'click',
         goog.bind(this.dismissAlert, this));
   }
   if (this.flags & org.apache.flex.html.staticControls.Alert.YES) {
     var yes = new org.apache.flex.html.staticControls.TextButton();
     this.buttonArea.addElement(yes);
     yes.set_text('YES');
-    goog.events.listen(yes.element, 'click',
+    goog.events.listen(/** @type {EventTarget} */ (yes.element), 'click',
         goog.bind(this.dismissAlert, this));
   }
   if (this.flags & org.apache.flex.html.staticControls.Alert.NO) {
     var nob = new org.apache.flex.html.staticControls.TextButton();
     this.buttonArea.addElement(nob);
     nob.set_text('NO');
-    goog.events.listen(nob.element, 'click',
+    goog.events.listen(/** @type {EventTarget} */ (nob.element), 'click',
         goog.bind(this.dismissAlert, this));
   }
 };

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ComboBox.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ComboBox.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ComboBox.js
index f68be04..b469b04 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ComboBox.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ComboBox.js
@@ -75,12 +75,14 @@ org.apache.flex.html.staticControls.ComboBox.prototype.createElement =
       goog.bind(this.dismissPopup, this));
 
   input.flexjs_wrapper = this;
+
+  return this.element;
 };
 
 
 /**
  * @expose
- * @param {string} event The event.
+ * @param {Object} event The event.
  */
 org.apache.flex.html.staticControls.ComboBox.prototype.selectChanged =
     function(event) {
@@ -99,10 +101,10 @@ org.apache.flex.html.staticControls.ComboBox.prototype.selectChanged =
 
 /**
  * @expose
- * @param {string} event The event.
+ * @param {Object=} opt_event The event.
  */
 org.apache.flex.html.staticControls.ComboBox.prototype.dismissPopup =
-    function(event) {
+    function(opt_event) {
   // remove the popup if it already exists
   if (this.popup) {
     this.popup.parentNode.removeChild(this.popup);
@@ -113,11 +115,15 @@ org.apache.flex.html.staticControls.ComboBox.prototype.dismissPopup =
 
 /**
  * @expose
- * @param {string} event The event.
+ * @param {Object} event The event.
  */
 org.apache.flex.html.staticControls.ComboBox.prototype.buttonClicked =
     function(event) {
-  var dp, i, input, left, n, opt, opts, pn, popup, select, si, top, width;
+  /**
+   * @type {Array.<string>}
+   */
+  var dp;
+  var i, input, left, n, opt, opts, pn, popup, select, si, top, width;
 
   event.stopPropagation();
 
@@ -150,7 +156,7 @@ org.apache.flex.html.staticControls.ComboBox.prototype.buttonClicked =
   goog.events.listen(select, 'change', goog.bind(this.selectChanged, this));
   opts = select.options;
 
-  dp = this.get_dataProvider();
+  dp = /** @type {Array.<string>} */ (this.get_dataProvider());
   n = dp.length;
   for (i = 0; i < n; i++) {
     opt = document.createElement('option');

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ControlBar.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ControlBar.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ControlBar.js
index b49f5cd..09b1fa5 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ControlBar.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/ControlBar.js
@@ -44,7 +44,7 @@ org.apache.flex.html.staticControls.ControlBar.prototype.FLEXJS_CLASS_INFO =
  * @override
  */
 org.apache.flex.html.staticControls.ControlBar.prototype.createElement =
-    function(p) {
+    function() {
 
   this.element = document.createElement('div');
   this.element.className = 'ControlBar';
@@ -52,4 +52,6 @@ org.apache.flex.html.staticControls.ControlBar.prototype.createElement =
 
   this.positioner = this.element;
   this.element.flexjs_wrapper = this;
+
+  return this.element;
 };

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js
index 4555daf..c554129 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/List.js
@@ -108,12 +108,16 @@ org.apache.flex.html.staticControls.List.prototype.addedToParent =
     function() {
   goog.base(this, 'addedToParent');
 
-  var c = this.getBeadByType(org.apache.flex.core.IDataProviderItemRendererMapper);
-  if (org.apache.flex.core.ValuesManager.valuesImpl.getValue && !c) {
-    c = org.apache.flex.core.ValuesManager.valuesImpl.getValue(this,
-                            'iDataProviderItemRendererMapper');
+  var b = this.getBeadByType(org.apache.flex.core.IDataProviderItemRendererMapper);
+  if (org.apache.flex.core.ValuesManager.valuesImpl.getValue && !b) {
+    /**
+     * @type {Function}
+     */
+    var c;
+    c = /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.getValue(this,
+                            'iDataProviderItemRendererMapper'));
     if (c) {
-      var bead = new c;
+      var bead = new c();
       this.addBead(bead);
     }
   }

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/NumericStepper.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/NumericStepper.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/NumericStepper.js
index b030326..66926ef 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/NumericStepper.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/NumericStepper.js
@@ -66,6 +66,8 @@ org.apache.flex.html.staticControls.NumericStepper.prototype.createElement =
   this.set_className('NumericStepper');
 
   this.input.set_text(String(this.spinner.get_value()));
+
+  return this.element;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Panel.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Panel.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Panel.js
index b3a6603..40bf262 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Panel.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Panel.js
@@ -76,7 +76,7 @@ org.apache.flex.html.staticControls.Panel.prototype.addElementAt =
   else
   {
     this.contentArea.insertBefore(c.element,
-        this.getChildAt(index));
+        children[index]);
     c.addedToParent();
   }
 };
@@ -127,6 +127,8 @@ org.apache.flex.html.staticControls.Panel.prototype.createElement =
 
   this.positioner = this.element;
   this.element.flexjs_wrapper = this;
+
+  return this.element;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Slider.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Slider.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Slider.js
index b9f7c99..6a19bd4 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Slider.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Slider.js
@@ -69,12 +69,14 @@ org.apache.flex.html.staticControls.Slider.prototype.createElement =
   this.element.flexjs_wrapper = this;
 
   this.set_className('Slider');
+
+  return this.element;
 };
 
 
 /**
  * @expose
- * @return {Number} The value getter.
+ * @return {number} The value getter.
  */
 org.apache.flex.html.staticControls.Slider.prototype.get_value =
     function() {
@@ -96,7 +98,7 @@ org.apache.flex.html.staticControls.Slider.prototype.set_value =
 
 /**
  * @expose
- * @return {Number} The minimum getter.
+ * @return {number} The minimum getter.
  */
 org.apache.flex.html.staticControls.Slider.prototype.get_minimum =
     function() {
@@ -117,7 +119,7 @@ org.apache.flex.html.staticControls.Slider.prototype.set_minimum =
 
 /**
  * @expose
- * @return {Number} The maximum getter.
+ * @return {number} The maximum getter.
  */
 org.apache.flex.html.staticControls.Slider.prototype.get_maximum =
     function() {
@@ -138,7 +140,7 @@ org.apache.flex.html.staticControls.Slider.prototype.set_maximum =
 
 /**
  * @expose
- * @return {Number} The snapInterval getter.
+ * @return {number} The snapInterval getter.
  */
 org.apache.flex.html.staticControls.Slider.prototype.get_snapInterval =
     function() {
@@ -159,7 +161,7 @@ org.apache.flex.html.staticControls.Slider.prototype.set_snapInterval =
 
 /**
  * @expose
- * @return {Number} The stepSize getter.
+ * @return {number} The stepSize getter.
  */
 org.apache.flex.html.staticControls.Slider.prototype.get_stepSize =
     function() {
@@ -180,7 +182,7 @@ org.apache.flex.html.staticControls.Slider.prototype.set_stepSize =
 
 /**
  * @param {Object} value The current value.
- * @return {Number} Calculates the new value based snapInterval and stepSize.
+ * @return {number} Calculates the new value based snapInterval and stepSize.
  */
 org.apache.flex.html.staticControls.Slider.prototype.snap = function(value)
     {
@@ -200,7 +202,7 @@ org.apache.flex.html.staticControls.Slider.prototype.snap = function(value)
 
 
 /**
- * @param {Number} value The value used to calculate new position of the thumb.
+ * @param {number} value The value used to calculate new position of the thumb.
  * @return {void} Moves the thumb to the corresponding position.
  */
 org.apache.flex.html.staticControls.Slider.prototype.setThumbFromValue =

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Spinner.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Spinner.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Spinner.js
index a885e81..8911105 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Spinner.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/Spinner.js
@@ -70,6 +70,8 @@ org.apache.flex.html.staticControls.Spinner.prototype.createElement =
   this.addBead(this.controller);
 
   this.element.flexjs_wrapper = this;
+
+  return this.element;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/TitleBar.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/TitleBar.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/TitleBar.js
index 53ffab4..36f9322 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/TitleBar.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/TitleBar.js
@@ -75,6 +75,8 @@ org.apache.flex.html.staticControls.TitleBar.prototype.createElement =
   // listen for changes to the model so items can be changed in the view
   this.model.addEventListener('titleChange',
       goog.bind(this.changeHandler, this));
+
+  return this.element;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/NumericOnlyTextInputBead.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/NumericOnlyTextInputBead.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/NumericOnlyTextInputBead.js
index 8553cf2..13a5ae9 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/NumericOnlyTextInputBead.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/NumericOnlyTextInputBead.js
@@ -23,10 +23,10 @@ org.apache.flex.html.staticControls.accessories.NumericOnlyTextInputBead =
     function() {
 
   /**
-   * @private
+   * @protected
    * @type {Object}
    */
-  this.promptElement;
+  this.promptElement = null;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/PasswordInputBead.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/PasswordInputBead.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/PasswordInputBead.js
index e470f67..cd5baf7 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/PasswordInputBead.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/PasswordInputBead.js
@@ -23,10 +23,10 @@ org.apache.flex.html.staticControls.accessories.PasswordInputBead =
     function() {
 
   /**
-   * @private
+   * @protected
    * @type {Object}
    */
-  this.promptElement;
+  this.promptElement = null;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/TextPromptBead.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/TextPromptBead.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/TextPromptBead.js
index c848028..444f370 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/TextPromptBead.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/accessories/TextPromptBead.js
@@ -22,10 +22,10 @@ goog.provide('org.apache.flex.html.staticControls.accessories.TextPromptBead');
 org.apache.flex.html.staticControls.accessories.TextPromptBead = function() {
 
   /**
-   * @private
+   * @protected
    * @type {Object}
    */
-  this.promptElement;
+  this.promptElement = null;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js
index fdd363f..f461ef7 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/DataItemRendererFactoryForArrayData.js
@@ -76,8 +76,12 @@ org.apache.flex.html.staticControls.beads.DataItemRendererFactoryForArrayData.
       goog.bind(this.dataProviderChangedHandler, this));
 
   if (org.apache.flex.core.ValuesManager.valuesImpl.getValue && !this.itemRendererFactory_) {
-    var c = org.apache.flex.core.ValuesManager.valuesImpl.getValue(this.strand_, 'iItemRendererClassFactory');
-    this.itemRendererFactory_ = new c;
+    /**
+     * @type {Function}
+     */
+    var c = /** @type {Function} */ (org.apache.flex.core.ValuesManager.valuesImpl.getValue(this.strand_,
+            'iItemRendererClassFactory'));
+    this.itemRendererFactory_ = new c();
     this.strand_.addBead(this.itemRendererFactory_);
   }
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/ListView.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/ListView.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/ListView.js
index 9e7dd3b..dd2ac4e 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/ListView.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/ListView.js
@@ -93,8 +93,9 @@ org.apache.flex.html.staticControls.beads.ListView.prototype.get_dataGroup =
  */
 org.apache.flex.html.staticControls.beads.ListView.prototype.
     selectionChangeHandler = function(value) {
+  var ir;
   if (this.lastSelectedIndex != -1) {
-    var ir = this.dataGroup_.getItemRendererForIndex(this.lastSelectedIndex);
+    ir = this.dataGroup_.getItemRendererForIndex(this.lastSelectedIndex);
     if (ir) ir.set_selected(false);
   }
   if (this.model.get_selectedIndex() != -1) {

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/TextItemRendererFactoryForArrayData.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/TextItemRendererFactoryForArrayData.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/TextItemRendererFactoryForArrayData.js
index f1c5357..d340174 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/TextItemRendererFactoryForArrayData.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/TextItemRendererFactoryForArrayData.js
@@ -28,7 +28,7 @@ goog.require('org.apache.flex.html.staticControls.beads.models.ArraySelectionMod
  */
 org.apache.flex.html.staticControls.beads.TextItemRendererFactoryForArrayData =
     function() {
-    goog.base(this);
+  goog.base(this);
 };
 goog.inherits(
     org.apache.flex.html.staticControls.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SliderMouseController.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SliderMouseController.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SliderMouseController.js
index 769a548..afa6c29 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SliderMouseController.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SliderMouseController.js
@@ -142,7 +142,7 @@ org.apache.flex.html.staticControls.beads.controllers.SliderMouseController.
 /**
  *        SliderMouseController}
  * @param {Event} event The event triggering the function.
- * @param {Boolean} useOffset If true, event.offsetX is used in the calculation.
+ * @param {boolean} useOffset If true, event.offsetX is used in the calculation.
  * @return {void} Determines the new value based on the movement of the mouse
  * along the slider.
  */

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SpinnerMouseController.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SpinnerMouseController.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SpinnerMouseController.js
index 1d83a5e..4549d09 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SpinnerMouseController.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/controllers/SpinnerMouseController.js
@@ -73,7 +73,7 @@ org.apache.flex.html.staticControls.beads.controllers.SpinnerMouseController.
 
 /**
  *        SpinnerMouseController}
- * @param {event} event The event object.
+ * @param {Event} event The event object.
  */
 org.apache.flex.html.staticControls.beads.controllers.SpinnerMouseController.
     prototype.handleDecrementClick =

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/PanelModel.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/PanelModel.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/PanelModel.js
index 28702d5..04c735d 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/PanelModel.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/PanelModel.js
@@ -25,8 +25,20 @@ goog.require('org.apache.flex.events.EventDispatcher');
 org.apache.flex.html.staticControls.beads.models.PanelModel = function() {
   goog.base(this);
 
+  /**
+   * @private
+   * @type {string}
+   */
   this.title_ = '';
-  this.htmlTitle = '';
+  /**
+   * @private
+   * @type {string}
+   */
+  this.htmlTitle_ = '';
+  /**
+   * @private
+   * @type {boolean}
+   */
   this.showCloseButton_ = false;
 };
 goog.inherits(org.apache.flex.html.staticControls.beads.models.PanelModel,
@@ -55,7 +67,7 @@ org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
 
 /**
  * @expose
- * @return {String} The title.
+ * @return {string} The title.
  */
 org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
     get_title = function() {
@@ -65,7 +77,7 @@ org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
 
 /**
  * @expose
- * @param {String} value The title to set.
+ * @param {string} value The title to set.
  */
 org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
     set_title = function(value) {
@@ -78,7 +90,7 @@ org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
 
 /**
  * @expose
- * @return {String} The HTML title.
+ * @return {string} The HTML title.
  */
 org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
     get_htmlTitle = function() {
@@ -88,7 +100,7 @@ org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
 
 /**
  * @expose
- * @param {String} value The new HTML title.
+ * @param {string} value The new HTML title.
  */
 org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
     set_htmlTitle = function(value) {
@@ -101,7 +113,7 @@ org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
 
 /**
  * @expose
- * @return {Boolean} Returns true if the close button should appear in
+ * @return {boolean} Returns true if the close button should appear in
  * the TitleBar.
  */
 org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
@@ -112,7 +124,7 @@ org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.
 
 /**
  * @expose
- * @param {Boolean} value Determines if the close button shows (true) or
+ * @param {boolean} value Determines if the close button shows (true) or
  * not (false).
  */
 org.apache.flex.html.staticControls.beads.models.PanelModel.prototype.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/RangeModel.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/RangeModel.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/RangeModel.js
index 2b5e577..eeb391b 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/RangeModel.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/RangeModel.js
@@ -57,7 +57,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @return {Number} The current minimum value.
+ * @return {number} The current minimum value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     get_minimum = function() {
@@ -67,7 +67,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @param {Number} value The new minimum value.
+ * @param {number} value The new minimum value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     set_minimum = function(value) {
@@ -80,7 +80,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @return {Number} The current maximu value.
+ * @return {number} The current maximu value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     get_maximum = function() {
@@ -90,7 +90,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @param {Number} value The new maximum value.
+ * @param {number} value The new maximum value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     set_maximum = function(value) {
@@ -103,7 +103,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @return {Number} The current value.
+ * @return {number} The current value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     get_value = function() {
@@ -113,7 +113,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @param {Number} newValue The new value.
+ * @param {number} newValue The new value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     set_value = function(newValue) {
@@ -133,7 +133,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @return {Number} The current snapInterval value.
+ * @return {number} The current snapInterval value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     get_snapInterval = function() {
@@ -143,7 +143,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @param {Number} value The new snapInterval value.
+ * @param {number} value The new snapInterval value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     set_snapInterval = function(value) {
@@ -156,7 +156,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @return {Number} The current stepSize value.
+ * @return {number} The current stepSize value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     get_stepSize = function() {
@@ -166,7 +166,7 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @param {Number} value The new stepSize value.
+ * @param {number} value The new stepSize value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     set_stepSize = function(value) {
@@ -179,8 +179,8 @@ org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
 
 /**
  * @expose
- * @param {Number} value The candidate number.
- * @return {Number} Adjusted value.
+ * @param {number} value The candidate number.
+ * @return {number} Adjusted value.
  */
 org.apache.flex.html.staticControls.beads.models.RangeModel.prototype.
     snap = function(value) {

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/TitleBarModel.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/TitleBarModel.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/TitleBarModel.js
index 0229df2..8d9b64d 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/TitleBarModel.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/beads/models/TitleBarModel.js
@@ -25,8 +25,20 @@ goog.require('org.apache.flex.events.EventDispatcher');
 org.apache.flex.html.staticControls.beads.models.TitleBarModel = function() {
   goog.base(this);
 
+  /**
+   * @private
+   * @type {string}
+   */
   this.title_ = '';
-  this.htmlTitle = '';
+  /**
+   * @private
+   * @type {string}
+   */
+  this.htmlTitle_ = '';
+  /**
+   * @private
+   * @type {boolean}
+   */
   this.showCloseButton_ = false;
 };
 goog.inherits(org.apache.flex.html.staticControls.beads.models.TitleBarModel,
@@ -55,7 +67,7 @@ org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
 
 /**
  * @expose
- * @return {String} The title.
+ * @return {string} The title.
  */
 org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
     get_title = function() {
@@ -65,7 +77,7 @@ org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
 
 /**
  * @expose
- * @param {String} value The title to set.
+ * @param {string} value The title to set.
  */
 org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
     set_title = function(value) {
@@ -78,7 +90,7 @@ org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
 
 /**
  * @expose
- * @return {String} The HTML title.
+ * @return {string} The HTML title.
  */
 org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
     get_htmlTitle = function() {
@@ -88,7 +100,7 @@ org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
 
 /**
  * @expose
- * @param {String} value The new HTML title.
+ * @param {string} value The new HTML title.
  */
 org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
     set_htmlTitle = function(value) {
@@ -101,7 +113,7 @@ org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
 
 /**
  * @expose
- * @return {Boolean} Returns true if the close button should appear in
+ * @return {boolean} Returns true if the close button should appear in
  * the TitleBar.
  */
 org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
@@ -112,7 +124,7 @@ org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.
 
 /**
  * @expose
- * @param {Boolean} value Determines if the close button shows (true) or
+ * @param {boolean} value Determines if the close button shows (true) or
  * not (false).
  */
 org.apache.flex.html.staticControls.beads.models.TitleBarModel.prototype.

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/ButtonBarButtonItemRenderer.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/ButtonBarButtonItemRenderer.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/ButtonBarButtonItemRenderer.js
index d8992b6..ff85b7a 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/ButtonBarButtonItemRenderer.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/ButtonBarButtonItemRenderer.js
@@ -101,10 +101,10 @@ org.apache.flex.html.staticControls.supportClasses.ButtonBarButtonItemRenderer.
   goog.base(this, 'set_data', value);
 
   if (value.hasOwnProperty('label')) {
-    this.button.innerHTML = value['label'];
+    this.button.innerHTML = value.label;
   }
   else if (value.hasOwnProperty('title')) {
-    this.button.innerHTML = value['title'];
+    this.button.innerHTML = value.title;
   }
   else {
     this.button.innerHHTML = String(value);

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/DataGridColumn.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/DataGridColumn.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/DataGridColumn.js
index ec84b55..8b59a9b 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/DataGridColumn.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/DataGridColumn.js
@@ -32,7 +32,7 @@ org.apache.flex.html.staticControls.supportClasses.DataGridColumn =
  */
 org.apache.flex.html.staticControls.supportClasses.DataGridColumn.prototype.get_itemRenderer =
 function() {
-   return this.itemRenderer_;
+  return this.itemRenderer_;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/NonVirtualDataGroup.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/NonVirtualDataGroup.js b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/NonVirtualDataGroup.js
index d7b9f17..0ccde8c 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/NonVirtualDataGroup.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html/staticControls/supportClasses/NonVirtualDataGroup.js
@@ -24,7 +24,7 @@ goog.require('org.apache.flex.core.UIBase');
  */
 org.apache.flex.html.staticControls.supportClasses.NonVirtualDataGroup =
     function() {
-  this.renderers = new Array();
+  this.renderers = [];
   goog.base(this);
 };
 goog.inherits(

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/CheckBox.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/CheckBox.js b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/CheckBox.js
index 9faf726..4bb0af5 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/CheckBox.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/CheckBox.js
@@ -44,6 +44,8 @@ org.apache.flex.html5.staticControls.CheckBox.prototype.createElement =
   this.element.appendChild(document.createTextNode('check box'));
 
   this.positioner = this.element;
+
+  return this.element;
 };
 
 
@@ -68,7 +70,7 @@ org.apache.flex.html5.staticControls.CheckBox.prototype.set_text =
 
 /**
  * @expose
- * @return {bool} The selected getter.
+ * @return {boolean} The selected getter.
  */
 org.apache.flex.html5.staticControls.CheckBox.prototype.get_selected =
     function() {
@@ -78,7 +80,7 @@ org.apache.flex.html5.staticControls.CheckBox.prototype.get_selected =
 
 /**
  * @expose
- * @param {bool} value The selected setter.
+ * @param {boolean} value The selected setter.
  */
 org.apache.flex.html5.staticControls.CheckBox.prototype.set_selected =
     function(value) {

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/ComboBox.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/ComboBox.js b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/ComboBox.js
index 318005c..b6925e6 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/ComboBox.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/ComboBox.js
@@ -52,7 +52,7 @@ org.apache.flex.html5.staticControls.ComboBox.prototype.createElement =
   button.style.height = '20px';
   button.style.margin = '0';
   button.style.border = 'solid #609 1px';
-  button.onclick = goog.bind(this.buttonClicked, this);
+  button.onclick = /** @type {function (Event)} */ (goog.bind(this.buttonClicked, this));
   this.element.appendChild(button);
 
   this.element.style.position = 'relative';
@@ -63,12 +63,14 @@ org.apache.flex.html5.staticControls.ComboBox.prototype.createElement =
   // dismiss the pop-up should it be visible.
   goog.events.listen(document, 'click',
       goog.bind(this.dismissPopup, this));
+
+  return this.element;
 };
 
 
 /**
  * @expose
- * @param {string} event The event.
+ * @param {Event} event The event.
  */
 org.apache.flex.html5.staticControls.ComboBox.prototype.selectChanged =
     function(event) {
@@ -86,7 +88,7 @@ org.apache.flex.html5.staticControls.ComboBox.prototype.selectChanged =
 
 /**
  * @expose
- * @param {string} event The event.
+ * @param {Event} event The event.
  */
 org.apache.flex.html5.staticControls.ComboBox.prototype.dismissPopup =
     function(event) {
@@ -99,11 +101,15 @@ org.apache.flex.html5.staticControls.ComboBox.prototype.dismissPopup =
 
 /**
  * @expose
- * @param {string} event The event.
+ * @param {Event} event The event.
  */
 org.apache.flex.html5.staticControls.ComboBox.prototype.buttonClicked =
     function(event) {
-  var dp, i, input, left, n, opt, opts, pn, popup, select, si, top, width;
+  /**
+   * @type {Array.<string>}
+   */
+  var dp;
+  var i, input, left, n, opt, opts, pn, popup, select, si, top, width;
 
   event.stopPropagation();
 
@@ -133,10 +139,10 @@ org.apache.flex.html5.staticControls.ComboBox.prototype.buttonClicked =
 
   select = document.createElement('select');
   select.style.width = width.toString() + 'px';
-  select.onchange = goog.bind(this.selectChanged, this);
+  select.onchange = /** @type {function(Event)} */ (goog.bind(this.selectChanged, this));
   opts = select.options;
 
-  dp = this.get_dataProvider();
+  dp = /** @type {Array.<string>} */ (this.get_dataProvider());
   n = dp.length;
   for (i = 0; i < n; i++) {
     opt = document.createElement('option');

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/Label.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/Label.js b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/Label.js
index d8f5f5f..0265ce7 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/Label.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/Label.js
@@ -37,6 +37,8 @@ org.apache.flex.html5.staticControls.Label.prototype.createElement =
   goog.base(this, 'createElement');
 
   this.positioner = this.element;
+
+  return this.element;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/List.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/List.js b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/List.js
index 22b49f2..754a77f 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/List.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/List.js
@@ -33,8 +33,10 @@ goog.inherits(org.apache.flex.html5.staticControls.List,
  * @override
  */
 org.apache.flex.html5.staticControls.List.prototype.createElement =
-    function(p) {
+    function() {
   goog.base(this, 'createElement');
 
   this.element.size = 5;
+
+  return this.element;
 };

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/RadioButton.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/RadioButton.js b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/RadioButton.js
index 6f21b8a..4e5bc1f 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/RadioButton.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/RadioButton.js
@@ -44,6 +44,8 @@ org.apache.flex.html5.staticControls.RadioButton.prototype.createElement =
   this.element.appendChild(document.createTextNode('radio button'));
 
   this.positioner = this.element;
+
+  return this.element;
 };
 
 
@@ -89,7 +91,7 @@ org.apache.flex.html5.staticControls.RadioButton.prototype.set_text =
 
 /**
  * @expose
- * @return {bool} The selected getter.
+ * @return {boolean} The selected getter.
  */
 org.apache.flex.html5.staticControls.RadioButton.prototype.get_selected =
     function() {
@@ -99,7 +101,7 @@ org.apache.flex.html5.staticControls.RadioButton.prototype.get_selected =
 
 /**
  * @expose
- * @param {bool} value The selected setter.
+ * @param {boolean} value The selected setter.
  */
 org.apache.flex.html5.staticControls.RadioButton.prototype.set_selected =
     function(value) {

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextArea.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextArea.js b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextArea.js
index ac5a29a..e65d895 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextArea.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextArea.js
@@ -37,6 +37,8 @@ org.apache.flex.html5.staticControls.TextArea.prototype.createElement =
   this.element = document.createElement('textarea');
 
   this.positioner = this.element;
+
+  return this.element;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextButton.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextButton.js b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextButton.js
index db479fb..a244aa5 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextButton.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextButton.js
@@ -38,6 +38,8 @@ org.apache.flex.html5.staticControls.TextButton.prototype.createElement =
   this.element.setAttribute('type', 'button');
 
   this.positioner = this.element;
+
+  return this.element;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextInput.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextInput.js b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextInput.js
index dfbb052..9dc0d83 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextInput.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/html5/staticControls/TextInput.js
@@ -38,6 +38,8 @@ org.apache.flex.html5.staticControls.TextInput.prototype.createElement =
   this.element.setAttribute('type', 'input');
 
   this.positioner = this.element;
+
+  return this.element;
 };
 
 

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/jquery/staticControls/RadioButton.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/jquery/staticControls/RadioButton.js b/frameworks/js/FlexJS/src/org/apache/flex/jquery/staticControls/RadioButton.js
index b0b22e7..e0d8c29 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/jquery/staticControls/RadioButton.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/jquery/staticControls/RadioButton.js
@@ -37,7 +37,7 @@ goog.inherits(org.apache.flex.jquery.staticControls.RadioButton,
  * @expose
  * The name of the radioGroup.
  */
-org.apache.flex.jquery.staticControls.RadioButton.prototype.radioGroupName;
+org.apache.flex.jquery.staticControls.RadioButton.prototype.radioGroupName = null;
 
 
 /**

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/net/BinaryUploader.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/net/BinaryUploader.js b/frameworks/js/FlexJS/src/org/apache/flex/net/BinaryUploader.js
index 582698d..db0b0c3 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/net/BinaryUploader.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/net/BinaryUploader.js
@@ -27,16 +27,16 @@ org.apache.flex.net.BinaryUploader = function() {
   goog.base(this);
 
   /**
-   * @protected
+   * @private
    * @type {string}
    */
-  this.url_;
+  this.url_ = null;
 
   /**
    * @private
    * @type {Number}
    */
-  this.status_;
+  this.status_ = -1;
 
   /**
    * @private
@@ -48,19 +48,19 @@ org.apache.flex.net.BinaryUploader = function() {
    * @private
    * @type {Array}
    */
-  this.headers_;
+  this.headers_ = null;
 
   /**
    * @private
    * @type {Array}
    */
-  this.responseHeaders_;
+  this.responseHeaders_ = null;
 
   /**
    * @private
    * @type {string}
    */
-  this.responseURL_;
+  this.responseURL_ = null;
 
   /**
    * @private
@@ -72,7 +72,7 @@ org.apache.flex.net.BinaryUploader = function() {
    * @private
    * @type {string}
    */
-  this.binaryData_;
+  this.binaryData_ = null;
 
   /**
    * @private
@@ -365,7 +365,7 @@ org.apache.flex.net.BinaryUploader.prototype.progressHandler = function() {
  * @expose
  * @type {string}
  */
-org.apache.flex.net.BinaryUploader.prototype.id;
+org.apache.flex.net.BinaryUploader.prototype.id = null;
 
 
 /**

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPHeader.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPHeader.js b/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPHeader.js
index 411b514..c24420d 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPHeader.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPHeader.js
@@ -51,13 +51,13 @@ org.apache.flex.net.HTTPHeader.CONTENT_TYPE = 'Content-type';
 
 /**
  * @expose
- * @type {string}
+ * @type {?string}
  */
-org.apache.flex.net.HTTPHeader.prototype.value;
+org.apache.flex.net.HTTPHeader.prototype.value = null;
 
 
 /**
  * @expose
- * @type {string}
+ * @type {?string}
  */
-org.apache.flex.net.HTTPHeader.prototype.name;
+org.apache.flex.net.HTTPHeader.prototype.name = null;

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPService.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPService.js b/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPService.js
index 28a6cfe..52ece7a 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPService.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/net/HTTPService.js
@@ -27,16 +27,16 @@ org.apache.flex.net.HTTPService = function() {
   goog.base(this);
 
   /**
-   * @protected
-   * @type {string}
+   * @private
+   * @type {?string}
    */
-  this.url_;
+  this.url_ = null;
 
   /**
    * @private
    * @type {number}
    */
-  this.status_;
+  this.status_ = -1;
 
   /**
    * @private
@@ -48,19 +48,19 @@ org.apache.flex.net.HTTPService = function() {
    * @private
    * @type {Array}
    */
-  this.headers_;
+  this.headers_ = null;
 
   /**
    * @private
    * @type {Array}
    */
-  this.responseHeaders_;
+  this.responseHeaders_ = null;
 
   /**
    * @private
-   * @type {string}
+   * @type {?string}
    */
-  this.responseURL_;
+  this.responseURL_ = null;
 
   /**
    * @private
@@ -70,9 +70,9 @@ org.apache.flex.net.HTTPService = function() {
 
   /**
    * @private
-   * @type {string}
+   * @type {?string}
    */
-  this.contentData_;
+  this.contentData_ = null;
 
   /**
    * @private
@@ -140,7 +140,7 @@ org.apache.flex.net.HTTPService.prototype.get_data = function() {
 
 /**
  * @expose
- * @return {string} value The contentData.
+ * @return {?string} value The contentData.
  */
 org.apache.flex.net.HTTPService.prototype.get_contentData = function() {
   return this.contentData_;
@@ -179,7 +179,7 @@ org.apache.flex.net.HTTPService.prototype.set_contentType = function(value) {
  * @return {Array} value The array of HTTPHeaders.
  */
 org.apache.flex.net.HTTPService.prototype.get_headers = function() {
-  if (!this.headers_ === undefined) {
+  if (this.headers_ === undefined) {
     this.headers_ = [];
   }
 
@@ -240,7 +240,7 @@ org.apache.flex.net.HTTPService.prototype.get_responseHeaders = function() {
 
 /**
  * @expose
- * @return {string} value The url.
+ * @return {?string} value The url.
  */
 org.apache.flex.net.HTTPService.prototype.get_responseURL = function() {
   return this.responseURL_;
@@ -276,7 +276,7 @@ org.apache.flex.net.HTTPService.prototype.set_timeout = function(value) {
 
 /**
  * @expose
- * @return {string} value The url.
+ * @return {?string} value The url.
  */
 org.apache.flex.net.HTTPService.prototype.get_url = function() {
   return this.url_;
@@ -363,14 +363,14 @@ org.apache.flex.net.HTTPService.prototype.progressHandler = function() {
 
 /**
  * @expose
- * @type {string}
+ * @type {?string}
  */
-org.apache.flex.net.HTTPService.prototype.id;
+org.apache.flex.net.HTTPService.prototype.id = null;
 
 
 /**
  * @expose
- * @return {string} The id.
+ * @return {?string} The id.
  */
 org.apache.flex.net.HTTPService.prototype.get_id = function() {
   return this.id;

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/utils/Language.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/utils/Language.js b/frameworks/js/FlexJS/src/org/apache/flex/utils/Language.js
index e2317f3..8701c71 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/utils/Language.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/utils/Language.js
@@ -155,7 +155,7 @@ org.apache.flex.utils.Language.trace = function(opt_value) {
 
   opt_value = (opt_value !== undefined) ? opt_value : '';
 
-  theConsole = goog.global['console'];
+  theConsole = goog.global.console;
 
   try {
     if (theConsole && theConsole.log) {

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/375b544e/frameworks/js/FlexJS/src/org/apache/flex/utils/Timer.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/utils/Timer.js b/frameworks/js/FlexJS/src/org/apache/flex/utils/Timer.js
index 176196c..fa91518 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/utils/Timer.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/utils/Timer.js
@@ -110,7 +110,7 @@ org.apache.flex.utils.Timer.prototype.timerHandler =
 
 /**
  * @expose
- * @return {Number} The currentCount.
+ * @return {number} The currentCount.
  */
 org.apache.flex.utils.Timer.prototype.get_currentCount = function() {
   return this._currentCount;
@@ -128,7 +128,7 @@ org.apache.flex.utils.Timer.prototype.get_running = function() {
 
 /**
  * @expose
- * @return {Number} The number of milliseconds between events.
+ * @return {number} The number of milliseconds between events.
  */
 org.apache.flex.utils.Timer.prototype.get_delay = function() {
   return this._delay;
@@ -137,7 +137,7 @@ org.apache.flex.utils.Timer.prototype.get_delay = function() {
 
 /**
  * @expose
- * @param {Number} value The number of milliseconds between events.
+ * @param {number} value The number of milliseconds between events.
  */
 org.apache.flex.utils.Timer.prototype.set_delay = function(value) {
   this._delay = value;
@@ -146,7 +146,7 @@ org.apache.flex.utils.Timer.prototype.set_delay = function(value) {
 
 /**
  * @expose
- * @return {Number} The repeat count.
+ * @return {number} The repeat count.
  */
 org.apache.flex.utils.Timer.prototype.get_repeatCount = function() {
   return this._repeatCount;
@@ -155,7 +155,7 @@ org.apache.flex.utils.Timer.prototype.get_repeatCount = function() {
 
 /**
  * @expose
- * @param {Number} value The repeat count.
+ * @param {number} value The repeat count.
  */
 org.apache.flex.utils.Timer.prototype.set_repeatCount = function(value) {
   this._repeatCount = value;


Mime
View raw message