flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmcl...@apache.org
Subject git commit: [flex-sdk] [refs/heads/develop] - Revert "FLEX-33874 improve binding performance"
Date Mon, 11 Nov 2013 07:09:37 GMT
Updated Branches:
  refs/heads/develop a8e90df8b -> f185862fb


Revert "FLEX-33874 improve binding performance"

This reverts commit ccdbfebd403b913c67d58b096f570d4c088fd0c1.


Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/f185862f
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/f185862f
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/f185862f

Branch: refs/heads/develop
Commit: f185862fb741a85cd36ffd8b2fd4b6d3b3e68bc9
Parents: a8e90df
Author: Justin Mclean <jmclean@apache.org>
Authored: Mon Nov 11 17:51:42 2013 +1100
Committer: Justin Mclean <jmclean@apache.org>
Committed: Mon Nov 11 17:51:42 2013 +1100

----------------------------------------------------------------------
 .../framework/src/mx/binding/Binding.as         | 23 +++-----------------
 1 file changed, 3 insertions(+), 20 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/f185862f/frameworks/projects/framework/src/mx/binding/Binding.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/framework/src/mx/binding/Binding.as b/frameworks/projects/framework/src/mx/binding/Binding.as
index 013c1a4..230f42b 100644
--- a/frameworks/projects/framework/src/mx/binding/Binding.as
+++ b/frameworks/projects/framework/src/mx/binding/Binding.as
@@ -83,7 +83,6 @@ public class Binding
         this.destFunc = destFunc;
         this.destString = destString;
         this.srcString = srcString;
-        this.destFuncFailed = false;
 
         if (this.srcFunc == null)
         {
@@ -235,8 +234,6 @@ public class Binding
      *  @productversion Flex 3
      */
     mx_internal var destFunc:Function;
-    
-    mx_internal var destFuncFailed:Boolean;
 
 	/**
      *  The destination represented as a String.
@@ -288,15 +285,6 @@ public class Binding
         while (i < (chain.length - 1))
         {
             element = element[chain[i++]];
-            //if the element does not exist : avoid exception as it's heavy on memory allocations
-            if (element == null || element == undefined) {
-                destFuncFailed = true;
-                if (BindingManager.debugDestinationStrings[destString])
-                {
-                    trace("Binding: destString = " + destString + ", error = 1009");
-                }
-                return;
-            }
         }
 
         element[chain[i]] = value;
@@ -413,9 +401,6 @@ public class Binding
         try
         {
             var result:Object = wrappedFunction.apply(thisArg, args);
-            if (destFuncFailed) {
-                return null;
-            }
             wrappedFunctionSuccessful = true;
             return result;
         }
@@ -507,11 +492,9 @@ public class Binding
         	{
 	            destFunc.call(document, value);
 
-                if (!destFuncFailed) {
-                    //	Note: state is not updated if destFunc throws
-                    lastValue = value;
-                    hasHadValue = true;
-	            }
+	            //	Note: state is not updated if destFunc throws
+	            lastValue = value;
+	            hasHadValue = true;
 	        }
         }
     }


Mime
View raw message