flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erikdebr...@apache.org
Subject [3/5] git commit: [flex-falcon] [refs/heads/develop_strictest] - '@this' JSDoc annotation not needed for methods on the class prototype.
Date Wed, 13 Nov 2013 10:46:03 GMT
'@this' JSDoc annotation not needed for methods on the class prototype.

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/26be7272
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/26be7272
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/26be7272

Branch: refs/heads/develop_strictest
Commit: 26be7272d866a6929502f0f1986851bbc4e8c594
Parents: 183b4c8
Author: Erik de Bruin <erik@ixsoftware.nl>
Authored: Wed Nov 13 10:48:56 2013 +0100
Committer: Erik de Bruin <erik@ixsoftware.nl>
Committed: Wed Nov 13 10:48:56 2013 +0100

----------------------------------------------------------------------
 .../internal/codegen/js/flexjs/JSFlexJSDocEmitter.java | 13 -------------
 .../codegen/mxml/flexjs/MXMLFlexJSEmitter.java         |  8 --------
 2 files changed, 21 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/26be7272/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
index 66dab8b..b5e78f7 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSDocEmitter.java
@@ -89,19 +89,6 @@ public class JSFlexJSDocEmitter extends JSGoogDocEmitter
                     emitMethodAccess(node);
                     hasDoc = true;
                 }
-
-                // @this
-                if (containsThisReference(node))
-                {
-                    if (!hasDoc)
-                    {
-                        begin();
-                        emitMethodAccess(node);
-                        hasDoc = true;
-                    }
-
-                    emitThis(classDefinition, classDefinition.getPackageName());
-                }
             }
 
             // @param

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/26be7272/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
index 732fc4b..4dfbf36 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
@@ -20,7 +20,6 @@
 package org.apache.flex.compiler.internal.codegen.mxml.flexjs;
 
 
-import java.io.File;
 import java.io.FilterWriter;
 import java.util.ArrayList;
 import java.util.List;
@@ -266,7 +265,6 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements
 
         writeNewline("/**");
         writeNewline(" * @expose");
-        writeNewline(" * @this {" + cname + "}");
         writeNewline(" */");
         writeNewline(cname
                 + ".prototype._bindings = [");
@@ -560,7 +558,6 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements
         for (MXMLEventSpecifier event : events)
         {
             writeNewline("/**");
-            writeNewline(" * @this {" + cname + "}");
             writeNewline(" * @expose");
             writeNewline(" * @param {" + event.type + "} event");
             writeNewline(" */");
@@ -589,7 +586,6 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements
             {
                 writeNewline("/**");
                 writeNewline(" * @expose");
-                writeNewline(" * @this {" + cname + "}");
                 writeNewline(" * @return {" + instance.name + "}");
                 writeNewline(" */");
                 writeNewline(cname
@@ -603,7 +599,6 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements
                 writeNewline();
                 writeNewline("/**");
                 writeNewline(" * @expose");
-                writeNewline(" * @this {" + cname + "}");
                 writeNewline(" * @param {" + instance.name + "} value");
                 writeNewline(" */");
                 writeNewline(cname
@@ -635,7 +630,6 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements
     
             writeNewline("/**");
             writeNewline(" * @override");
-            writeNewline(" * @this {" + cname + "}");
             writeNewline(" * @return {Array} the Array of UI element descriptors.");
             writeNewline(" */");
             writeNewline(cname + ".prototype.get_MXMLDescriptor = function()");
@@ -678,7 +672,6 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements
         {
             writeNewline("/**");
             writeNewline(" * @override");
-            writeNewline(" * @this {" + cname + "}");
             writeNewline(" * @return {Array} the Array of UI element descriptors.");
             writeNewline(" */");
             writeNewline(cname + ".prototype.get_MXMLProperties = function()");
@@ -1343,7 +1336,6 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements
             writeNewline();
             writeNewline("/**");
             writeNewline(" * @expose");
-            writeNewline(" * @this {" + cname + "}");
             writeNewline(" */");
             StringBuilder sb = new StringBuilder();
             sb.append(cname);


Mime
View raw message