flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erikdebr...@apache.org
Subject [03/11] git commit: [flex-falcon] [refs/heads/develop] - Removed an @Ignore and TODO, with documentation.
Date Tue, 05 Nov 2013 12:45:29 GMT
Removed an @Ignore and TODO, with documentation.

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/68e0b487
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/68e0b487
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/68e0b487

Branch: refs/heads/develop
Commit: 68e0b487c0bf95c0262245c4a90d1148ef4f9822
Parents: 15f1e13
Author: Erik de Bruin <erik@ixsoftware.nl>
Authored: Sun Nov 3 11:17:56 2013 +0100
Committer: Erik de Bruin <erik@ixsoftware.nl>
Committed: Tue Nov 5 07:15:07 2013 +0100

----------------------------------------------------------------------
 .../codegen/js/flexjs/TestFlexJSGlobalFunctions.java   | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/68e0b487/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSGlobalFunctions.java
----------------------------------------------------------------------
diff --git a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSGlobalFunctions.java
b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSGlobalFunctions.java
index 8391625..298ef08 100644
--- a/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSGlobalFunctions.java
+++ b/compiler.jx.tests/src/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSGlobalFunctions.java
@@ -33,17 +33,20 @@ import org.junit.Test;
  */
 public class TestFlexJSGlobalFunctions extends TestGoogGlobalFunctions
 {
-    @Ignore
     @Override
     @Test
     public void testArray()
     {
         IVariableNode node = getVariable("var a:Array = Array(1);");
         asBlockWalker.visitVariable(node);
-        // TODO (aharui) claims this is not valid and someday needs to result in:
-        //     a = new Array()
-        // I cannot find any reference to creating an array of a particular
-        // size in JS.
+        // (erikdebruin) The Actionscript and JavaScript implementations of
+        //               Array are identical in this regard, Array() can be
+        //               called as a function (without new) and if the argument
+        //               is a single integer, an Array with that length is 
+        //               returned:
+        //
+        //               https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array
+        //
         assertOut("var /** @type {Array} */ a = Array(1)");
     }
 


Mime
View raw message