flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erikdebr...@apache.org
Subject [2/5] git commit: [flex-falcon] [refs/heads/develop] - Revert "Added JSDoc file annotation with @suppress to make the remaining GCC type warnings go away. There are small inconsistencies between the AS and goog JS type (e.g. in goog, 'string' is not an O
Date Sat, 16 Nov 2013 15:20:20 GMT
Revert "Added JSDoc file annotation with @suppress to make the remaining GCC type warnings
go away. There are small inconsistencies between the AS and goog JS type (e.g. in goog, 'string'
is not an Object), that we cannot compensate for. Since the AS compiler takes care of the
type checking on the AS code, IMHO we need not worry that we cover up any runtime errors with
this @suppress."

This reverts commit b3f4b7e9454f8a8d1e241922dc0deffc6d653e06.

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/774b8899
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/774b8899
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/774b8899

Branch: refs/heads/develop
Commit: 774b889904eebda1c7a4b2c2693bd6c7014ac349
Parents: b3f4b7e
Author: Erik de Bruin <erik@ixsoftware.nl>
Authored: Sat Nov 16 15:47:22 2013 +0100
Committer: Erik de Bruin <erik@ixsoftware.nl>
Committed: Sat Nov 16 15:47:22 2013 +0100

----------------------------------------------------------------------
 .../compiler/internal/codegen/js/goog/JSGoogEmitter.java    | 9 ---------
 .../internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java     | 9 ---------
 2 files changed, 18 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/774b8899/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
index 717a24c..dc039a9 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/js/goog/JSGoogEmitter.java
@@ -110,15 +110,6 @@ public class JSGoogEmitter extends JSEmitter implements IJSGoogEmitter
         if (type == null)
             return;
 
-        writeNewline("/**");
-        writeNewline(" * " + type.getQualifiedName());
-        writeNewline(" *");
-        writeNewline(" * @fileoverview");
-        writeNewline(" *");
-        writeNewline(" * @suppress {checkTypes}");
-        writeNewline(" */");
-        writeNewline();
-        
         /* goog.provide('x');\n\n */
         write(JSGoogEmitterTokens.GOOG_PROVIDE);
         write(ASEmitterTokens.PAREN_OPEN);

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/774b8899/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
----------------------------------------------------------------------
diff --git a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
index f722223..68bad5e 100644
--- a/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
+++ b/compiler.jx/src/org/apache/flex/compiler/internal/codegen/mxml/flexjs/MXMLFlexJSEmitter.java
@@ -1380,15 +1380,6 @@ public class MXMLFlexJSEmitter extends MXMLEmitter implements
         String cname = node.getFileNode().getName();
         String bcname = node.getBaseClassName();
 
-        writeNewline("/**");
-        writeNewline(" * " + cname);
-        writeNewline(" *");
-        writeNewline(" * @fileoverview");
-        writeNewline(" *");
-        writeNewline(" * @suppress {checkTypes}");
-        writeNewline(" */");
-        writeNewline();
-        
         emitHeaderLine(cname, true); // provide
         writeNewline();
         emitHeaderLine(bcname);


Mime
View raw message