flex-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From erikdebr...@apache.org
Subject [07/11] git commit: [flex-asjs] [refs/heads/develop] - Fixed some more type checking issues when using '-strict' compiler setting.
Date Wed, 13 Nov 2013 10:44:38 GMT
Fixed some more type checking issues when using '-strict' compiler setting.

Signed-off-by: Erik de Bruin <erik@ixsoftware.nl>


Project: http://git-wip-us.apache.org/repos/asf/flex-asjs/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-asjs/commit/3ba90615
Tree: http://git-wip-us.apache.org/repos/asf/flex-asjs/tree/3ba90615
Diff: http://git-wip-us.apache.org/repos/asf/flex-asjs/diff/3ba90615

Branch: refs/heads/develop
Commit: 3ba90615aa73bddaef3bdf3be09299f260763a78
Parents: d2211fc
Author: Erik de Bruin <erik@ixsoftware.nl>
Authored: Wed Nov 13 09:33:20 2013 +0100
Committer: Erik de Bruin <erik@ixsoftware.nl>
Committed: Wed Nov 13 09:33:20 2013 +0100

----------------------------------------------------------------------
 .../js/FlexJS/src/org/apache/flex/core/ViewBase.js      |  8 ++++----
 .../src/org/apache/flex/events/ValueChangeEvent.js      | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/3ba90615/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js b/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js
index 7db4417..6307328 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/core/ViewBase.js
@@ -43,9 +43,9 @@ org.apache.flex.core.ViewBase = function() {
 
   /**
    * @private
-   * @type {Object}
+   * @type {string}
    */
-  this.currentState_ = null;
+  this.currentState_ = '';
 
 };
 goog.inherits(org.apache.flex.core.ViewBase, org.apache.flex.core.UIBase);
@@ -140,7 +140,7 @@ org.apache.flex.core.ViewBase.prototype.hasState = function(state) {
 
 /**
  * @expose
- * @return {Object} The name of the current state.
+ * @return {string} The name of the current state.
  */
 org.apache.flex.core.ViewBase.prototype.get_currentState = function() {
   return this.currentState_;
@@ -149,7 +149,7 @@ org.apache.flex.core.ViewBase.prototype.get_currentState = function()
{
 
 /**
  * @expose
- * @param {Object} value The name of the current state.
+ * @param {string} value The name of the current state.
  */
 org.apache.flex.core.ViewBase.prototype.set_currentState = function(value) {
   var event = new org.apache.flex.events.ValueChangeEvent(

http://git-wip-us.apache.org/repos/asf/flex-asjs/blob/3ba90615/frameworks/js/FlexJS/src/org/apache/flex/events/ValueChangeEvent.js
----------------------------------------------------------------------
diff --git a/frameworks/js/FlexJS/src/org/apache/flex/events/ValueChangeEvent.js b/frameworks/js/FlexJS/src/org/apache/flex/events/ValueChangeEvent.js
index 875c5e2..70b1292 100644
--- a/frameworks/js/FlexJS/src/org/apache/flex/events/ValueChangeEvent.js
+++ b/frameworks/js/FlexJS/src/org/apache/flex/events/ValueChangeEvent.js
@@ -22,8 +22,8 @@ goog.require('goog.events.Event');
  * @constructor
  * @extends {goog.events.Event}
  * @param {string} type The event type.
- * @param {Object} ov The old value.
- * @param {Object} nv The new value.
+ * @param {*} ov The old value.
+ * @param {*} nv The new value.
  */
 org.apache.flex.events.ValueChangeEvent = function(type, ov, nv) {
   goog.base(this, type);
@@ -54,14 +54,14 @@ org.apache.flex.events.ValueChangeEvent.prototype.type = '';
 
 /**
  * @expose
- * @type {Object} oldValue The old value.
+ * @type {*} oldValue The old value.
  */
 org.apache.flex.events.ValueChangeEvent.prototype.oldValue = null;
 
 
 /**
  * @expose
- * @type {Object} newValue The new value.
+ * @type {*} newValue The new value.
  */
 org.apache.flex.events.ValueChangeEvent.prototype.newValue = null;
 
@@ -84,8 +84,8 @@ org.apache.flex.events.ValueChangeEvent.prototype.source = null;
  * @expose
  * @param {Object} source The object that changed.
  * @param {string} name The property that changed.
- * @param {Object} oldValue The old value.
- * @param {Object} newValue The new value.
+ * @param {*} oldValue The old value.
+ * @param {*} newValue The new value.
  * @return {Object} An event object.
  */
 org.apache.flex.events.ValueChangeEvent.createUpdateEvent =


Mime
View raw message